Re: [JOBS] Do not close stderr when /dev/tty fails to open

2009-06-27 Thread Herbert Xu
On Sat, May 23, 2009 at 12:23:08PM +1000, Herbert Xu wrote: > On Sun, Feb 22, 2009 at 07:33:04PM +0800, Herbert Xu wrote: > > [JOBS] Do not close stderr when /dev/tty fails to open > > Turns out that there was more to this than jobs.c The use of > savefd in redir ended up clos

Re: [JOBS] Do not close stderr when /dev/tty fails to open

2009-05-22 Thread Herbert Xu
On Sun, Feb 22, 2009 at 07:33:04PM +0800, Herbert Xu wrote: > [JOBS] Do not close stderr when /dev/tty fails to open Turns out that there was more to this than jobs.c The use of savefd in redir ended up closing the wrong file descriptor too, albeit in a harmless manner. I'm going to th

[JOBS] Do not close stderr when /dev/tty fails to open

2009-02-22 Thread Herbert Xu
[JOBS] Do not close stderr when /dev/tty fails to open As it stands if we fail to open /dev/tty we end up closing stderr after saving it at a higher fd. Thanks to David van Gorkom for reporting this. Signed-off-by: Herbert Xu diff --git a/ChangeLog b/ChangeLog index d87e5d4..dcb7182 100644