Re: [PATCH 1/2] mkbuiltins: Use a `while` loop rather than `nl`

2016-08-08 Thread Herbert Xu
Harald van Dijk wrote: > On 04/08/2016 07:54, Kylie McClain wrote: >> From: Kylie McClain >> >> nl, while specified in POSIX, is rather obscure and isn't provided by small >> coreutils implementations such as `busybox`. This while loop works just as >>

Re: [PATCH 1/2] mkbuiltins: Use a `while` loop rather than `nl`

2016-08-07 Thread Seb
On Sat, Aug 06, 2016 at 11:02:42AM +0200, Seb wrote: > This is an attempt to simplify the current implementation [...] BTW, I wonder if there is not a (virtual) bug with the current mkbuiltins. Look at the TRUECMD macro in the generated builtins.h: #define TRUECMD (builtincmd + 1) It doesn't

Re: [PATCH 1/2] mkbuiltins: Use a `while` loop rather than `nl`

2016-08-06 Thread Seb
On Thu, Aug 04, 2016 at 07:17:47PM +0200, Harald van Dijk wrote: > Given that dash was fairly recently changed to make it build on > Solaris 9, it seems like a mistake to break that again. Hello, This is an attempt to simplify the current implementation. This one does not require any temporary