Re: [PATCH 4/4] [VAR] Replace cmdenviron with localvars

2010-05-29 Thread Jilles Tjoelker
On Thu, May 27, 2010 at 01:51:41PM +1000, Herbert Xu wrote: > In order to ensure that local still works, it is now a special > built-in. Although there are reasons to do this (a 'local' function containing 'command local' would not work, and export, readonly and ksh93's typeset are special

Re: [PATCH 4/4] [VAR] Replace cmdenviron with localvars

2010-05-26 Thread Herbert Xu
On Thu, May 27, 2010 at 12:37:23AM +0200, Jilles Tjoelker wrote: > > This change breaks passing variable assignments to regular builtins. > For example, > dash -c 'HOME=/ cd; pwd' > This should print /. (For some reason, this does not work in ksh93 > either.) Thanks, I have fixed it as follows.

Re: [PATCH 4/4] [VAR] Replace cmdenviron with localvars

2010-05-26 Thread Jilles Tjoelker
On Wed, May 26, 2010 at 09:00:34PM +1000, Herbert Xu wrote: > [VAR] Replace cmdenviron with localvars > This patch replaces the cmdenviron mechanism for temporary command > variables with the localvars mechanism used by functions. > This reduces code size, and more importantly, makes the variable

[PATCH 4/4] [VAR] Replace cmdenviron with localvars

2010-05-26 Thread Herbert Xu
[VAR] Replace cmdenviron with localvars This patch replaces the cmdenviron mechanism for temporary command variables with the localvars mechanism used by functions. This reduces code size, and more importantly, makes the variable assignment take effect immediately as required by POSIX. Signed-of