Re: [PATCH] [VAR] Fix history (libedit only).

2010-09-08 Thread Herbert Xu
On Fri, Aug 13, 2010 at 01:52:09PM +, Jilles Tjoelker wrote: > Git commit 0df96793ef6aa103df228d7dfe56099b7d721a15 "[SHELL] Add > preliminary LINENO support" added the LINENO variable in the middle of > other initialized variables, causing some macros for TERM and HISTSIZE > to break (both of t

Re: [PATCH 2/2] [EVAL] clean up myhistedit.h

2010-09-08 Thread Herbert Xu
On Thu, Jul 08, 2010 at 10:36:20AM +0200, maximilian attems wrote: > fixes debug compilation of klibc: > In file included from usr/dash/eval.c:64: > usr/dash/myhistedit.h:34:22: error: histedit.h: No such file or directory > In file included from usr/dash/eval.c:64: > usr/dash/myhistedit.h:36: erro

Re: [PATCH 1/2] [JOBS] Debug compile fix

2010-09-08 Thread Herbert Xu
On Thu, Jul 08, 2010 at 10:36:19AM +0200, maximilian attems wrote: > No point in tracing a no longer undeclared "ps->cmd", fixes: > jobs.c: In function ‘commandtext’: > jobs.c:1192: error: ‘ps’ undeclared (first use in this function) > jobs.c:1192: error: (Each undeclared identifier is reported onl

Re: [Partial patch] IFS and read builtin

2010-09-08 Thread Herbert Xu
Jilles Tjoelker wrote: > > The intention is that if there are more fields than variables, the final > variable receive the exact text after the already assigned fields and > their delimiters (apart from trailing IFS whitespace). The POSIX.1-2008 > text achieves this if used with the POSIX.1-2008 f

Re: [Partial patch] IFS and read builtin

2010-09-08 Thread Herbert Xu
Harald van Dijk wrote: > [-- text/plain, encoding 7bit, charset: ISO-8859-1, 20 lines --] > > Hi, as has been reported already dash currently has a bug where the read > builtin ignores the read environment's IFS setting. As a result, > > echo a:b | { IFS=: read a b; echo $a; } > > will write

Re: [Partial patch] IFS and read builtin

2010-09-08 Thread Herbert Xu
On Wed, Sep 08, 2010 at 07:53:24PM +0800, Herbert Xu wrote: > > commit 5c7042771753d5a968b2b7263cf9f4e02fa3820e > Author: Herbert Xu > Date: Wed Sep 8 19:51:10 2010 +0800 > > [EXPAND] Fix ifsfirst/ifslastp leak Slight update, should also call ifsfree instead of removerecordregion in read(

Re: dash klibc DEBUG more compile trouble

2010-09-08 Thread maximilian attems
On Sun, 11 Jul 2010, Herbert Xu wrote: > maximilian attems wrote: > > once taken that stat/stat64 appart, histedit appears to be a minefield: > > Unless you have libedit, you're supposed to define SMALL. indeed we do define it, but it was due to my poor Kconfig foo that it gets undefined again

Re: dash klibc DEBUG more compile trouble

2010-09-08 Thread Sam Ravnborg
On Wed, Sep 08, 2010 at 06:20:17PM +0200, maximilian attems wrote: > On Sun, 11 Jul 2010, Herbert Xu wrote: > > > maximilian attems wrote: > > > once taken that stat/stat64 appart, histedit appears to be a minefield: > > > > Unless you have libedit, you're supposed to define SMALL. > > indeed w