Re: [PATCH] [v5] quote arguments in xtrace output

2018-04-19 Thread Herbert Xu
Martijn Dekker wrote: > > The xtrace (set -x) output in dash is a bit of a pain, because arguments > containing whitespace aren't quoted. This can it impossible to tell > which bit belongs to which argument: Sorry, but one of the key goals of dash is to be as small as

Re: [PATCH] [v5] quote arguments in xtrace output

2018-04-19 Thread Martijn Dekker
Op 19-04-18 om 12:14 schreef Herbert Xu: Sorry, but one of the key goals of dash is to be as small as possible. So that means no features unless absolutely necessary. As such I cannot accept this patch as it is. Would you accept it if it were a configure option, disabled by default (like

Re: Add subdir-objects to AM_INIT_AUTOMAKE

2018-04-19 Thread Herbert Xu
Jason Bowen wrote: > [-- text/plain, encoding 7bit, charset: UTF-8, 10 lines --] > > I've attached a patch which adds the subdir-objects option to > AM_INIT_AUTOMAKE. > > For a while now when I've compiled dash I received a warning from > automake that there are source

Re: [PATCH] expand: remove unnecessary code in backquote expansion

2018-04-19 Thread Ron Yorston
Herbert Xu wrote: >Unfortunately we may need this at some point in the future due >to changes in POSIX. So let's keep it around for now until we >get things such as `jobs -p` to work. As you wish. Something even more trivial I noticed later: the TRACE at the end

Re: dash bug

2018-04-19 Thread sylvain . bertrand
On Thu, Apr 19, 2018 at 06:22:19PM +0800, Herbert Xu wrote: > sylvain.bertr...@gmail.com wrote: > > Hi, > > > > after commit:ab1cecb4047864afb247a6ed691e7f59ce716f2c > > the following script snippet won't work anymore (extracted from libtool) > > > > test.sh: > > --- > > #!/bin/sh > >