[PATCH 2/5] Enable automake silent rules

2018-10-16 Thread Antonio Ospite
Enable automake silent rules to make it easier to spot compilation problems. Silent rules will be enabled by default, but only if they are available, in order to keep compatibility with older autotools versions. Prepend the silent strings also to custom rules. Signed-off-by: Antonio Ospite ---

[PATCH 4/5] Stop using deprecated function sigsetmask()

2018-10-16 Thread Antonio Ospite
sigsetmask() is deprecated, at least on recent glibc; stop using it to silence the following compiler warning: --- system.h:40:2: warning: ‘sigsetmask’ is deprecated [-Wdeprecated-declarations] sigsetmask(0); ^~ In

[PATCH 1/5] Update configure.ac with suggestions from autoupdate

2018-10-16 Thread Antonio Ospite
Apply the changes suggested by running autoupdate on the source repository: 1. Properly quote AC_INIT arguments. 2. Use AC_USE_SYSTEM_EXTENSIONS instead of AC_GNU_SOURCE. The former is a superset of the latter, and enables more options, see

Re: [PATCH 4/5] Stop using deprecated function sigsetmask()

2018-10-16 Thread Jilles Tjoelker
On Tue, Oct 16, 2018 at 06:42:19PM +0200, Antonio Ospite wrote: > sigsetmask() is deprecated, at least on recent glibc; stop using it to > silence the following compiler warning: > --- > system.h:40:2: warning: ‘sigsetmask’ is

Re: [PATCH] eval: make traps work when "set -e" is enabled

2018-10-16 Thread Antonio Ospite
On Tue, 16 Oct 2018 14:09:52 +0200 Antonio Ospite wrote: [...] > I am marking the patch as RFC because I don't know the dash codebase very > well, and I might not be aware of possible drawbacks of this change. It worked > in my limited testing but that's it. > I forgot the '--rfc' option when

[PATCH] eval: make traps work when "set -e" is enabled

2018-10-16 Thread Antonio Ospite
When "set -e" is enabled traps are not always executed, in particular the EXIT trap is not executed when the shell exits on an unhandled error. Consider the following test script: #!/bin/dash set -e trap 'ret=$?; echo "EXIT: $ret"' EXIT trap 'exit 2' HUP INT QUIT PIPE TERM read