[PATCH 2/5] Enable automake silent rules

Enable automake silent rules to make it easier to spot compilation problems. Silent rules will be enabled by default, but only if they are available, in order to keep compatibility with older autotools versions. Prepend the silent strings also to custom rules. Signed-off-by: Antonio Ospite

[PATCH 4/5] Stop using deprecated function sigsetmask()

; ^~ --- Using sigprocmask() and friends unconditionally should not be a problem, as commit e94a964 (eval: Add vfork support, 2018-05-19) also does it. Signed-off-by: Antonio Ospite --- configure.ac | 2 +- src/system.h | 4 2 files changed, 1 insertion

[PATCH 1/5] Update configure.ac with suggestions from autoupdate

/autoconf-2.60/html_node/Posix-Variants.html Signed-off-by: Antonio Ospite --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4829288..594fb42 100644 --- a/configure.ac +++ b/configure.ac @@ -1,4 +1,4 @@ -AC_INIT(dash, 0.5.10.2

Re: [PATCH] eval: make traps work when "set -e" is enabled

On Tue, 16 Oct 2018 14:09:52 +0200 Antonio Ospite wrote: [...] > I am marking the patch as RFC because I don't know the dash codebase very > well, and I might not be aware of possible drawbacks of this change. It worked > in my limited testing but that's it. > I forgot the '--rfc'

[PATCH] eval: make traps work when "set -e" is enabled

IT PIPE TERM read variable By pressing Ctrl-C one would expect the EXIT trap to be called, as it is the case with other shells (bash, zsh), but dash does not do it. By calling dotrap() before jumping to the exit path when checkexit is not zero, dash behaves like other shells. Signed-off-by: Ant

Re: [PATCH 0/5] Build system updates and gcc warnings fixes

On Tue, 16 Oct 2018 18:42:15 +0200 Antonio Ospite wrote: > Hi, > > here are some build system updates and some fixes for compilation > warnings with Gcc. > > After this patchset, compilation with Gcc is nice and clean, > [...] > .gitignore | 2 ++ > configure

[PATCH 0/2] Fixing clang compilation warnings

cleanly with it too. This also makes the output of "scan-build make" more usable, however fixing the issues found by the static analyzer is not something I am going to work on anytime soon. Ciao, Antonio Antonio Ospite (2): Fix clang warnings about "string plus integer" Fix

[PATCH 2/2] Fix clang warnings about GNU old-style field designator

of the codebase, like src/expand.c:ccmatch() and src/parser.c::readtoken1(). Signed-off-by: Antonio Ospite --- src/output.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/output.c b/src/output.c index 34243ea..e9ee9b4 100644 --- a/src/output.c +++ b/src

Re: [PATCH 0/5] Build system updates and gcc warnings fixes

On Mon, 19 Nov 2018 13:04:45 +0100 Antonio Ospite wrote: > On Sat, 27 Oct 2018 15:35:11 +0200 > Antonio Ospite wrote: > > > On Tue, 16 Oct 2018 18:42:15 +0200 > > Antonio Ospite wrote: > > > > > Hi, > > > > > > here are some build system

Re: [PATCH] main: don't raise exception when executing dotcmd() on a non-existent file

On Sat, 24 Nov 2018 18:56:48 +0100 Jilles Tjoelker wrote: > On Sat, Nov 24, 2018 at 05:20:21PM +0100, Antonio Ospite wrote: > > When sourcing a file with the dotcmd() builtin, dash raises an exception > > when the input file cannot be opened. > > > For instance th

Re: system: Disable gcc warning on sigsetmask

gcc around our one and only use > of sigsetmask. > > Reported-by: Antonio Ospite > Signed-off-by: Herbert Xu > > diff --git a/src/system.h b/src/system.h > index a8d09b3..f3aa930 100644 > --- a/src/system.h > +++ b/src/system.h > @@ -37,7 +37,14 @@ > static inline void

Re: eval: Use sh_warnx instead of warnx

On Tue, 20 Nov 2018 10:09:26 +0800 Herbert Xu wrote: > Antonio Ospite wrote: > > > > BTW a new warning was introduced by commit 8e43729 (eval: Report I/O > > error on stdout, 2018-09-07): > > > > CC eval.o > > eval.c: In function ‘evalblti

Re: [v2 PATCH] system: Disable glibc warning on sigsetmask

On Wed, 21 Nov 2018 11:45:04 +0800 Herbert Xu wrote: > On Tue, Nov 20, 2018 at 11:48:20PM +0100, Antonio Ospite wrote: > > > > Just for the record, compiling with clang (CC=clang ./configure && make) > > still gives a warning: > > OK, we could di

Re: [PATCH 0/5] Build system updates and gcc warnings fixes

On Sat, 27 Oct 2018 15:35:11 +0200 Antonio Ospite wrote: > On Tue, 16 Oct 2018 18:42:15 +0200 > Antonio Ospite wrote: > > > Hi, > > > > here are some build system updates and some fixes for compilation > > warnings with Gcc. > > > > After this pat