Björn Tackmann wrote:
some days ago I wrote you an e-mail stating that some tests for DateTime::Format::Duration failed. Today, I spent some more time on looking for the reason. The good news is: your module does not seem to be flawed :)
hahah .. thanks Björn .. telling me that gave me the impetus to finally get it fixed. However by the time I finished, I decided that it wasn't all just bad tests. For the first test, I'd agree that the test itself is incorrect: # Test 41 -- the second day has 25 hours ['0000-00-00 48:00:00', '0000-00-01 23:00:00', 'DST ends, Day is 25 hours long'], Should be: ['0000-00-00 48:00:00', '0000-00-01 24:00:00', 'DST ends, Day is 25 hours long'], However going the rest I don't agree that it's just a case of fixing the tests and so I've refactored the code. Look for 1.03 on a CPAN mirror near you shortly. Cheers! Rick Measham
smime.p7s
Description: S/MIME Cryptographic Signature
