Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

2014-04-16 Thread Peter Ujfalusi
On 04/14/2014 05:32 PM, Sekhar Nori wrote: Yes, you can. But as soon as you have other devices using the same priority (with eDMA3 at least) and asks for a 'long' transfer it can ruin the audio. During audio playback/capture you execute a long MMC read for example can introduce a glitch.

Re: [PATCH v2 05/14] arm: common: edma: Select event queue 1 as default when booted with DT

2014-04-16 Thread Joel Fernandes
On 04/16/2014 07:59 AM, Peter Ujfalusi wrote: [..] If the dma-priority is missing we should assume lowest priority (0). The highest priority depends on the platform. For eDMA3 in AM335x it is three level. For designware controller you might have the range 0-8 as valid. The question is how

Re: [PATCH v3 00/10] dma: edma: Fixes for cyclic (audio) operation

2014-04-16 Thread Joel Fernandes
On 04/14/2014 06:41 AM, Peter Ujfalusi wrote: Hi, Changes since v2: - Dropped patch 10 from v2 (simplify direction configuration...) - Dropped the channel priority related patches since we are going to go via different route for configuring the priority. - Added ACK from Joel for the

Re: DA850 - SD detection broken by edma change (but only on mainline)

2014-04-16 Thread Peter Howard
On Tue, 2014-04-15 at 08:34 +1000, Peter Howard wrote: On Mon, 2014-04-14 at 14:02 +0530, Sekhar Nori wrote: Peter, On Monday 14 April 2014 12:30 PM, Peter Howard wrote: For the DA850, I've found that trying to detection of a card in the SD slot during boot is broken as of 3.12 on

[PATCH] dmaengine: edma: No need save/restore interrupt flags during spin_lock in IRQ

2014-04-16 Thread Joel Fernandes
The vchan lock in edma_callback is acquired in hard interrupt context. As interrupts are already disabled, there's no point in save/restoring interrupt mask bit or cpsr flags. Get rid of flags local variable and use spin_lock instead of spin_lock_irqsave. Signed-off-by: Joel Fernandes