Re: [PATCH V3] i2c: move of helpers into the core

2013-08-28 Thread Grant Likely
s.nawro...@samsung.com Signed-off-by: Wolfram Sang w...@the-dreams.de Acked-by: Grant Likely grant.lik...@linaro.org --- V2-V3: Was trying to be too smart by only fixing includes needed. Took a more general approach this time, converting of_i2c.h to i2c.h in case i2c.h

Re: [PATCH v5 0/5] Patch enables support for m25p64 SPI flash support on da850-EVM.

2013-04-16 Thread Grant Likely
on Grant's ack seem very low risk to me and we are much delayed already to wait further. For both of those patches: Acked-by: Grant Likely grant.lik...@secretlab.ca ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com

RE: [PATCH 0/4] Enable SPI flash support on da850-evm DT kernel

2013-03-03 Thread Grant Likely
On Wed, 27 Feb 2013 11:32:39 +, Manjunathappa, Prakash prakash...@ti.com wrote: On Wed, Feb 27, 2013 at 14:09:57, Nori, Sekhar wrote: On 2/25/2013 4:14 PM, Manjunathappa, Prakash wrote: Patch enables support for m25p80 SPI flash support on da850-EVM. Testing information:

Re: [PATCH 1/4] spi/davinci: fix module build error

2013-03-03 Thread Grant Likely
On Wed, 27 Feb 2013 13:57:07 +0530, Sekhar Nori nsek...@ti.com wrote: On 2/25/2013 4:14 PM, Manjunathappa, Prakash wrote: Fix below module build error: CC [M] drivers/spi/spi-davinci.o drivers/spi/spi-davinci.c:774:1: error: '__mod_of_device_table' aliased to undefined symbol

Re: [PATCH] spi: davinci: use request_threaded_irq() to fix deadlock

2013-02-05 Thread Grant Likely
On Wed, 2 Jan 2013 10:19:08 -0500, Murali Karicheri m-kariche...@ti.com wrote: On 12/22/2012 05:08 AM, Grant Likely wrote: On Fri, 21 Dec 2012 15:13:26 -0500, Murali Karicherim-kariche...@ti.com wrote: With RT pre-empt patch applied to Linux kernel, the irq handler will be force

Re: [PATCH] spi: davinci: use request_threaded_irq() to fix deadlock

2012-12-22 Thread Grant Likely
), - dspi); + ret = request_threaded_irq(dspi-irq, davinci_spi_irq, dummy_thread_fn, + 0, dev_name(pdev-dev), dspi); if (ret) goto unmap_io; -- 1.7.9.5 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd

Re: [PATCH - v2] spi: davinci: add OF support for the spi controller

2012-12-19 Thread Grant Likely
On Sat, 15 Dec 2012 00:27:58 +, Grant Likely grant.lik...@secretlab.ca wrote: On Tue, 11 Dec 2012 16:20:39 -0500, Murali Karicheri m-kariche...@ti.com wrote: This adds OF support to DaVinci SPI controller to configure platform data through device bindings. Also replaces clk_enable

Re: [PATCH - v2] spi: davinci: add OF support for the spi controller

2012-12-14 Thread Grant Likely
(). Signed-off-by: Murali Karicheri m-kariche...@ti.com Reviewed-by : Grant Likely grant.lik...@secretlab.ca Applied, thanks. I did remove the OF_ALIAS_N property though. I know the COMPATIBLE one uses it, but it is actually kind of redundant since it can also be determined by counting the number

Re: [PATCH] mtd: nand: davinci: fix the binding documentation

2012-12-10 Thread Grant Likely
-mask-ale = 0; + ti,davinci-mask-cle = 0; + ti,davinci-mask-chipsel = 0; + ti,davinci-ecc-mode = hw; + ti,davinci-ecc-bits = 4; + ti,davinci-nand-use-bbt; }; -- 1.7.4.1 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd

Re: [linux-keystone] [PATCH v1 1/1] spi: davinci: add OF support for the spi controller

2012-12-05 Thread Grant Likely
Murali. Thanks for the patch. Comments below... Signed-off-by: Murali Karicheri m-kariche...@ti.com Reviewed-by : Grant Likely grant.lik...@secretlab.ca --- .../devicetree/bindings/spi/spi-davinci.txt| 51 ++ drivers/spi/spi-davinci.c | 102

Re: [linux-keystone] Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-12-03 Thread Grant Likely
On Fri, 30 Nov 2012 17:57:38 -0500, Murali Karicheri m-kariche...@ti.com wrote: On 11/15/2012 11:20 AM, Grant Likely wrote: On Mon, 12 Nov 2012 16:28:22 -0500, Murali Karicheri m-kariche...@ti.com wrote: This adds OF support to DaVinci SPI controller to configure platform data through

Re: [linux-keystone] Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-11-21 Thread Grant Likely
On Fri, 16 Nov 2012 11:32:46 -0500, Murali Karicheri m-kariche...@ti.com wrote: On 11/15/2012 11:20 AM, Grant Likely wrote: On Mon, 12 Nov 2012 16:28:22 -0500, Murali Karicheri m-kariche...@ti.com wrote: This adds OF support to DaVinci SPI controller to configure platform data through

Re: [linux-keystone] [PATCH] spi: davinci: add OF support for the spi controller

2012-11-15 Thread Grant Likely
, .remove = __devexit_p(davinci_spi_remove), -- 1.7.9.5 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Grant Likely
to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Davinci-linux-open-source mailing list

Re: [RFC PATCH 3/3] mmc: davinci: get SG segment limits with dma_get_channel_caps()

2012-10-23 Thread Grant Likely
On Fri, Oct 19, 2012 at 3:51 AM, Matt Porter mpor...@ti.com wrote: Replace the hardcoded values used to set max_segs/max_seg_size with a dma_get_channel_caps() query to the dmaengine driver. Signed-off-by: Matt Porter mpor...@ti.com Series looks reasonable to me. Reviewed-by: Grant Likely

Re: [RFC PATCH 1/3] dmaengine: add dma_get_channel_caps()

2012-10-23 Thread Grant Likely
-- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Grant Likely, B.Sc., P.Eng. Secret Lab

Re: [RFC PATCH v2 00/16] DMA Engine support for AM33xx

2012-10-11 Thread Grant Likely
Hey Matt, Do you know now similar are the EDMA engines on the am33xx and am389x? I've been working on am389x upstreaming and I'll try these patches out if it is the same engine. g. On Oct 11, 2012 8:03 PM, Matt Porter mpor...@ti.com wrote: Changes since v1: - Rebased on top of

Re: [PATCH v4 5/7] ARM: davinci: i2c: add OF support

2012-05-26 Thread Grant Likely
Cc: linux-...@vger.kernel.org Cc: Ben Dooks ben-li...@fluff.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de Cc: Sylwester Nawrocki s.nawro...@samsung.com --- - changes for v2: - add comments

Re: [PATCH v4 1/7] ARM: davinci, intc: Add irq domain support

2012-05-26 Thread Grant Likely
On Tue, 22 May 2012 15:55:14 +0200, Heiko Schocher h...@denx.de wrote: Signed-off-by: Heiko Schocher h...@denx.de Cc: davinci-linux-open-source@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc: Grant Likely grant.lik...@secretlab.ca Cc

Re: [PATCH v3 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller

2012-05-26 Thread Grant Likely
@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de Cc: Sergei Shtylyov sshtyl...@mvista.com --- - changes for v2: - add comment from Grant Likely

Re: [PATCH v3 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller

2012-05-19 Thread Grant Likely
@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de Cc: Sergei Shtylyov sshtyl...@mvista.com --- - changes for v2: - add comment from Grant Likely

Re: [PATCH RFC] spi: spi-davinci: Fix DMA API usage in davinci

2012-03-24 Thread Grant Likely
On Thu, 22 Mar 2012 21:31:03 +0530, Shubhrajyoti Datta omaplinuxker...@gmail.com wrote: Hi Sekhar, On Thu, Mar 22, 2012 at 8:08 PM, Nori, Sekhar nsek...@ti.com wrote: Hi Grant, On Tue, Mar 20, 2012 at 21:53:34, Grant Likely wrote: On Tue, 20 Mar 2012 16:10:09 +0530, Shubhrajyoti D

Re: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request

2012-03-12 Thread Grant Likely
On Sun, 11 Mar 2012 18:16:11 +0530, Sekhar Nori nsek...@ti.com wrote: Unbanked GPIO irq setup code was overwriting chip_data leading to the following oops on request_irq() Unable to handle kernel paging request at virtual address febf [...] Fix the issue. Applied, but for next time Fix

Re: [PATCH 2/2] gpio/davinci: fix enabling unbanked GPIO IRQs

2012-03-12 Thread Grant Likely
); + irq_set_chip(irq, gpio_unbanked.chip); irq_set_handler_data(irq, chips[gpio / 32]); irq_set_status_flags(irq, IRQ_TYPE_EDGE_BOTH); } -- 1.7.0.4 -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies,Ltd

RE: [PATCH 1/2] gpio/davinci: fix oops on unbanked gpio irq request

2012-03-12 Thread Grant Likely
On Mon, 12 Mar 2012 18:54:53 +, Nori, Sekhar nsek...@ti.com wrote: Hi Grant, On Mon, Mar 12, 2012 at 23:21:35, Grant Likely wrote: On Sun, 11 Mar 2012 18:16:11 +0530, Sekhar Nori nsek...@ti.com wrote: Unbanked GPIO irq setup code was overwriting chip_data leading to the following

Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

2012-02-01 Thread Grant Likely
On Wed, Feb 01, 2012 at 02:20:13PM +0400, Sergei Shtylyov wrote: Hello. On 31-01-2012 17:04, Heiko Schocher wrote: On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote: - AM1808 based board - 64 MiB DDR ram - 2 MiB Nor flash - 128 MiB NAND flash - use internal RTC - I2C

Re: [RFC PATCH 4/7] ARM: davinci: net: davinci_emac: add OF support

2012-02-01 Thread Grant Likely
On Tue, Jan 31, 2012 at 12:27:11PM +0100, Heiko Schocher wrote: Hello Grant, Grant Likely wrote: On Mon, Jan 23, 2012 at 09:56:04AM +0100, Heiko Schocher wrote: add of support for the davinci_emac driver. Signed-off-by: Heiko Schocher h...@denx.de Cc: davinci-linux-open-source

Re: [RFC PATCH 1/7] ARM: davinci, intc: Add OF support for TI interrupt controller

2012-02-01 Thread Grant Likely
...@lists.infradead.org Cc: devicetree-disc...@lists.ozlabs.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de --- .../devicetree/bindings/arm/davinci/intc.txt | 26 ++ arch/arm/mach-davinci/cp_intc.c| 51

Re: [RFC PATCH 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board

2012-01-30 Thread Grant Likely
On Mon, Jan 23, 2012 at 09:56:07AM +0100, Heiko Schocher wrote: - AM1808 based board - 64 MiB DDR ram - 2 MiB Nor flash - 128 MiB NAND flash - use internal RTC - I2C support - hwmon lm75 support - UBI/UBIFS support - MMC support - USB OTG support Signed-off-by: Heiko Schocher

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-01-30 Thread Grant Likely
On Tue, Jan 24, 2012 at 10:51:50AM +0100, Sylwester Nawrocki wrote: Hello Heiko, On 01/24/2012 08:18 AM, Heiko Schocher wrote: On 01/23/2012 09:56 AM, Heiko Schocher wrote: add of support for the davinci i2c driver. Signed-off-by: Heiko Schocherh...@denx.de Cc:

Re: [RFC PATCH 4/7] ARM: davinci: net: davinci_emac: add OF support

2012-01-30 Thread Grant Likely
...@vger.kernel.org Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de --- .../bindings/arm/davinci/davinci_emac.txt | 46 drivers/net/ethernet/ti/davinci_emac.c | 111 +++- 2 files

Re: [RFC PATCH 5/7] ARM: davinci: i2c: add OF support

2012-01-30 Thread Grant Likely
: linux-...@vger.kernel.org Cc: Ben Dooks ben-li...@fluff.org Cc: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc: Sekhar Nori nsek...@ti.com Cc: Wolfgang Denk w...@denx.de Hi Heiko, comments below. --- .../devicetree/bindings/arm/davinci/i2c.txt| 39

Re: [RFC/RFT 1/2] gpio/basic_mmio: add support for enable register

2011-07-07 Thread Grant Likely
On Thu, Jul 07, 2011 at 10:15:31PM +0530, Nori, Sekhar wrote: Hi Grant, On Thu, Jul 07, 2011 at 02:40:54, Grant Likely wrote: On Tue, Jul 05, 2011 at 04:15:44PM +1000, Ryan Mallon wrote: On 05/07/11 15:10, Sekhar Nori wrote: Some GPIO controllers have an enable register which needs

Re: [RFC/RFT 1/2] gpio/basic_mmio: add support for enable register

2011-07-06 Thread Grant Likely
On Tue, Jul 05, 2011 at 04:15:44PM +1000, Ryan Mallon wrote: On 05/07/11 15:10, Sekhar Nori wrote: Some GPIO controllers have an enable register which needs to be written to before a GPIO can be used. Add support for enabling the GPIO. At this time inverted logic for enabling the GPIO is

Re: [RFC/RFT 2/2] davinci: use generic memory mapped gpio for tnetv107x

2011-07-06 Thread Grant Likely
On Tue, Jul 05, 2011 at 10:41:00AM +0530, Sekhar Nori wrote: The GPIO controller on TNETV107x SoC can use the generic memory mapped GPIO driver. Shift to the generic driver instead of the private implementation. Signed-off-by: Sekhar Nori nsek...@ti.com ---

Re: [RFC 2/8] remoteproc: add omap implementation

2011-06-29 Thread Grant Likely
On Wed, Jun 29, 2011 at 9:04 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Tue, Jun 28, 2011 at 12:00 AM, Grant Likely grant.lik...@secretlab.ca wrote: Very little for me to comment on here.  However, something I just noticed.  Why is it necessary to pass in THIS_MODULE to the rproc_register

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-29 Thread Grant Likely
On Tue, Jun 28, 2011 at 5:00 PM, Ohad Ben-Cohen o...@wizery.com wrote: On Wed, Jun 29, 2011 at 1:51 AM, Grant Likely grant.lik...@secretlab.ca wrote: It's not the device_for_each_child() that you're 'putting' back from here.  Its the original kref initialization when the device was created

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-28 Thread Grant Likely
On Tue, Jun 28, 2011 at 4:46 PM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Grant, On Tue, Jun 28, 2011 at 1:21 AM, Grant Likely grant.lik...@secretlab.ca wrote: +static int rpmsg_remove_device(struct device *dev, void *data) +{ +     struct rpmsg_channel *rpdev = to_rpmsg_channel(dev

Re: [RFC 1/8] drivers: add generic remoteproc framework

2011-06-27 Thread Grant Likely
On Tue, Jun 21, 2011 at 10:18:27AM +0300, Ohad Ben-Cohen wrote: Some systems have slave heterogeneous remote processor devices, that are usually used to offload cpu-intensive computations (e.g. multimedia codec tasks). Booting a remote processor typically involves: - Loading a firmware

Re: [RFC 2/8] remoteproc: add omap implementation

2011-06-27 Thread Grant Likely
On Tue, Jun 21, 2011 at 10:18:28AM +0300, Ohad Ben-Cohen wrote: From: Guzman Lugo, Fernando fernando.l...@ti.com Add remoteproc implementation for OMAP4, so we can load the M3 and DSP remote processors. Based on code by Hari Kanigeri h-kanige...@ti.com While this code is functional, and

Re: [RFC 7/8] drivers: introduce rpmsg, a remote-processor messaging bus

2011-06-27 Thread Grant Likely
On Tue, Jun 21, 2011 at 10:18:33AM +0300, Ohad Ben-Cohen wrote: Add a virtio-based IPC bus, which enables kernel users to communicate with remote processors over shared memory using a simple messaging protocol. Assign a local address for every local endpoint that is created, and bind it to

Re: [RFC 1/8] drivers: add generic remoteproc framework

2011-06-27 Thread Grant Likely
On Mon, Jun 27, 2011 at 09:52:30PM +, Grosen, Mark wrote: From: Grant Likely Sent: Monday, June 27, 2011 1:50 PM Grant, thanks for the feedback. I'll try to answer one of your questions below and leave the rest for Ohad. Mark +Every remoteproc implementation must provide

Re: [RFC 1/8] drivers: add generic remoteproc framework

2011-06-27 Thread Grant Likely
On Mon, Jun 27, 2011 at 5:29 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Jun 27, 2011 at 02:49:58PM -0600, Grant Likely wrote: +struct { +      char magic[4] = { 'R', 'P', 'R', 'C' }; +      u32 version; +      u32 header_len; +      char header

Re: [RFC 0/8] Introducing a generic AMP/IPC framework

2011-06-21 Thread Grant Likely
On Tue, Jun 21, 2011 at 8:20 AM, Arnd Bergmann a...@arndb.de wrote: Hi Ohad, On Tuesday 21 June 2011, Ohad Ben-Cohen wrote: This patch set adds a generic AMP/IPC framework which makes it possible to control (power on, boot, power off) and communicate (simply send and receive messages) with

Re: [RFC PATCH] Consolidate SRAM support

2011-04-15 Thread Grant Likely
On Fri, Apr 15, 2011 at 9:26 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Apr 15, 2011 at 04:40:00PM +0200, Arnd Bergmann wrote: On Friday 15 April 2011 15:39:55 Rob Herring wrote: On 04/15/2011 08:06 AM, Russell King - ARM Linux wrote: This is work in progress.

Re: [PATCH v8 03/11] gpio: add ti-ssp gpio driver

2011-03-17 Thread Grant Likely
please review and ack the GPIO part of this series too? I see that you have already acked the SPI part of this work. Acked-by: Grant Likely grant.lik...@secretlab.ca Sorry for the delay on this. I can take it through my tree if you like. It's a new driver, so I don't have any concerns about

Re: [PATCH v1] spi: davinci: Support DMA transfers larger than 65535 words

2011-03-14 Thread Grant Likely
On Mon, Mar 14, 2011 at 11:49:02AM -0400, Michael Williamson wrote: The current davinci SPI driver, in DMA mode, is limited to 65535 words for a single transfer. Modify the driver by configuring a 3 dimensional EDMA transfer to support up to 65535x65535 words. Signed-off-by: Michael

Re: [PATCH] spi: davinci: Use correct length parameter to dma_map_single calls

2011-03-14 Thread Grant Likely
On Sun, Mar 13, 2011 at 10:34:21AM -0400, Michael Williamson wrote: The davinci spi driver provides an option to use DMA transfers for data. In the dma_map_single() call, the driver is passing the number of words to be transfered for the mapping size. It should be the number of bytes.

Re: [PATCH v2] davinci: spi: move event queue parameter to platform data

2011-02-08 Thread Grant Likely
...@ti.com With Grant's ack, will merge this through davinci tree. Acked-by: Grant Likely grant.lik...@secretlab.ca Kevin --- Changes since v1:    - Add Sekhar's Ack.    - Really fix the typo.  This time for sure (blew the format patch      on last go around).  arch/arm/mach-davinci/dm355.c

Re: [PATCH v8 02/11] spi: add ti-ssp spi master driver

2011-01-17 Thread Grant Likely
On Mon, Jan 17, 2011 at 02:15:16PM -0500, Cyril Chemparathy wrote: This patch adds an SPI master implementation that operates on top of an underlying TI-SSP port. Signed-off-by: Cyril Chemparathy cy...@ti.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- drivers/spi/Kconfig

Re: [PATCH v7 00/12] tnetv107x ssp drivers

2010-12-30 Thread Grant Likely
patches. Grant Likely said he might take it over so sending stuff his way might prod him into action. I probably will pick up GPIO, but not just yet. I've got to get my dt and spi house in order first (making good progress here. I've got an autotest instance set up so that I can apply and test

Re: [PATCH v7 08/12] gpio: add ti-ssp gpio driver

2010-12-30 Thread Grant Likely
On Tue, Dec 07, 2010 at 09:51:58AM -0500, Cyril Chemparathy wrote: TI's SSP controller pins can be directly read and written to behave like a GPIO. This patch adds a GPIO driver that exposes such functionality. Signed-off-by: Cyril Chemparathy cy...@ti.com --- drivers/gpio/Kconfig |

Re: [PATCH v7 04/12] spi: add ti-ssp spi master driver

2010-12-30 Thread Grant Likely
On Tue, Dec 07, 2010 at 09:51:54AM -0500, Cyril Chemparathy wrote: This patch adds an SPI master implementation that operates on top of an underlying TI-SSP port. Signed-off-by: Cyril Chemparathy cy...@ti.com Mostly looks okay, but I'm not thrilled with the ss scheme (see comments below).

Re: [PATCH v5 04/12] spi: add ti-ssp spi master driver

2010-12-21 Thread Grant Likely
On Tue, Nov 16, 2010 at 11:34:09AM +, Mark Brown wrote: On Tue, Nov 16, 2010 at 12:47:04AM -0700, Grant Likely wrote: On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely Instead, it is now incumbent on the board support code to ensure that any device that depends on another device

Re: [PATCH v5 01/12] misc: add driver for sequencer serial port

2010-12-21 Thread Grant Likely
On Tue, Nov 16, 2010 at 9:15 AM, Cyril Chemparathy cy...@ti.com wrote: On 11/16/2010 02:10 AM, Grant Likely wrote: On Mon, Nov 15, 2010 at 02:12:03PM -0500, Cyril Chemparathy wrote: TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port device.  It has a built

Re: [PATCH 00/49] spi: davinci: re-write existing driver

2010-12-11 Thread Grant Likely
On Sat, Dec 11, 2010 at 8:34 AM, Michael Williamson michael.william...@criticallink.com wrote: On 11/18/2010 08:14 AM, Nori, Sekhar wrote: Hi Grant, On Thu, Nov 18, 2010 at 17:01:24, Nori, Sekhar wrote: On Thu, Nov 18, 2010 at 12:23:24, Nori, Sekhar wrote: Here is the pull request: The

Re: [PATCH v6 08/12] gpio: add ti-ssp gpio driver

2010-11-21 Thread Grant Likely
On Sun, Nov 21, 2010 at 1:02 PM, Ryan Mallon r...@bluewatersys.com wrote: On 11/20/2010 04:55 AM, Cyril Chemparathy wrote: TI's SSP controller pins can be directly read and written to behave like a GPIO.  This patch adds a GPIO driver that exposes such functionality. Signed-off-by: Cyril

Re: [PATCH v5 01/12] misc: add driver for sequencer serial port

2010-11-20 Thread Grant Likely
On Mon, Nov 15, 2010 at 02:12:03PM -0500, Cyril Chemparathy wrote: TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port device. It has a built-in programmable execution engine that can be programmed to operate as almost any serial bus (I2C, SPI, EasyScale, and

Re: [PATCH v5 04/12] spi: add ti-ssp spi master driver

2010-11-19 Thread Grant Likely
On Mon, Nov 15, 2010 at 02:12:06PM -0500, Cyril Chemparathy wrote: This patch adds an SPI master implementation that operates on top of an underlying TI-SSP port. Signed-off-by: Cyril Chemparathy cy...@ti.com [...] +static int __init ti_ssp_spi_init(void) +{ + return

Re: [PATCH v5 04/12] spi: add ti-ssp spi master driver

2010-11-19 Thread Grant Likely
On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Nov 15, 2010 at 02:12:06PM -0500, Cyril Chemparathy wrote: This patch adds an SPI master implementation that operates on top of an underlying TI-SSP port. Signed-off-by: Cyril Chemparathy cy...@ti.com

Re: [PATCH 00/49] spi: davinci: re-write existing driver

2010-11-17 Thread Grant Likely
On Wed, Nov 17, 2010 at 04:13:32PM +0530, Sekhar Nori wrote: This patch series represents a break-up into reviewable portions of the work originally done by Brian and posted here: https://patchwork.kernel.org/patch/114924/ While this series does not exactly add up to what Brian's patch

Re: [PATCH v5 04/12] spi: add ti-ssp spi master driver

2010-11-17 Thread Grant Likely
On Tue, Nov 16, 2010 at 07:17:18PM -0500, Cyril Chemparathy wrote: On 11/16/2010 02:47 AM, Grant Likely wrote: On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Nov 15, 2010 at 02:12:06PM -0500, Cyril Chemparathy wrote: This patch adds an SPI master

Re: [PATCH v5 01/12] misc: add driver for sequencer serial port

2010-11-16 Thread Grant Likely
On Tue, Nov 16, 2010 at 3:23 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 16, 2010 at 01:35:40PM -0700, Grant Likely wrote: I'll let Russel make the decision here; but I must admit I'm puzzled.                 ^ Grr. Sorry; typo. I *do* know how to spell your name

Re: [PATCH v4 08/12] gpio: add ti-ssp gpio driver

2010-11-09 Thread Grant Likely
On Tue, Nov 02, 2010 at 07:15:16PM -0700, David Brownell wrote: --- On Tue, 10/26/10, Cyril Chemparathy cy...@ti.com wrote: From: Cyril Chemparathy cy...@ti.com Subject: [PATCH v4 08/12] gpio: add ti-ssp gpio driver On the assumptions you've tested this *AND* will resubmit with the

Re: [PATCH v4 08/12] gpio: add ti-ssp gpio driver

2010-11-09 Thread Grant Likely
On Tue, Nov 09, 2010 at 10:16:22PM -0800, David Brownell wrote: I thought the point of this device was that a single [SSP] device hosted a pair of multi-function serial interfaces, with each implementing a separate function. function chosen based on what the board needs. Codec

Re: [PATCH v2 01/12] misc: add driver for sequencer serial port

2010-10-20 Thread Grant Likely
, and others). This patch adds a driver for this controller device. The driver does not expose a user-land interface. Protocol drivers built on top of this layer are expected to remain in-kernel. Signed-off-by: Cyril Chemparathy cy...@ti.com I like this version much better. Acked-by: Grant

Re: [PATCH v2 08/12] gpio: add ti-ssp virtual gpio driver

2010-10-20 Thread Grant Likely
On Mon, Oct 18, 2010 at 03:25:18PM -0400, Cyril Chemparathy wrote: This patch adds a GPIO driver based on TI's SSP device. This driver does not support GPIO-IRQs. Signed-off-by: Cyril Chemparathy cy...@ti.com Acked-by: Grant Likely grant.lik...@secretlab.ca --- arch/arm/mach-davinci

Re: [PATCH v2 04/12] spi: add ti-ssp spi master driver

2010-10-20 Thread Grant Likely
, but otherwise: Acked-by: Grant Likely grant.lik...@secretlab.ca This patch should be merged with the rest of the series. I don't think there is any point in me picking it up into the SPI tree. diff --git a/arch/arm/mach-davinci/include/mach/ti_ssp.h b/arch/arm/mach-davinci/include/mach/ti_ssp.h

Re: [PATCH 01/12] misc: add driver for sequencer serial port

2010-10-18 Thread Grant Likely
On Mon, Oct 18, 2010 at 7:56 AM, Cyril Chemparathy cy...@ti.com wrote: Hi Grant, Thanks for the feedback, I will send out an updated v2 with the proposed changes. [...] +EXPORT_SYMBOL(ti_ssp_open); I'm not thrilled with the ti_ssp_open()/ti_ssp_close() usage model. It appears that the

Re: [PATCH 01/12] misc: add driver for sequencer serial port

2010-10-15 Thread Grant Likely
On Thu, Oct 14, 2010 at 02:38:44PM -0400, Cyril Chemparathy wrote: TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port device. It has a built-in programmable execution engine that can be programmed to operate as almost any serial bus (I2C, SPI, EasyScale, and

Re: [PATCH 04/12] spi: add ti-ssp spi master driver

2010-10-15 Thread Grant Likely
On Thu, Oct 14, 2010 at 02:38:47PM -0400, Cyril Chemparathy wrote: This patch adds an SPI master implementation that operates on top of an underlying TI-SSP port. Signed-off-by: Cyril Chemparathy cy...@ti.com The driver looks good, but as mentioned in my previous comment, I'd like to see the

RE: [PATCH v5 1/1] davinci: spi: replace existing driver

2010-08-22 Thread Grant Likely
Nori, Sekhar nsek...@ti.com wrote: Hi Caglar, On Fri, Aug 20, 2010 at 16:36:33, Caglar Akyuz wrote: On Monday 02 August 2010 06:53:16 pm Nori, Sekhar wrote: Hi Brian, On Mon, Aug 02, 2010 at 19:40:29, Brian Niebuhr wrote: Grant - For my part, I've already sunk way more time

Re: [PATCH v5 1/1] davinci: spi: replace existing driver

2010-08-20 Thread Grant Likely
On Fri, Aug 20, 2010 at 5:06 AM, Caglar Akyuz caglarak...@gmail.com wrote: On Monday 02 August 2010 06:53:16 pm Nori, Sekhar wrote: Hi Brian, On Mon, Aug 02, 2010 at 19:40:29, Brian Niebuhr wrote: Grant -  For my part, I've already sunk way more time into this than I ever intended,

Re: [PATCH v5 1/1] davinci: spi: replace existing driver

2010-08-03 Thread Grant Likely
On Mon, Aug 2, 2010 at 8:10 AM, Brian Niebuhr bniebu...@gmail.com wrote: Grant - That's fine - I understand your position.  I do wish you had decided earlier that you weren't going to accept the patch in that form though so I could have decided whether I wanted to spend any more time on it.  

Re: [PATCH] spi: davinci: Added support for chip select using gpio

2010-07-06 Thread Grant Likely
-controller_data, \ +                               (spi-mode SPI_CS_HIGH));        }  } -- 1.7.0.4 -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Davinci-linux-open-source mailing list Davinci-linux-open-source

Re: [spi-devel-general] [PATCH 0/3] davinci: spi: replace existing SPI driver

2010-06-29 Thread Grant Likely
On Mon, Jun 28, 2010 at 11:27 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jun 28, 2010 at 10:57 AM, Nori, Sekhar nsek...@ti.com wrote: Hi Grant, On Sun, Jun 27, 2010 at 11:33:13, Grant Likely wrote: Any users of the current davinci_spi driver care to comment on this series

Re: [spi-devel-general] [PATCH 0/3] davinci: spi: replace existing SPI driver

2010-06-29 Thread Grant Likely
On Tue, Jun 29, 2010 at 2:01 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jun 28, 2010 at 11:27 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Mon, Jun 28, 2010 at 10:57 AM, Nori, Sekhar nsek...@ti.com wrote: Hi Grant, On Sun, Jun 27, 2010 at 11:33:13, Grant Likely wrote

Re: [spi-devel-general] [PATCH 0/3] davinci: spi: replace existing SPI driver

2010-06-27 Thread Grant Likely
/lists/listinfo/spi-devel-general -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [spi-devel-general] [PATCH 0/3] davinci: spi: replace existing SPI driver

2010-06-17 Thread Grant Likely
On Mon, Jun 14, 2010 at 1:15 PM, Brian Niebuhr bnieb...@efjohnson.com wrote: Can you please post this series to SPI development list (spi-devel-gene...@lists.sourceforge.net) CCing the maintainers David Brownell and Grant Likely? Done I had to go looking for these patches. I see that you