Hi Prabhakar,
This patch series looks good, except for this one.
If you add create_bufs support, then you should also update queue_setup.
If the fmt argument to queue_setup is non-NULL, then check that the
fmt.pix.sizeimage field is = the current format's sizeimage. If not,
return -EINVAL.
, Prabhakar prabhakar.cse...@gmail.com
Cc: Pawel Osciak pa...@osciak.com
Cc: Marek Szyprowski m.szyprow...@samsung.com
Cc: Kyungmin Park kyungmin.p...@samsung.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
include/media/videobuf2-core.h | 9 +
1 file changed, 9 insertions(+)
diff --git
Prabhakar,
Are you going to make a pull request for this, or shall I take it? Should it be
applied
to 3.16?
Regards,
Hans
On 06/13/2014 08:13 PM, Prabhakar Lad wrote:
On Thu, Jun 12, 2014 at 8:01 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
We recently changed some locking
Hi Prabhakar,
Thanks for this patch series, it looks good to me and I'll make a pull
request for this.
I did find a few issues, but they are all pre-existing problems, so they
can be fixed in follow-up patches.
I'll comment on those in the relevant patches. Since display and capture are
so
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
this patch adds support to release the buffer by calling
vb2_buffer_done(), with state marked as VB2_BUF_STATE_QUEUED
if start_streaming() call back fails.
Signed-off-by: Lad, Prabhakar
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
this patch uses SIMPLE_DEV_PM_OPS, and drops unneeded members
from io_usrs, usrs and makes use of vb2 helepers instead.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
---
On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Hi,
This patch series upgrades the vpif capture display
driver with the all the helpers provided by v4l, this makes
the driver much simpler and cleaner. This also includes few
checkpatch
On 05/14/2014 07:28 PM, Prabhakar Lad wrote:
Hi Hans,
Thanks for the review.
On Mon, May 12, 2014 at 3:20 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Prabhakar,
Thanks for the patch, but I have a few comments...
On 05/12/2014 10:58 AM, Lad, Prabhakar wrote:
Buffer ioctls
Hi Prabhakar,
Some review comments below. I'm going through the code quite carefully since
this very nice cleanup is a good opportunity to check for correct behavior in
this driver.
On 04/04/2014 07:17 AM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch
On 03/31/2014 07:24 PM, Prabhakar Lad wrote:
Hi Hans,
On Mon, Mar 31, 2014 at 8:34 PM, Hans Verkuil hverk...@xs4all.nl wrote:
Hi Prabhakar,
This looks really nice!
Writing a video driver has become really easy with almost 90% of work
done by v4l core itself :)
That was the idea!
I'll
Hi Prabhakar,
This looks really nice!
I'll do a full review on Friday, but in the meantime can you post the output
of 'v4l2-compliance -s' using the latest v4l2-compliance version? I've made
some commits today, so you need to do a git pull of v4l-utils.git.
I also have a small comment below:
variable
'vpbe_dev'
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Thanks!
Hans
---
drivers/media/platform/davinci/vpbe_display.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/davinci
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so I
never saw it.
Regards,
Hans
On 12/20/2013 01:47 PM, Prabhakar Lad wrote:
Hi Hans,
On Tue, Dec 17, 2013 at 8:55 PM, Lad, Prabhakar
Hi Prabhakar,
On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
Hi Hans,
On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil hverk...@xs4all.nl wrote:
I just made a patch myself that I added to the pull request I just posted.
You didn't CC me or CC the linux-media list when you posted your patch, so
On Wed 15 May 2013 13:57:16 Lad Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch series enables the ths7303 driver for asynchronous probing, OF
support with some cleanup patches.
Lad, Prabhakar (6):
media: i2c: ths7303: remove init_enable option from pdata
On Thu 23 May 2013 11:25:25 Prabhakar Lad wrote:
Hi Hans,
On Mon, May 13, 2013 at 11:34 AM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
Hi Wei,
Thanks for the patch.
On Mon, May 13, 2013 at 11:27 AM, Wei Yongjun weiyj...@gmail.com wrote:
From: Wei Yongjun
I can't merge as long as the async
code isn't in yet.
Regards,
Hans
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Guennadi
: Hans Verkuil hans.verk...@cisco.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Cc: Sakari Ailus sakari.ai...@iki.fi
Cc: Grant Likely
On Mon 13 May 2013 12:41:26 Prabhakar Lad wrote:
Hi Paul,
On Mon, May 13, 2013 at 3:35 PM, Paul Bolle pebo...@tiscali.nl wrote:
Prabhakar,
On Mon, 2013-05-13 at 15:27 +0530, Prabhakar Lad wrote:
Good catch! the dependency can be dropped now.
Great.
Are you planning to post a
On Wed May 22 2013 07:52:03 Prabhakar Lad wrote:
Hi All,
On Tue, May 14, 2013 at 11:15 AM, Lad Prabhakar
prabhakar.cse...@gmail.com wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch series cleanups the check for EPERM in dbg_g/s_register
and vidioc_g/s_register.
On Fri May 10 2013 06:48:38 Lad Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
The error path on failure was calling mutex_unlock(), but there was
no actuall call before for mutex_lock(). This patch fixes this issue
by pointing it to proper go label.
Reported-by: Jose
On Mon 1 April 2013 08:36:50 Prabhakar lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Add pm_runtime support to the TI Davinci VPIF driver.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Hans Verkuil hans.verk
On Tue 2 April 2013 15:41:30 Prabhakar lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
Add pm_runtime support to the TI Davinci VPIF driver.
Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Hans Verkuil hans.verk
:
blackfin: replace V4L2_IN/OUT_CAP_CUSTOM_TIMINGS by DV_TIMINGS (2013-03-08
09:55:51 +0100)
Hans Verkuil (12):
tvp7002: replace 'preset' by 'timings' in various structs/variables.
tvp7002: use dv_timings structs instead
From: Hans Verkuil hans.verk...@cisco.com
This removes some incorrect dv_preset references left over from copy-and-paste
errors.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Lad, Prabhakar prabhakar@ti.com
---
drivers/staging/media/davinci_vpfe/vpfe_video.c | 12
Hi all,
This patch series is for the most part identical to the RFC patch series
posted earlier:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg58762.html
The main changes are:
- dropped the Samsung-related patches, those will go through a separate
patch series.
- added patches
From: Hans Verkuil hans.verk...@cisco.com
In the functions tvp7002_mbus_fmt(), tvp7002_log_status and tvp7002_probe()
we should use the dv_timings data structures instead of dv_preset data
structures and functions.
This is the second step towards removing the deprecated preset support
From: Hans Verkuil hans.verk...@cisco.com
Finally remove the dv_preset support from this driver. Note that dv_preset
support was already removed from any bridge drivers that use this i2c
driver, so the dv_preset ops were no longer called and can be removed
safely.
Signed-off-by: Hans Verkuil
From: Hans Verkuil hans.verk...@cisco.com
Since vpbe_display already provides a g_std op setting current_norm
didn't do anything. Remove that code.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpbe_display.c | 10 +-
1 file changed, 1 insertion
From: Hans Verkuil hans.verk...@cisco.com
Remove VPBE_ENC_DV_PRESET (the DV_PRESET API is no longer supported) and
VPBE_ENC_CUSTOM_TIMINGS is renamed to VPBE_ENC_DV_TIMINGS since the old
CUSTOM_TIMINGS name is deprecated in favor of DV_TIMINGS.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
From: Hans Verkuil hans.verk...@cisco.com
The use of V4L2_IN/OUT_CAP_CUSTOM_TIMINGS is obsolete, use DV_TIMINGS instead.
Note that V4L2_IN/OUT_CAP_CUSTOM_TIMINGS is just a #define for
V4L2_IN/OUT_CAP_DV_TIMINGS.
At some point in the future these CUSTOM_TIMINGS defines might be removed.
Signed
From: Hans Verkuil hans.verk...@cisco.com
This is the first step towards removing the deprecated preset support of this
driver.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Acked-by: Lad, Prabhakar prabhakar@ti.com
---
drivers/media/i2c/tvp7002.c | 90
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpfe_capture.c | 47 -
1 file changed, 7 insertions(+), 40 deletions(-)
diff --git a/drivers/media/platform/davinci/vpfe_capture.c
b/drivers
From: Hans Verkuil hans.verk...@cisco.com
Since vpfe_capture already provided a g_std op setting current_norm
does not actually do anything. Remove it.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpfe_capture.c |1 -
1 file changed, 1 deletion
From: Hans Verkuil hans.verk...@cisco.com
The use of V4L2_OUT_CAP_CUSTOM_TIMINGS is deprecated, use DV_TIMINGS instead.
Note that V4L2_OUT_CAP_CUSTOM_TIMINGS is just a #define for
V4L2_OUT_CAP_DV_TIMINGS.
At some point in the future these CUSTOM_TIMINGS defines might be removed.
Signed-off
On Mon March 4 2013 10:29:26 Prabhakar Lad wrote:
Hi Hans,
On Mon, Mar 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote:
From: Hans Verkuil hans.verk...@cisco.com
drivers/media/platform/davinci/dm644x_ccdc.c: In function
‘validate_ccdc_param’:
drivers/media/platform/davinci
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/dm355_ccdc.c | 10 +-
drivers/media/platform/davinci/dm355_ccdc_regs.h |2 +-
drivers/media/platform/davinci/isif.c|2 +-
drivers
Hi all,
This is a second try at fixing the dm644x_ccdc compiler warning.
In addition it also fixes more 'gama' misspellings.
Prabhakar, can you look at this? I think this is a good solution
for this compiler warning.
Regards,
Hans
___
From: Hans Verkuil hans.verk...@cisco.com
drivers/media/platform/davinci/dm644x_ccdc.c: In function ‘validate_ccdc_param’:
drivers/media/platform/davinci/dm644x_ccdc.c:233:32: warning: comparison
between ‘enum ccdc_gama_width’ and ‘enum ccdc_data_size’ [-Wenum-compare]
It took a bit of work
On Sat February 16 2013 20:23:39 Sekhar Nori wrote:
On 2/16/2013 6:28 PM, Prabhakar Lad wrote:
Cc'ed Sekhar, DLOS, LAK.
Sekhar Can you Ack this patch ? Or maybe you can take this patch through
your tree ?
I can take the patch, but I can only send for v3.10 since for v3.9 ARM
tree is
, Prabhakar prabhakar@ti.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Martin Bugge marbu...@cisco.com
Cc: Chaithrika U S chaithr...@ti.com
---
Changes for v2:
1: Merged the driver in existing ths7303 driver.
2: Merged the patch which adds the chip indent in same
On Thu 10 January 2013 13:57:19 Federico Vaga wrote:
@Hans: here the output of v4l2-compliance that you request me for the v4
version. This is done on the v5 version where I applied your suggestion. I
have 1 warning but I don't understand where is the problem
To see the warning you need to
Liakhovetski g.liakhovet...@gmx.de
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Sakari Ailus sakari.ai...@iki.fi
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/platform/davinci/vpif_capture.c | 171
.
For the whole set --- granted that the TODO item to add support for regular
V4L2 applications through user space libraries is added:
Acked-by: Sakari Ailus sakari.ai...@iki.fi
Ditto for the TODO item.
Acked-by: Hans Verkuil hans.verk...@cisco.com
___
Davinci
On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
I wish people wouldn't submit big patches right before the merge
window opens... :/ It's better to let it sit in linux-next for a
couple weeks so people can mess with it a bit.
It's been under review for quite some time now, and the main
On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
Em Wed, 28 Nov 2012 12:56:10 +0100
Hans Verkuil hansv...@cisco.com escreveu:
On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
I wish people wouldn't
On Thu November 29 2012 00:47:41 Sylwester Nawrocki wrote:
On 11/28/2012 10:29 PM, Dan Carpenter wrote:
On Wed, Nov 28, 2012 at 08:30:04PM +0100, Sylwester Nawrocki wrote:
On 11/28/2012 01:22 PM, Dan Carpenter wrote:
In the end this is just a driver, and I don't especially care. But
it's
On Wed November 28 2012 20:30:21 Greg Kroah-Hartman wrote:
On Wed, Nov 28, 2012 at 08:18:20PM +0100, Hans Verkuil wrote:
On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
Em Wed, 28 Nov 2012 12:56:10 +0100
From: Hans Verkuil hans.verk...@cisco.com
The dma_queue list is accessed by both the interrupt handler and by normal
code. It needs to be protected by a lock to prevent possible list corruption.
Corruption has been observed in 'real-life' conditions. Adding this lock made
it go away.
Signed-off
Hi Prabhakar,
These two patches add protection to the dma_queue. We discovered that not
locking caused race conditions, which caused the display DMA to jam. After
adding the lock we never saw this again.
It makes sense as well since the interrupt routine and normal code both
manipulated the same
From: Hans Verkuil hans.verk...@cisco.com
The dma_queue list is accessed by both the interrupt handler and by normal
code. It needs to be protected by a lock to prevent possible list corruption.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.c
().
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.c |8 ++--
drivers/media/platform/davinci/vpif_display.c |8 ++--
2 files changed
Cc: Hans Verkuil hans.verk...@cisco.com
---
Changes for v2:
1: Change the bus_info and driver to proper values,
pointed by Hans.
drivers/media/platform/davinci/vpif_capture.c |9 ++---
drivers/media/platform/davinci/vpif_display.c |9 ++---
2 files changed, 12
Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
---
Changes for v2:
1: Added vb2_dma_contig_cleanup_ctx() on failure of
vb2_queue_init() to avoid memory leak, pointed by Hans.
drivers/media
: Hans Verkuil hans.verk...@cisco.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
---
Changes for v3:
1: Removed READWRITE flag for device_caps pointed by Hans.
Changes for v2:
1: Change the bus_info and driver to proper values,
pointed by Hans.
drivers
*'
make[4]: *** [drivers/media/platform/davinci/vpfe_capture.o] Error 1
Acked-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform
':
vpbe_display.c:640: warning: initialization discards qualifiers from pointer
target type
This patch fixes the above build warning.
Acked-by: Hans Verkuil hans.verk...@cisco.com
Prabhaker, can you make a pull request for this patch, the CUSTOM_TIMINGS
rename patch and the earlier vpfe: fix build
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_display.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/media/video/davinci/vpif_display.h
b/drivers/media/video/davinci/vpif_display.h
index 1263de6..ad22c70 100644
Hi Prabhakar,
This patch series does some driver cleanup and reorganizes the config
structs that are used to set up subdevices.
The current driver associates an input or output with a subdev, but multiple
inputs may use the same subdev and some inputs may not use a subdev at all
(this is the
input_idx does not belong to video_obj. Move it where it belongs.
Also remove the bogus code in the open() function that suddenly
changes the input to 0 for no reason.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_capture.c |9 ++---
drivers
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_capture.h |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/video/davinci/vpif_capture.h
b/drivers/media/video/davinci/vpif_capture.h
index aa6d3da..de19c80 100644
When device nodes are registered they must be ready for use
immediately, so make sure the subdevs are loaded first.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_capture.c | 55
1 file changed, 24 insertions(+), 31
The output index does not belong to video_obj, it belongs to
channel_obj. Also rename to output_idx to be consistent with
the input_idx name used in vpif_capture.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_display.c | 17 ++---
drivers
This makes it easier to have outputs without subdevs.
This needs more work. The way the outputs are configured should be identical
to how inputs are configured.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_display.c | 17 +
drivers
Calling a subdev op that isn't implemented will just return -ENOIOCTLCMD
No need to have a flag for that.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
arch/arm/mach-davinci/board-da850-evm.c|2 --
arch/arm/mach-davinci/board-dm646x-evm.c |2 --
drivers/media/video/davinci
Routing information is a property of the input, not of the subdev.
One subdev may provide multiple inputs, each with its own routing
information.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
arch/arm/mach-davinci/board-da850-evm.c|8
arch/arm/mach-davinci/board-dm646x
struct vpif_interface is channel specific, not subdev specific.
Move it to the channel config.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
arch/arm/mach-davinci/board-da850-evm.c| 24
arch/arm/mach-davinci/board-dm646x-evm.c | 24
When device nodes are registered they must be ready for use
immediately, so make sure the subdevs are loaded first.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_display.c | 59 ++--
1 file changed, 29 insertions(+), 30
is set to the fist input.
Currently missing is support for associating multiple subdevs with
an input.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/video/davinci/vpif_capture.c | 239 +---
drivers/media/video/davinci/vpif_capture.h |6 +-
2
Hi Prabhakar!
On Fri September 28 2012 14:44:59 Prabhakar Lad wrote:
Hi Kevin,
On Wed, Aug 8, 2012 at 6:00 PM, Prabhakar Lad prabhakar@ti.com wrote:
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Lad, Prabhakar prabhakar
On Tue September 25 2012 07:38:12 Prabhakar Lad wrote:
Hi Hans,
On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
Hi Hans,
On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon
and has routing
information. An output does not have to have a subdev.
The initial output for each channel is set to the fist output.
Currently missing is support for associating multiple subdevs with
an output.
Acked-by: Hans Verkuil hans.verk...@cisco.com
Looks good!
Regards
On Tue 25 September 2012 13:16:24 Prabhakar wrote:
From: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.c
On Tue 25 September 2012 15:26:11 Prabhakar Lad wrote:
Hi Hans/Laurent
On Tue, Sep 25, 2012 at 5:24 PM, Hans Verkuil hansv...@cisco.com wrote:
On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
Hi Hans,
On Tuesday 25 September 2012 13:43:36 Hans Verkuil wrote:
On Tue 25
Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
---
This patch is dependent on the patch series from Hans
(http://www.mail-archive.com/linux-media@vger.kernel.org/msg52270.html)
arch/arm/mach-davinci/board-da850-evm.c | 29 +-
arch/arm/mach-davinci/board
Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Sekhar Nori nsek...@ti.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
---
This patch is dependent on the patch series from Hans
(http://www.mail-archive.com/linux-media@vger.kernel.org/msg52270
On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
On Mon September 24 2012 12:44:11 Prabhakar wrote:
From: Lad, Prabhakar prabhakar@ti.com
vpif_display relied on a 1-1 mapping of output and subdev. This is not
necessarily the case. Separate the two. So there is a list of subdevs
On Mon September 24 2012 13:50:00 Hans Verkuil wrote:
On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
On Mon September 24 2012 12:44:11 Prabhakar wrote:
From: Lad, Prabhakar prabhakar@ti.com
vpif_display relied on a 1-1 mapping of output and subdev
On Mon September 24 2012 14:53:40 Prabhakar wrote:
From: Lad, Prabhakar prabhakar@ti.com
Add helper function v4l2_ctrl_new_std_menu_items(), which adds
a standard menu control, with driver specific menu.
Acked-by: Hans Verkuil hans.verk...@cisco.com
Regards,
Hans
Signed-off
On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
Hi Hans,
On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
On Mon September 24 2012 12:44:11 Prabhakar wrote:
From: Lad, Prabhakar prabhakar@ti.com
manjunath.ha...@ti.com
Acked-by: Sakari Ailus sakari.ai...@iki.fi
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Cc: Hans de Goede hdego...@redhat.com
Cc
Hi Prabhakar,
This is the second patch series for a vpif driver cleanup.
The first version can be found here:
http://www.mail-archive.com/linux-media@vger.kernel.org/msg52136.html
Changes since RFCv1:
- rebased to a newer git repo:
From: Hans Verkuil hans.verk...@cisco.com
The s_routing function should not try to detect a signal. It is a really
bad idea to try to detect a valid video signal and return an error if
you can't. Changing input should do just that and nothing more.
Also don't power on the ADCs on s_routing
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.h |6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif_capture.h
b/drivers/media/platform
From: Hans Verkuil hans.verk...@cisco.com
The output index does not belong to video_obj, it belongs to
channel_obj. Also rename to output_idx to be consistent with
the input_idx name used in vpif_capture.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci
From: Hans Verkuil hans.verk...@cisco.com
When device nodes are registered they must be ready for use
immediately, so make sure the subdevs are loaded first.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.c | 47 +++--
1
From: Hans Verkuil hans.verk...@cisco.com
input_idx does not belong to video_obj. Move it where it belongs.
Also remove the bogus code in the open() function that suddenly
changes the input to 0 for no reason.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci
From: Hans Verkuil hans.verk...@cisco.com
Calling a subdev op that isn't implemented will just return -ENOIOCTLCMD
No need to have a flag for that.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
arch/arm/mach-davinci/board-da850-evm.c |2 --
arch/arm/mach-davinci/board-dm646x
From: Hans Verkuil hans.verk...@cisco.com
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_display.h | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif_display.h
b/drivers/media/platform/davinci
From: Hans Verkuil hans.verk...@cisco.com
struct vpif_interface is channel specific, not subdev specific.
Move it to the channel config.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
arch/arm/mach-davinci/board-da850-evm.c | 24
arch/arm/mach-davinci
From: Hans Verkuil hans.verk...@cisco.com
The cleanup sequence was incorrect and could cause a kernel oops.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_capture.c | 41 -
1 file changed, 20 insertions(+), 21 deletions
From: Hans Verkuil hans.verk...@cisco.com
This makes it easier to have outputs without subdevs.
This needs more work. The way the outputs are configured should be identical
to how inputs are configured.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci
From: Hans Verkuil hans.verk...@cisco.com
The cleanup sequence was incorrect and could cause a kernel oops.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_display.c | 30 +++--
1 file changed, 18 insertions(+), 12 deletions
From: Hans Verkuil hans.verk...@cisco.com
When device nodes are registered they must be ready for use
immediately, so make sure the subdevs are loaded first.
Signed-off-by: Hans Verkuil hans.verk...@cisco.com
---
drivers/media/platform/davinci/vpif_display.c | 59 -
1
From: Hans Verkuil hans.verk...@cisco.com
vpif_capture relied on a 1-1 mapping of input and subdev. This is not
necessarily the case. Separate the two. So there is a list of subdevs
and a list of inputs. Each input refers to a subdev and has routing
information. An input does not have to have
, with driver specific menu.
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Sakari Ailus sakari.ai...@iki.fi
Cc: Sylwester Nawrocki s.nawro...@samsung.com
Cc: Laurent Pinchart laurent.pinch
On Tue 18 September 2012 12:53:02 Hans Verkuil wrote:
Hi Prabhakar,
This patch series does some driver cleanup and reorganizes the config
structs that are used to set up subdevices.
The current driver associates an input or output with a subdev, but multiple
inputs may use the same subdev
On Thu August 16 2012 16:02:00 Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
Acked-by: Hans Verkuil hans.verk...@cisco.com
prabhakar@ti.com
Add a helper function to modify the menu, max and default value
to set.
Signed-off-by: Lad, Prabhakar prabhakar@ti.com
Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Sakari Ailus sakari.ai...@iki.fi
Cc: Sylwester
Hi David,
On Wed 12 September 2012 00:03:32 David Oleszkiewicz wrote:
All,
I think I found a race condition with enabling interrupts in the
streamon call that I wanted some feedback on. I am actually using the
DaVinci PSP 03.03 GA Release (Build 37) kernel but I notice the same issue
1 - 100 of 238 matches
Mail list logo
