Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-18 Thread Vinod Koul
On Mon, Mar 17, 2014 at 09:14:14AM -0400, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: Hi Jon, On Monday 17 March 2014 06:28 PM, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before

Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-18 Thread Joel Fernandes
On 03/18/2014 10:28 AM, Vinod Koul wrote: On Mon, Mar 17, 2014 at 09:14:14AM -0400, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: Hi Jon, On Monday 17 March 2014 06:28 PM, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: The code to handle any length SG lists calls

Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-18 Thread Alexander Holler
Am 17.03.2014 14:14, schrieb Jon Ringle: On Mon, 17 Mar 2014, Sekhar Nori wrote: Can you please reply with a formal Tested-by: ? Tested-by: Jon Ringle jrin...@gridpoint.com Finally working mmc on davinci (didn't work without DMA here too). Tested-by: Alexander Holler hol...@ahsoftware.de

[PATCH] dma: edma: fix incorrect SG list handling

2014-03-17 Thread Sekhar Nori
The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume() enables edma events on the channel after which CPU (in edma_start) cannot clear posted events by writing to ECR (per the EDMA user's guide). Because of this EDMA

Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-17 Thread Jon Ringle
On Mon, 17 Mar 2014, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume() enables edma events on the channel after which CPU (in edma_start) cannot clear posted events by writing to ECR (per

Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-17 Thread Sekhar Nori
Hi Jon, On Monday 17 March 2014 06:28 PM, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume() enables edma events on the channel after which CPU

Re: [PATCH] dma: edma: fix incorrect SG list handling

2014-03-17 Thread Jon Ringle
On Mon, 17 Mar 2014, Sekhar Nori wrote: Hi Jon, On Monday 17 March 2014 06:28 PM, Jon Ringle wrote: On Mon, 17 Mar 2014, Sekhar Nori wrote: The code to handle any length SG lists calls edma_resume() even before edma_start() is called. This is incorrect because edma_resume()