Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-31 Thread Vinod Koul
On Thu, Oct 24, 2013 at 12:57:02PM -0500, Joel Fernandes wrote: Rebased on slave-dma/next branch and reapplied: Looks like your MUA caused lines to get wrapped and patch is corrupt, can you pls resend again using git-send email. I tried even the patch from patchworks but that too failed!

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-31 Thread Joel Fernandes
On 10/31/2013 09:10 AM, Vinod Koul wrote: On Thu, Oct 24, 2013 at 12:57:02PM -0500, Joel Fernandes wrote: Rebased on slave-dma/next branch and reapplied: Looks like your MUA caused lines to get wrapped and patch is corrupt, can you pls resend again using git-send email. I tried even the patch

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-24 Thread Vinod Koul
On Tue, Oct 22, 2013 at 10:30:43AM -0500, Joel Fernandes wrote: On 10/21/2013 01:53 AM, Vinod Koul wrote: On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: + nr_periods = (buf_len / period_len) + 1; ? consider the case of buf = period_len, above makes nr_period = 2.

Re: [PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-10-21 Thread Vinod Koul
On Mon, Sep 23, 2013 at 06:05:14PM -0500, Joel Fernandes wrote: @@ -449,6 +455,138 @@ static struct dma_async_tx_descriptor *edma_prep_slave_sg( return vchan_tx_prep(echan-vchan, edesc-vdesc, tx_flags); } +static struct dma_async_tx_descriptor *edma_prep_dma_cyclic( + struct

[PATCH 2/3] dma: edma: Add support for Cyclic DMA

2013-09-23 Thread Joel Fernandes
Using the PaRAM configuration function that we split for reuse by the different DMA types, we implement Cyclic DMA support. For the cyclic case, we pass different configuration parameters to this function, and handle all the Cyclic-specific functionality separately. Callbacks to the DMA users are