Re: [PATCH 3/4 v6] TVP7002 driver for DM365

2009-11-10 Thread Hans Verkuil
On Tuesday 10 November 2009 19:12:13 Santiago Nunez-Corrales wrote: > Hans, > > > Thanks for all your patient and detailed reviews. I've addressed most of > the comments. There is one thing though that seems odd but is there due > to a good reason. The devices requires to be turned off and on a

Re: [PATCH 3/4 v6] TVP7002 driver for DM365

2009-11-10 Thread Santiago Nunez-Corrales
Hans, Thanks for all your patient and detailed reviews. I've addressed most of the comments. There is one thing though that seems odd but is there due to a good reason. The devices requires to be turned off and on again during the s_stream function, in which it 'forgets' its previous state a

Re: [PATCH 3/4 v6] TVP7002 driver for DM365

2009-11-09 Thread Hans Verkuil
Hi Santiago, See review comments below: On Friday 06 November 2009 16:42:56 santiago.nu...@ridgerun.com wrote: > From: Santiago Nunez-Corrales > > This patch provides the implementation of the TVP7002 decoder > driver for DM365. Implemented using the V4L2 DV presets API. > > Signed-off-by: San