Re: [PATCH v2] da850-evm: UI expander gpio_set_value can sleep, use _cansleep

2010-11-18 Thread Kevin Hilman
Ben Gardiner bengardi...@nanometrics.ca writes: When the RMII PHY on the UI board is enabled with CONFIG_DA850_UI_RMII then then following will be printed to the console when warnings are also enabled: WARNING: at drivers/gpio/gpiolib.c:1567 __gpio_set_value+0x4c/0x5c() Modules linked in:

Re: [PATCH v2] da850-evm: UI expander gpio_set_value can sleep, use _cansleep

2010-11-18 Thread Ben Gardiner
On Thu, Nov 18, 2010 at 6:59 PM, Kevin Hilman khil...@deeprootsystems.com wrote: [...] Reviewed-by: Kevin Killman khil...@deeprootsystems.com s/Killman/Hilman/  with only one 'L' My apologies. Other than that, looks good. And thanks for the detailed description on how this was tested.

[PATCH v2] da850-evm: UI expander gpio_set_value can sleep, use _cansleep

2010-11-15 Thread Ben Gardiner
When the RMII PHY on the UI board is enabled with CONFIG_DA850_UI_RMII then then following will be printed to the console when warnings are also enabled: WARNING: at drivers/gpio/gpiolib.c:1567 __gpio_set_value+0x4c/0x5c() Modules linked in: [c002c6ac] (unwind_backtrace+0x0/0xf8) from [c003b48c]