Re: [PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct

2014-05-28 Thread Peter Ujfalusi
On 05/27/2014 06:03 PM, Joel Fernandes wrote: On 05/27/2014 05:22 AM, Peter Ujfalusi wrote: On 05/27/2014 12:32 AM, Olof Johansson wrote: [..] I came across this patch when I was looking at a pull request from Sekhar for EDMA cleanups, and it made me look closer at the contents of this

Re: [PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct

2014-05-27 Thread Peter Ujfalusi
On 05/27/2014 12:32 AM, Olof Johansson wrote: Hi, On Mon, Apr 14, 2014 at 4:41 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: The edmacc_param struct should follow the layout of the paRAM area in the HW. Be explicit on the size of the fields (u32) and also mark the struct as packed to

Re: [PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct

2014-05-27 Thread Joel Fernandes
On 05/27/2014 05:22 AM, Peter Ujfalusi wrote: On 05/27/2014 12:32 AM, Olof Johansson wrote: [..] I came across this patch when I was looking at a pull request from Sekhar for EDMA cleanups, and it made me look closer at the contents of this file. The include/linux/platform_data/ directory

Re: [PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct

2014-05-26 Thread Olof Johansson
Hi, On Mon, Apr 14, 2014 at 4:41 AM, Peter Ujfalusi peter.ujfal...@ti.com wrote: The edmacc_param struct should follow the layout of the paRAM area in the HW. Be explicit on the size of the fields (u32) and also mark the struct as packed to avoid any padding on non 32bit architectures.

[PATCH v3 01/10] platform_data: edma: Be precise with the paRAM struct

2014-04-14 Thread Peter Ujfalusi
The edmacc_param struct should follow the layout of the paRAM area in the HW. Be explicit on the size of the fields (u32) and also mark the struct as packed to avoid any padding on non 32bit architectures. Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Acked-by: Joel Fernandes jo...@ti.com