RE: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-10-11 Thread Jon Povey
Kevin Hilman wrote: I just noticed that it has already been pulled and is part of -rc7. Jon, care to submit a new patch with v4 diff and including the acks and tested-bys? Done and sent: Message-Id: 1286858825-21540-1-git-send-email-jon.po...@racelogic.co.uk -- Jon Povey

RE: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-10-07 Thread Jon Povey
Hi Ben, I am not on the i2c list but noticed this pull request: http://www.spinics.net/linux/lists/linux-i2c/msg04022.html I think you have the wrong (old) version of this patch in that branch,

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-10-07 Thread Kevin Hilman
Jon Povey jon.po...@racelogic.co.uk writes: Hi Ben, I am not on the i2c list but noticed this pull request: http://www.spinics.net/linux/lists/linux-i2c/msg04022.html I think you have the wrong (old) version of this patch in that branch,

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-10-07 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Jon Povey jon.po...@racelogic.co.uk writes: Hi Ben, I am not on the i2c list but noticed this pull request: http://www.spinics.net/linux/lists/linux-i2c/msg04022.html I think you have the wrong (old) version of this patch in that branch,

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-30 Thread Kevin Hilman
Ben Dooks ben-...@fluff.org writes: On Tue, Sep 21, 2010 at 12:17:58PM -0700, Troy Kisky wrote: On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-28 Thread Ben Dooks
On Tue, Sep 21, 2010 at 12:17:58PM -0700, Troy Kisky wrote: On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-28 Thread Ben Dooks
On Fri, Sep 24, 2010 at 07:37:03AM -0700, Kevin Hilman wrote: Sudhakar Rajashekhara sudhakar@ti.com writes: On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-27 Thread Kevin Hilman
Ben Dooks b...@trinity.fluff.org writes: On Fri, Sep 24, 2010 at 07:37:03AM -0700, Kevin Hilman wrote: Sudhakar Rajashekhara sudhakar@ti.com writes: On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-24 Thread Kevin Hilman
Sudhakar Rajashekhara sudhakar@ti.com writes: On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust counters. This is mostly visible for transmits 1 byte long.

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-23 Thread Kevin Hilman
Troy Kisky troy.ki...@boundarydevices.com writes: On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-23 Thread Troy Kisky
On 9/23/2010 7:27 AM, Kevin Hilman wrote: Troy Kisky troy.ki...@boundarydevices.com writes: On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg()

RE: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-23 Thread Sudhakar Rajashekhara
On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust counters. This is mostly visible for transmits 1 byte long. The hardware starts sending immediately that MDR.STT

RE: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-22 Thread Sudhakar Rajashekhara
Hi, On Wed, Sep 22, 2010 at 05:39:16, Ben Dooks wrote: On Tue, Sep 21, 2010 at 12:17:58PM -0700, Troy Kisky wrote: On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR

RE: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-21 Thread Sudhakar Rajashekhara
Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust counters. This is mostly visible for transmits 1 byte long. The hardware starts sending immediately that

Re: [PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-21 Thread Troy Kisky
On 9/21/2010 4:24 AM, Sudhakar Rajashekhara wrote: Hi, On Tue, Sep 21, 2010 at 09:43:28, Jon Povey wrote: When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust counters. This is mostly visible for transmits 1 byte

[PATCH v4] i2c: davinci: Fix race when setting up for TX

2010-09-20 Thread Jon Povey
When setting up to transmit, a race exists between the ISR and i2c_davinci_xfer_msg() trying to load the first byte and adjust counters. This is mostly visible for transmits 1 byte long. The hardware starts sending immediately that MDR.STT is set. IMR trickery doesn't work because if we start