Re: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-11 Thread Prabhakar Lad
Hi Grygorii, Thanks for the review. On Fri, Nov 8, 2013 at 9:09 PM, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/08/2013 12:11 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com the devm_*() helper prints error messages in case of errors no need to do the

[PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-08 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/gpio/gpio-davinci.c |6 ++ 1 file changed, 2 insertions(+), 4

Re: [PATCH v5 1/7] gpio: davinci: remove unnecessary printk

2013-11-08 Thread Grygorii Strashko
On 11/08/2013 12:11 PM, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com the devm_*() helper prints error messages in case of errors no need to do the same in the driver. Pls, drop it - devm_clk_get() doesn't always print error messages Signed-off-by: Lad, Prabhakar