Re: [RFC 6/7] ARM: DaVinci: DM646x Video: Add VPIF driver

2009-03-14 Thread Hans Verkuil
Phew, the last review. First a comment on the vpif.h header (and the dm646x.h header as well, for that matter): no need to use #ifdef __KERNEL__. You are by definition inside the kernel and it isn't a public header either. I also think that these headers belong next to the driver and not in inclu

[RFC 6/7] ARM: DaVinci: DM646x Video: Add VPIF driver

2009-03-13 Thread chaithrika
From: Chaithrika U S Video Port Interface driver Add VPIF driver for DM646x. This code be used by the display and capture drivers. Signed-off-by: Chaithrika U S --- Applies to v4l-dvb repository located at http://linuxtv.org/hg/v4l-dvb/rev/1fd54a62abde drivers/media/video/davinci/vpif.c | 3