Re: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug

2012-07-01 Thread Prchal Jiří
Hi Gururaja, shouldn't be better to use: snd_soc_update_bits(codec, AIC3X_PLL_PROGA_REG, PLLP_MASK, pll_p); instead of read mask write ? Even at this place you don't need to keep rest of register (PLL_Q and PLL_enable), so yust writing is OK. snd_soc_write(codec, AIC3X_PLL_PROGA_REG, pll_p

Re: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug

2012-06-26 Thread Mark Brown
On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote: In sound/soc/codecs/tlv320aic3x.c data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG); snd_soc_write(codec, AIC3X_PLL_PROGA_REG, data | (pll_p PLLP_SHIFT)); In the above code, pll-p value

RE: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug

2012-06-26 Thread Hebbar, Gururaja
On Tue, Jun 26, 2012 at 14:24:03, Mark Brown wrote: On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote: In sound/soc/codecs/tlv320aic3x.c data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG); snd_soc_write(codec, AIC3X_PLL_PROGA_REG, data

RE: [PATCH V2] ASoC: tlv320aic3x: Fix codec pll configure bug

2012-06-26 Thread Hebbar, Gururaja
On Tue, Jun 26, 2012 at 14:31:42, Prchal Jiří wrote: Hi Gururaja, shouldn't be better to use: snd_soc_update_bits(codec, AIC3X_PLL_PROGA_REG, PLLP_MASK, pll_p); instead of read mask write ? Sure will resend the patch. Thanks for the review Even at this place you don't need to keep rest