Re: [PATCH v2] gpio: davinci: fix gpio selection for OF
On Tue, Mar 18, 2014 at 10:45 AM, Alexander Holler hol...@ahsoftware.de wrote: But I don't need any rush here, I'm just unable to understand why the -rc phase isn't used for bug fixing as I believe that's what this phase is for. Right now it is mostly a practical issue to me, as I applied the patch to the devel (for-next) branch, then committed new development on top of it. If I send it for fixes now the same patch will come in two ways as I really do not like to rebase my tree at this point. So I'd prefer to keep this for next and then have it tagged for stable as v3.14 is released, if that is OK? It's as simple as sending a mail to Greg once it's upstream. Yours, Linus Walleij ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v2] gpio: davinci: fix gpio selection for OF
Am 21.03.2014 09:28, schrieb Linus Walleij: On Tue, Mar 18, 2014 at 10:45 AM, Alexander Holler hol...@ahsoftware.de wrote: But I don't need any rush here, I'm just unable to understand why the -rc phase isn't used for bug fixing as I believe that's what this phase is for. Right now it is mostly a practical issue to me, as I applied the patch to the devel (for-next) branch, then committed new development on top of it. If I send it for fixes now the same patch will come in two ways as I really do not like to rebase my tree at this point. So I'd prefer to keep this for next and then have it tagged for stable as v3.14 is released, if that is OK? Sure. It's as simple as sending a mail to Greg once it's upstream. I already though about how to tag every patch I send as Cc: stable, because almost any fix I send either goes through some -next or even -next-next or already is for some stable kernel. (I usually don't even look at -rc kernels, just for some special things I'm waiting for, like this of-gpio for davinci.) Regards, Alexander Holler ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH v2 0/3] ata: ahci_platform related cleanups
Hi, On Thursday, March 20, 2014 08:19:27 PM Hans de Goede wrote: Hi, On 03/20/2014 07:27 PM, Bartlomiej Zolnierkiewicz wrote: [ v1 was named ata: add remaining new-style AHCI platform drivers but we are down from 2 drivers to 1 driver so the title of the patch series no longer was valid :) ] Hi, This patch series: - fixes ahci_platform_data-suspend() handling - moves library AHCI platform code to its own file - adds a new-style AHCI platform driver for DaVinci DA850 AHCI controller Changes since v1: - dropped no longer needed patch #4 (ST SPEAr1340 AHCI controller driver) - adressed review comments for patch #3 from Sekhar Nori - updated patch descriptions I assume that the spear patch has been dropped since the spear code has already been converted now and thus is no longer using ahci_platform_data ? Yes, the SPEAr platform AHCI code has been replaced by a proper PHY driver. In that case I think it would best to replace patch 1 with a patch just dropping the suspend and resume callbacks from ahci_platform_data, as they then no longer have any users. I have this on my TODO but since the SPEAr changes are not yet merged upstream this have to wait a bit. Best regards, -- Bartlomiej Zolnierkiewicz Samsung RD Institute Poland Samsung Electronics ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
Re: [PATCH 08/62] ARM: davinci: use explicit 'select' for DA850_EVM
On Thursday 20 March 2014, Sekhar Nori wrote: On Thursday 20 March 2014 12:59 AM, Arnd Bergmann wrote: The DAVINCI_DA850_EVM board uses an unusual method to enable the GPIO_PCA953X and KEYBOARD_GPIO_POLLED symbols, which leads to the dependencies on these symbols being ignored. As GPIO_PCA953X actually requires I2C, that can lead to build failures when I2C is disabled. This patch removes the duplicate symbol definitions I am okay with this.. and instead adds equivalent 'select' statements that are conditional on the underlying dependencies. .. but not sure this is needed. The PCA953X was defaulted to y mainly because the IO expander was used to detect presence of daughter cards. Even then, I don't think there is any need to force its selection. A different question whether we actually want to automatically enable them at all or rather put them into defconfig, but that should be a separate patch. It can be enabled through defconfig as you said. I agree that can be a separate patch. For now, just dropping the replicated Kconfig symbols should be okay. Ok, even better then. I was trying to change the behavior as little as possible, but not selecting the drivers is certainly the correct approach. I've put the two symbols into the defconfig now so the builds are unchanged. Arnd 8 From 5eaf7fdfe7c831d3aa24428a6e8d4509ac160db6 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date: Tue, 18 Feb 2014 12:23:19 +0100 Subject: [PATCH] ARM: davinci: use explicit 'select' for DA850_EVM The DAVINCI_DA850_EVM board uses an unusual method to enable the GPIO_PCA953X and KEYBOARD_GPIO_POLLED symbols, which leads to the dependencies on these symbols being ignored. As GPIO_PCA953X actually requires I2C, that can lead to build failures when I2C is disabled. This patch removes the duplicate symbol definitions and instead enables them from the davinci_all_defconfig file. A different question whether we actually want to automatically enable them at all or rather put them into defconfig, but that should be a separate patch. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Sekhar Nori nsek...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: davinci-linux-open-source@linux.davincidsp.com diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig index fff4eb6..16bdfab 100644 --- a/arch/arm/configs/davinci_all_defconfig +++ b/arch/arm/configs/davinci_all_defconfig @@ -218,3 +218,5 @@ CONFIG_DEBUG_ERRORS=y # CONFIG_CRYPTO_ANSI_CPRNG is not set # CONFIG_CRYPTO_HW is not set CONFIG_CRC_T10DIF=m +CONFIG_GPIO_PCA953X=y +CONFIG_KEYBOARD_GPIO_POLLED=y diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index 3b98e34..db18ef8 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -209,11 +209,6 @@ config DA850_WL12XX Say Y if you want to use a wl1271 expansion card connected to the AM18x EVM. -config GPIO_PCA953X - default MACH_DAVINCI_DA850_EVM - -config KEYBOARD_GPIO_POLLED - default MACH_DAVINCI_DA850_EVM config MACH_MITYOMAPL138 bool Critical Link MityDSP-L138/MityARM-1808 SoM ___ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
