Hi Prabhakar Lad,
On 11/02/2013 05:39 PM, Lad, Prabhakar wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch converts the davinci gpio driver to use irqdomain
support.
This patch needs to be splitted in two:
1) add IRQ domain support
2) remove intc_irq_num
Signed-off-by:
On 11/05/2013 10:53 AM, Prabhakar Lad wrote: Hi Grygorii,
Thanks for the review.
On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko
grygorii.stras...@ti.com wrote:
Hi Prabhakar Lad,
On 11/02/2013 05:39 PM, Lad, Prabhakar wrote:
From: KV Sujith sujit...@ti.com
This patch adds
Hi Sekhar, Linus,
On 11/06/2013 12:49 PM, Sekhar Nori wrote:
On Wednesday 06 November 2013 03:45 PM, Prabhakar Lad wrote:
Hi Linus,
On Wed, Nov 6, 2013 at 3:26 PM, Linus Walleij linus.wall...@linaro.org wrote:
On Wed, Nov 6, 2013 at 10:33 AM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
On 11/06/2013 12:08 PM, Prabhakar Lad wrote:
Hi Grygorii,
On Tue, Nov 5, 2013 at 10:29 PM, Grygorii Strashko
grygorii.stras...@ti.com wrote:
On 11/05/2013 10:53 AM, Prabhakar Lad wrote: Hi Grygorii,
Thanks for the review.
On Mon, Nov 4, 2013 at 11:58 PM, Grygorii Strashko
grygorii.stras
On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
the devm_*() helper prints error messages in case of
errors no need to do the same in the driver.
Pls, drop it - devm_clk_get() doesn't always print error messages
Signed-off-by: Lad, Prabhakar
On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
From: KV Sujith sujit...@ti.com
This patch adds OF parser support for davinci gpio
driver and also appropriate documentation in gpio-davinci.txt
located at Documentation/devicetree/bindings/gpio/.
Signed-off-by: KV Sujith sujit...@ti.com
On 11/11/2013 05:37 PM, Prabhakar Lad wrote:
Hi Grygorii,
Thanks for the review.
On Mon, Nov 11, 2013 at 8:48 PM, Grygorii Strashko
grygorii.stras...@ti.com wrote:
On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
[Snip]
@@ -134,6 +137,40 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned
Hi Sekhar, Prabhakar Lad
On 11/08/2013 08:45 AM, Prabhakar Lad wrote: From: Lad, Prabhakar
prabhakar.cse...@gmail.com
This patch series fixes gpio driver regestration
and offset check for unbanked gpio.
Lad, Prabhakar (2):
gpio: davinci: Fix a check for unbanked gpio
ARM: davinci:
Hi Prabhakar Lad,
On 11/08/2013 12:11 PM, Prabhakar Lad wrote:
From: KV Sujith sujit...@ti.com
This patch series does the following
1 Ports the driver to use irqdomain.
2 Adds dt binding support for gpio-davinci.
3 Adds DA850 dt support goio.
Changes for v5:
1: Fixed review comments pointed
Hi Sekhar,
On 11/12/2013 08:18 AM, Sekhar Nori wrote:
On Monday 11 November 2013 09:13 PM, Grygorii Strashko wrote:
Hi Sekhar, Prabhakar Lad
On 11/08/2013 08:45 AM, Prabhakar Lad wrote: From: Lad, Prabhakar
prabhakar.cse...@gmail.com
This patch series fixes gpio driver regestration
Hi Linus,
On 11/18/2013 03:11 PM, Linus Walleij wrote:
On Fri, Nov 8, 2013 at 11:11 AM, Prabhakar Lad
prabhakar.cse...@gmail.com wrote:
From: Lad, Prabhakar prabhakar.cse...@gmail.com
This patch converts the davinci gpio driver to use irqdomain
support.
Signed-off-by: Lad, Prabhakar
On 11/25/2013 01:00 PM, Sekhar Nori wrote:
On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote:
From: KV Sujith sujit...@ti.com
This patch adds OF parser support for davinci gpio
driver and also appropriate documentation in gpio-davinci.txt
located at
on:
git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git
branch: keystone/master
This series has been marked as RFC because it's based on an unfinished
series of patches [2], but with hope that it will help to reach final decisions
and satisfy all interested parties.
Grygorii
value for ARCH_NR_GPIOS=256 and maximum number of
supported GPIOs for Davinci is DAVINCI_N_GPIO=144.
More over, this is one of steps to re-use Davinci GPIO driver by other
mach/platform.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/gpio/gpio-davinci.c |4 ++--
1 file
The Keystone GPIO functionality is ready for use, so LED support can be
enabled in config.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
arch/arm/configs/keystone_defconfig |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/configs/keystone_defconfig
b/arch
The similar GPIO HW block is used by keystone SoCs as
in Davinci SoCs.
Hence, reuse Davinci GPIO driver for Keystone.
Documentation:
http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/gpio/gpio-davinci.txt
This patch adds Keystone GPIO IP device definitions in DT which supports
up to 32 GPIO lines and each GPIO line can be configured as separate
interrupt source (so called unbanked IRQ).
For more information see:
http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf
Signed-off-by: Grygorii Strashko
Enable enable GPIO support for Keystone by setting CONFIG_GPIOLIB and
CONFIG_GPIO_DAVINCI options in keystone_defconfig.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
arch/arm/configs/keystone_defconfig |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/configs
/K2H_K2EVM-HK_SCH_A102_Rev1_0.pdf
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
arch/arm/boot/dts/k2hk-evm.dts | 23 +++
1 file changed, 23 insertions(+)
diff --git a/arch/arm/boot/dts/k2hk-evm.dts b/arch/arm/boot/dts/k2hk-evm.dts
index 15b3a95..07bf1e9 100644
On 11/26/2013 07:12 PM, Sekhar Nori wrote:
On Tuesday 26 November 2013 06:03 PM, Grygorii Strashko wrote:
On 11/25/2013 01:00 PM, Sekhar Nori wrote:
On Thursday 21 November 2013 11:45 PM, Prabhakar Lad wrote:
From: KV Sujith sujit...@ti.com
This patch adds OF parser support for davinci gpio
Hi All,
On 11/29/2013 10:37 AM, Linus Walleij wrote:
On Tue, Nov 26, 2013 at 8:40 PM, Grygorii Strashko
grygorii.stras...@ti.com wrote:
[1] Depends on patch:
[PATCH 1/2] gpio: davinci: Fix a check for unbanked gpio
https://lkml.org/lkml/2013/11/8/22
[2] and depends on series from Prabhakar
|writel}_relaxed() instead of __raw_*
CC: Linus Walleij linus.wall...@linaro.org
CC: Sekhar Nori nsek...@ti.com
CC: Santosh Shilimkar santosh.shilim...@ti.com
Grygorii Strashko (2):
gpio: davinci: don't create irq_domain in case of unbanked irqs
gpio: davinci: reuse for Keystone SoC
: Linus Walleij linus.wall...@linaro.org
CC: Sekhar Nori nsek...@ti.com
CC: Santosh Shilimkar santosh.shilim...@ti.com
CC: devicet...@vger.kernel.org
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/gpio/gpio-davinci.txt |4 +-
drivers/gpio/gpio-davinci.c
linus.wall...@linaro.org
CC: Sekhar Nori nsek...@ti.com
CC: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/gpio/gpio-davinci.c | 34 +++---
1 file changed, 19 insertions(+), 15 deletions(-)
diff --git
On 12/15/2013 03:54 PM, Sekhar Nori wrote:
On Sunday 15 December 2013 07:20 PM, Sekhar Nori wrote:
On Sunday 15 December 2013 12:41 AM, Santosh Shilimkar wrote:
Linus, Sekhar,
On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote:
This series is intended to update Davinci GPIO
On 12/16/2013 09:29 AM, Alexandre Courbot wrote:
On Fri, Dec 13, 2013 at 3:12 AM, Grygorii Strashko
grygorii.stras...@ti.com wrote:
The similar GPIO HW block is used by keystone SoCs as
in Davinci SoCs.
Hence, reuse Davinci GPIO driver for Keystone taking into
account that Keystone contains ARM
On 12/16/2013 06:38 PM, Santosh Shilimkar wrote:
On Thursday 12 December 2013 01:12 PM, Grygorii Strashko wrote:
The similar GPIO HW block is used by keystone SoCs as
in Davinci SoCs.
Hence, reuse Davinci GPIO driver for Keystone taking into
account that Keystone contains ARM GIC IRQ controller
: Sekhar Nori nsek...@ti.com
Cc: Santosh Shilimkar santosh.shilim...@ti.com
Grygorii Strashko (2):
gpio: davinci: don't create irq_domain in case of unbanked irqs
gpio: davinci: reuse for Keystone SoC
.../devicetree/bindings/gpio/gpio-davinci.txt |4 +-
drivers/gpio/gpio-davinci.c
: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Sekhar Nori nsek...@ti.com
Cc: devicet...@vger.kernel.org
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/gpio/gpio-davinci.txt
linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Sekhar Nori nsek...@ti.com
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/gpio/gpio-davinci.c | 34 +++---
1 file changed, 19
On 12/22/2013 05:52 PM, Sekhar Nori wrote:
On Wednesday 18 December 2013 03:37 PM, Grygorii Strashko wrote:
The system may crash if:
- there are more then 1 bank
s/then/than
- unbanked irqs are enabled
- someone will call gpio_to_irq() for GPIO from bank2 or above
Hence, fix
On 12/22/2013 05:41 PM, Sekhar Nori wrote:
On Wednesday 18 December 2013 03:37 PM, Grygorii Strashko wrote:
The similar GPIO HW block is used by keystone SoCs as
in Davinci SoCs.
Hence, reuse Davinci GPIO driver for Keystone taking into
account that Keystone contains ARM GIC IRQ controller
: Alexandre Courbot gnu...@gmail.com
Cc: Sekhar Nori nsek...@ti.com
Cc: devicet...@vger.kernel.org
Acked-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/gpio/gpio
Hi Rob,
On 12/24/2013 01:41 PM, Grygorii Strashko wrote:
The similar GPIO HW block is used by keystone SoCs as
in Davinci SoCs.
Hence, reuse Davinci GPIO driver for Keystone taking into
account that Keystone contains ARM GIC IRQ controller which
is implemented using IRQ Chip.
Documentation
Hi Linus, Sekhar,
On 01/15/2014 09:21 AM, Linus Walleij wrote:
On Thu, Jan 9, 2014 at 6:28 AM, Dan Carpenter dan.carpen...@oracle.com
wrote:
irq needs to be signed for the error handling to work.
Fixes: 6075a8b2b6c3 ('gpio: davinci: don't create irq_domain in case of
unbanked irqs')
-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Changes in v4:
- rebased on top of v3.14 +
[patch] gpio: davinci: signedness bug in davinci_gpio_irq_setup()
.../devicetree/bindings/gpio
-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
- rebased on top of
git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git
branch: devel
top commit: ef70bbe gpio: make
successfully on a da850 board using entries for gpio-leds in a DT. So I didn't
reinvent the wheel but just copied and tested stuff.
Thanks to Grygorii Strashko for the hint of the existing code in gpio-pxa.
Signed-off-by: Alexander Holler hol...@ahsoftware.de
---
drivers/gpio/gpio-davinci.c | 27
and tested my changes
successfully on a da850 board using entries for gpio-leds in a DT. So I didn't
reinvent the wheel but just copied and tested stuff.
Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa.
Signed-off-by: Alexander Holler hol...@ahsoftware.de
Signed-off-by: Grygorii
entries for gpio-leds in a DT. So I
didn't
reinvent the wheel but just copied and tested stuff.
Thanks to Grygorii Strashko for the hint to the existing code in gpio-pxa.
Signed-off-by: Alexander Holler hol...@ahsoftware.de
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
This v2
Introduce a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus leading to simplified MDIO drivers code.
Update Davinci MDIO driver ss example of new devm APIs usage.
Grygorii Strashko (2):
mdio_bus: implement
Use devm_* API for memory allocation and to get device's clock
to simplify driver's code.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/drivers/net
Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus leading to simplified MDIO drivers code.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Documentation/driver-model/devres.txt |4 ++
drivers
On 04/04/2014 04:15 PM, Sergei Shtylyov wrote:
Hello.
On 04-04-2014 17:40, Grygorii Strashko wrote:
Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus leading to simplified MDIO drivers code.
Signed-off
Hi Florian,
On 04/11/2014 07:55 AM, Florian Fainelli wrote:
Hi Grygorii,
2014-04-04 6:40 GMT-07:00 Grygorii Strashko grygorii.stras...@ti.com:
Introduce a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus
- additional patches added for cleaning up Davinci MDIO driver
Cc: Florian Fainelli f.faine...@gmail.com
Grygorii Strashko (4):
mdio_bus: implement devm_mdiobus_alloc/devm_mdiobus_free
net: davinci_mdio: use devm_* api
net: davinci_mdio: drop pinctrl_pm_select_default_state from probe
net
Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus leading to simplified MDIO drivers code.
Cc: Florian Fainelli f.faine...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Documentation
Use devm_* API for memory allocation and to get device's clock
to simplify driver's code.
Cc: Florian Fainelli f.faine...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 24 +---
1 file changed, 5 insertions
Simplify IO memory mapping by using devm_ioremap_resource()
which will do all errors handling and reporting for us.
Cc: Florian Fainelli f.faine...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 21 +++--
1 file
The default pinctrl state is set by Drivers core now before
calling the driver's probe.
Hence, it's safe to drop pinctrl_pm_select_default_state() call
from Davinci mdio driver probe.
Cc: Florian Fainelli f.faine...@gmail.com
Cs: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Grygorii
Use devm_* API for memory allocation and to get device's clock
to simplify driver's code.
Cc: Florian Fainelli f.faine...@gmail.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
Acked-and-tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras
() and
devm_mdiobus_alloc() converted to be just a simple wrapper now.
Changes in v2:
- minor comments taken into account
- additional patches added for cleaning up Davinci MDIO driver
Cc: Florian Fainelli f.faine...@gmail.com
Grygorii Strashko (4):
mdio_bus: implement devm_mdiobus_alloc
-and-tested-by: Lad, Prabhakar prabhakar.cse...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Documentation/driver-model/devres.txt |5 +++
drivers/net/phy/mdio_bus.c| 67 +
include/linux/phy.h |7
3 files
, Prabhakar prabhakar.cse...@gmail.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers/net/ethernet/ti/davinci_mdio.c
index 4b202a2..4757198
On 04/18/2014 08:52 PM, Sergei Shtylyov wrote:
On 04/18/2014 09:24 PM, Grygorii Strashko wrote:
Add a resource managed devm_mdiobus_alloc()/devm_mdiobus_free()
to automatically clean up MDIO bus alocations made by MDIO drivers,
thus leading to simplified MDIO drivers code.
Cc: Florian
driver for Keystone 2 and
enable TI networking for Keystone 2 devices.
Also, as part of this series, enable PHY's creation from DT, because
Keystone 2 supports DT boot mode only.
Grygorii Strashko (2):
net: davinci_mdio: reuse for keystone2 arch
net: davinci_mdio: allow to create phys from dt
driver for Keystone 2 and
enable TI networking for Keystone 2 devices
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/net/davinci-mdio.txt |8
drivers/net/ethernet/ti/Kconfig|4 ++--
2 files changed, 6 insertions(+), 6
().
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/net/ethernet/ti/davinci_mdio.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/ti/davinci_mdio.c
b/drivers/net/ethernet/ti/davinci_mdio.c
index 735dc53..22d3dab 100644
Hi David,
On 07/10/2014 02:52 AM, David Miller wrote:
From: Grygorii Strashko grygorii.stras...@ti.com
Date: Wed, 9 Jul 2014 16:10:50 +0300
Required properties:
-- compatible: Should be ti,davinci_mdio
+- compatible: Should be ti,davinci_mdio or
ti
On 07/10/2014 10:39 PM, David Miller wrote:
From: Grygorii Strashko grygorii.stras...@ti.com
Date: Thu, 10 Jul 2014 15:58:31 +0300
Hi David,
On 07/10/2014 02:52 AM, David Miller wrote:
From: Grygorii Strashko grygorii.stras...@ti.com
Date: Wed, 9 Jul 2014 16:10:50 +0300
Required
driver for Keystone 2 and
enable TI networking for Keystone 2 devices.
Also, as part of this series, enable PHY's creation from DT, because
Keystone 2 supports DT boot mode only.
Changes in v2:
- review comments applied.
Keystone 2 compatibility string changed to ti,keystone_mdio.
Grygorii Strashko
driver for Keystone 2 and
enable TI networking for Keystone 2 devices
Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/net/davinci-mdio.txt |8
().
Reviewed-by: Santosh Shilimkar santosh.shilim...@ti.com
Acked-by: Mugunthan V N mugunthan...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Hi Santosh,
I haven't changed style for long-comments, because Networking subsystem
requires first line of comment not to be empty
Hi Jon,
On 07/29/2014 06:53 PM, Jon Cormier wrote:
A slimmer patch suggested by Grygorii Strashko grygorii.stras...@ti.com
Ok. The problem seems to be deeper than at first look.
You have sequence (in Mainline kernel):
cpufreq:
|- notify CPUFREQ_PRECHANGE
|- i2c-davinci will lock put I2C
On 07/30/2014 09:18 AM, Sekhar Nori wrote:
On Tuesday 29 July 2014 11:00 PM, Grygorii Strashko wrote:
Hi Jon,
On 07/29/2014 06:53 PM, Jon Cormier wrote:
A slimmer patch suggested by Grygorii Strashko grygorii.stras...@ti.com
Ok. The problem seems to be deeper than at first look.
You have
Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/spi/spi-davinci.txt|9 ++-
drivers/spi/spi-davinci.c | 64 +---
2 files changed, 64 insertions(+), 9 deletions(-)
diff --git
to use cs_gpio field
of SPI device structure (spi_device) for both DT and non-DT cases.
v1:
http://www.spinics.net/lists/linux-spi/msg01446.html
Grygorii Strashko (1):
spi: davinci: use spi_device.cs_gpio to store gpio cs per spi device
Murali Karicheri (1):
spi: davinci: add support
Rework Davinci SPI driver to store GPIO CS number in cs_gpio field
of SPI device structure (spi_device) for both DT and non-DT cases.
This will make Davinci SPI driver code simpler and allows to reuse
more SPI core functionality.
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
On 08/01/2014 08:26 PM, Mark Brown wrote:
On Fri, Aug 01, 2014 at 07:40:32PM +0300, Grygorii Strashko wrote:
From: Murali Karicheri m-kariche...@ti.com
Currently driver supports only configuration of GPIO CS through
platform data. This patch enhances the driver to configure GPIO
CS through DT
On 08/01/2014 08:35 PM, Mark Brown wrote:
On Fri, Aug 01, 2014 at 07:40:32PM +0300, Grygorii Strashko wrote:
From: Murali Karicheri m-kariche...@ti.com
Currently driver supports only configuration of GPIO CS through
platform data. This patch enhances the driver to configure GPIO
CS through
The driver should not touch CS lines if SPI_NO_CS flag is set.
This patch fixes it as this functionality was broken accidentally
by
commit a88e34ea213e1b (spi: davinci: add support to configure gpio cs through
dt).
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/spi/spi
properties for SPI slave
devices which were possible to configure only from platform code
through struct davinci_spi_config
Grygorii Strashko (2):
spi: davinci: fix SPI_NO_CS functionality
spi: davinci: support adding delay between transmission
.../devicetree/bindings/spi/spi-davinci.txt
: t2c delay
- ti,davinci-spi-t2e-delay: t2e delay
- ti,davinci-spi-c2e-delay: c2e delay
Signed-off-by: Murali Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
.../devicetree/bindings/spi/spi-davinci.txt| 18 +
drivers/spi/spi-davinci.c
Hi Mark,
On 08/21/2014 09:20 PM, Mark Brown wrote:
On Thu, Aug 21, 2014 at 06:25:06PM +0300, Grygorii Strashko wrote:
+- ti,davinci-spi-wdelay : delay between transmissions.
I don't understand why this is here - there is already standard support
in the SPI core for client drivers
Hi Mark,
I'm very sorry for delayed replay.
On 08/22/2014 06:06 PM, Mark Brown wrote:
On Fri, Aug 22, 2014 at 04:33:09PM +0300, Grygorii Strashko wrote:
On 08/21/2014 09:20 PM, Mark Brown wrote:
On Thu, Aug 21, 2014 at 06:25:06PM +0300, Grygorii Strashko wrote:
+- ti,davinci-spi-wdelay
Hi Mark,
On 09/06/2014 05:31 PM, Mark Brown wrote:
On Fri, Sep 05, 2014 at 05:21:56PM +0300, Grygorii Strashko wrote:
I think we have some misunderstanding here :(
1) All new properties a optional and should be specified for SPI Slave
devices
2) Seems we are talking using different terms
then delay
between transmission of words will be added as following:
wdelay = T2CDELAY + WDELAY + C2TDELAY.
If ti,spi-disable-cstimer is configured:
wdelay = WDELAY.
Signed-off-by: Murali Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Changes
Hi Mark,
On 09/09/2014 10:58 PM, Mark Brown wrote:
On Tue, Sep 09, 2014 at 02:20:27PM -0400, Murali Karicheri wrote:
On 09/09/2014 01:20 PM, Mark Brown wrote:
If these delays are not related to chip select then the documentation
needs to be fixed to not refer to chip select.
Ok. So what
() will fail and return -EBUSY.
Hence, fix it by moving CS GPIOs requesting code in .probe().
Reported-by: Murali Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Tested using spidev_test utility.
drivers/spi/spi-davinci.c | 34
.WDEL)
Signed-off-by: Murali Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Changes in v3:
- removed C2TDELAY, T2CDELAY parameters
v2:
http://www.spinics.net/lists/devicetree/msg48514.html
v1:
http://www.spinics.net/lists/linux-spi/msg01609.html
On 09/13/2014 07:06 PM, Mark Brown wrote:
On Fri, Sep 12, 2014 at 06:48:12PM +0300, Grygorii Strashko wrote:
From: Murali Karicheri m-kariche...@ti.com
This patch adds ability to configure delay between transmission of
words over SPI bus if it's required by SPI slave devices.
This is fine
On 09/13/2014 07:28 PM, Mark Brown wrote:
On Fri, Sep 12, 2014 at 05:54:00PM +0300, Grygorii Strashko wrote:
static void davinci_spi_cleanup(struct spi_device *spi)
{
-if (spi-cs_gpio = 0)
-gpio_free(spi-cs_gpio);
}
This function is now empty so should be removed
Remove empty function davinci_spi_cleanup().
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
drivers/spi/spi-davinci.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/spi/spi-davinci.c b/drivers/spi/spi-davinci.c
index d493507..134fb6e 100644
--- a/drivers/spi/spi
)
Signed-off-by: Murali Karicheri m-kariche...@ti.com
Signed-off-by: Grygorii Strashko grygorii.stras...@ti.com
---
Rebased on top of:
spi.git/for-next +
[PATCH] spi: davinci: remove empty function davinci_spi_cleanup
http://www.spinics.net/lists/arm-kernel/msg362811.html
v3:
http
84 matches
Mail list logo
