On Sun, Aug 11, 2013 at 11:25 PM, Sekhar Nori nsek...@ti.com wrote:
On 8/8/2013 5:19 PM, Sekhar Nori wrote:
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
We certainly don't want error conditions to be cleared any other
place but the EDMA error handler, as this will make us 'forget
On 08/12/2013 08:31 AM, Mark Brown wrote:
On Mon, Aug 12, 2013 at 11:26:49AM +0530, Sekhar Nori wrote:
No need for a separate patch for this, just do this in the patch where
you include the two linked sets.
Can you guys please think about the CC lists you're using for these
patch
Dropped quite a few from the CC list...
On 08/12/2013 02:15 AM, Sekhar Nori wrote:
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
Changes are made here for configuring existing parameters to support
DMA'ing them out in batches as needed.
Also allocate as many as slots as needed
Responding to other comments in this post,
On 08/12/2013 02:15 AM, Sekhar Nori wrote:
[..]
if (unlikely(!echan || !sgl || !sg_len))
return NULL;
@@ -262,8 +262,11 @@ static struct dma_async_tx_descriptor
*edma_prep_slave_sg(
edesc-pset_nr = sg_len;
-
On 08/12/2013 06:55 PM, Joel Fernandes wrote:
Dropped quite a few from the CC list...
On 08/12/2013 02:15 AM, Sekhar Nori wrote:
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
Changes are made here for configuring existing parameters to support
DMA'ing them out in batches
On 08/12/2013 01:56 PM, Sekhar Nori wrote:
On Monday 05 August 2013 04:14 PM, Joel Fernandes wrote:
Here we implement splitting up of the total MAX number of slots
available for a channel into 2 cyclically linked sets. Transfer
completion Interrupts are enabled on both linked sets
On 08/12/2013 12:52 AM, Sekhar Nori wrote:
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
Previously, such a dump function was used but it wasn't reading
from the PaRAM, rather just from a edmacc_param structure, we
add a helpful function for debugging that directly reads from
On 08/12/2013 12:56 AM, Sekhar Nori wrote:
On Monday 05 August 2013 09:44 PM, Joel Fernandes wrote:
We'd now need a separate slot just for the channel and separate
ones for the 2 linked sets, so we make adjustments to allocate
an extra channel accordingly.
Signed-off-by: Joel Fernandes jo
be detected as
error conditions.
This should architecturally be the final version of the patch series to
add DMA support for SG lists of any length.
Thanks,
-Joel
On 08/05/2013 11:14 AM, Joel Fernandes wrote:
Here is a more improved approach for DMA support of SG lists of any length
in the EDMA
Antoniou pa...@antoniou-consulting.com
Signed-off-by: Joel Fernandes jo...@ti.com
---
Note:
Patch should go in for -rc cycle as it fixes existing crypto drivers.
arch/arm/common/edma.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/arch/arm/common/edma.c b
On 08/26/2013 05:46 AM, Sekhar Nori wrote:
On Saturday 24 August 2013 01:23 AM, Joel Fernandes wrote:
HWMOD removal for MMC and Crypto is breaking edma_start as the events are
being manually triggered due to unused channel list not being clear. Atleast
breakage has been seen
the of_* helpers to parse the arguments in the dmas phandle list.
Reviewed-by: Sekhar Nori nsek...@ti.com
Reported-by: Balaji T K balaj...@ti.com
Cc: Pantel Antoniou pa...@antoniou-consulting.com
Signed-off-by: Joel Fernandes jo...@ti.com
---
Changes since v1, in v2 and v3:
- Reduced indentation of non
Manual trigger for events missed as a result of splitting a
scatter gather list and DMA'ing it in batches. Add a helper
function to trigger a channel incase any such events are missed.
Signed-off-by: Joel Fernandes jo...@ti.com
---
arch/arm/common/edma.c | 17
-omapm=137416733628831w=2
Joel Fernandes (6):
dma: edma: Setup parameters to DMA MAX_NR_SG at a time
dma: edma: Write out and handle MAX_NR_SG at a given time
ARM: edma: Add function to manually trigger an EDMA channel
dma: edma: Find missed events and issue them
dma: edma: Leave linked
, still only
10 slots will be allocated to DMA the entire SG list of size 40.
Also enable TC interrupts for slots that are a last in a current
iteration, or that fall on a MAX_NR_SG boundary.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 18 +++---
1 file changed
-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 79 --
1 file changed, 53 insertions(+), 26 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index e522ad5..732829b 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
an error condition and detect the channel that
missed it.
Signed-off-by: Joel Fernandes jo...@ti.com
dma: edma: Link to dummy slot only for last SG list split
Consider the case where we have a scatter-list like:
SG1-SG2-SG3-SG4-SG5-SG6-Null
For ex, for a MAX_NR_SG of 2, earlier we were splitting
With this series, this check is no longer required and
we shouldn't need to reject drivers DMA'ing more than the
MAX number of slots.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
and allow the manual triggerring to happen
in edma_execute which will be eventually called. This fixes the above
mentioned race conditions seen with the crypto drivers.
[1] http://marc.info/?l=linux-omapm=137416733628831w=2
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 50
On 09/02/2013 11:08 PM, Vinod Koul wrote:
On Thu, Aug 29, 2013 at 06:05:41PM -0500, Joel Fernandes wrote:
Process SG-elements in batches of MAX_NR_SG if they are greater
than MAX_NR_SG. Due to this, at any given time only those many
slots will be used in the given channel no matter how long
On 09/06/2013 02:15 PM, Mark Jackson wrote:
On 06/09/13 20:13, Mark Jackson wrote:
On 23/08/13 20:53, Joel Fernandes wrote:
HWMOD removal for MMC and Crypto is breaking edma_start as the events are
being manually triggered due to unused channel list not being clear. Atleast
breakage has been
the of_* helpers to parse the arguments in the dmas phandle list.
Reviewed-by: Sekhar Nori nsek...@ti.com
Reported-by: Balaji T K balaj...@ti.com
Cc: Pantel Antoniou pa...@antoniou-consulting.com
Signed-off-by: Joel Fernandes jo...@ti.com
---
This patch is a repost of v2 with minor change of return
On 09/12/2013 04:58 AM, Sekhar Nori wrote:
On Wednesday 11 September 2013 12:22 AM, Joel Fernandes wrote:
HWMOD removal for MMC is breaking edma_start as the events are being manually
triggered due to unused channel list not being clear.
[..]
It is better to send one version with all comments
On 09/16/2013 06:48 AM, Sekhar Nori wrote:
Hi Joel,
On Saturday 14 September 2013 06:27 AM, Joel Fernandes wrote:
From: Joel Fernandes jo...@ti.com
Subject: [PATCH v4] ARM: EDMA: Fix clearing of unused list for DT DMA
resources
HWMOD removal for MMC is breaking edma_start as the events
On 09/17/2013 12:08 AM, Sekhar Nori wrote:
[..]
I still cannot find any users of edma in the device tree sources either
in linux-next or linus/master. Why cannot this wait until v3.13?
I understand this affects only DT users of EDMA. But I get so many private
reports of breakage due to this
binding
updates. Following this suggestion, I've update the patch to the below:
---8---
From: Joel Fernandes jo...@ti.com
Subject: [PATCH v6] ARM: EDMA: Fix clearing of unused list for DT DMA resources
HWMOD removal for MMC is breaking edma_start as the events are being manually
triggered due
to
all DMA types must be set separately such as setting of interrupts.
This function takes care of the most-common attributes.
Also added comments clarifying A-sync case calculations.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 198
a comment clarifying this.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 9b63e1e..407b496 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -46,8
the driver can allocate for a particular descriptor
and error out on such cases.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 159 ++---
1 file changed, 151 insertions(+), 8 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma
dma/cyclic)
Joel Fernandes (3):
dma: edma: Split out PaRAM set calculations into its own function
dma: edma: Add support for Cyclic DMA
dma: edma: Increase maximum SG limit to 20
drivers/dma/edma.c | 350 +
1 file changed, 273 insertions
Lindgren t...@atomide.com
Cc: Olof Johansson o...@lixom.net
Cc: Nishanth Menon n...@ti.com
Cc: Pantel Antoniou pa...@antoniou-consulting.com
Cc: Jason Kridner jkrid...@beagleboard.org
Cc: Koen Kooi k...@dominion.thruhere.net
Signed-off-by: Joel Fernandes jo...@ti.com
---
Just resending this patch
On 09/26/2013 06:13 PM, Olof Johansson wrote:
On Thu, Sep 26, 2013 at 2:55 PM, Joel Fernandes jo...@ti.com wrote:
HWMOD removal for MMC is breaking edma_start as the events are being manually
triggered due to unused channel list not being clear.
The above issue is fixed by reading the dmas
On 09/27/2013 02:49 AM, Sekhar Nori wrote:
On 9/27/2013 5:58 AM, Joel Fernandes wrote:
On 09/26/2013 06:13 PM, Olof Johansson wrote:
On Thu, Sep 26, 2013 at 2:55 PM, Joel Fernandes jo...@ti.com wrote:
HWMOD removal for MMC is breaking edma_start as the events are being
manually
triggered
On 09/27/2013 04:04 AM, Sekhar Nori wrote:
On 9/27/2013 5:58 AM, Joel Fernandes wrote:
On 09/26/2013 06:13 PM, Olof Johansson wrote:
On Thu, Sep 26, 2013 at 2:55 PM, Joel Fernandes jo...@ti.com wrote:
HWMOD removal for MMC is breaking edma_start as the events are being
manually
triggered
On 10/31/2013 09:10 AM, Vinod Koul wrote:
On Thu, Oct 24, 2013 at 12:57:02PM -0500, Joel Fernandes wrote:
Rebased on slave-dma/next branch and reapplied:
Looks like your MUA caused lines to get wrapped and patch is corrupt, can you
pls resend again using git-send email. I tried even the patch
to function on DA850 EVM
with DMA. The behaviour is triggered by specific IP and
this can explain why the issue was not reported before
(example with MMC/SD on AM335x).
Tested on DA850 EVM and AM335x EVM-SK using MMC/SD card.
Cc: sta...@vger.kernel.org # v3.12.x+
Cc: Joel Fernandes jo...@ti.com
in Queue 1, and change QUEPRI to make Queue 1 as
higher priority.
This is fine,
Acked-by: Joel Fernandes jo...@ti.com
Regards,
-Joel
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
To improve latency with cyclic DMA operation it is preferred to
use different eventq/tc than the default which is used by all
other drivers (mmc, spi, i2c, etc).
When preparing the cyclic dma ask for non default queue for the
channel which is
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
check for the direction has been already done in the function calling
edma_config_pset().
The error reporting is redundant and also the else if () can be removed.
NAK.
Hi Peter,
Other than patches 8/14 and 10/14 which I responded to, you could add my
Acked-by, or add it to the series itself once you make the changes and
drop 10.
Acked-by: Joel Fernandes jo...@ti.com
Thanks,
-Joel
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
Hi,
This is basically
On 04/11/2014 01:39 AM, Peter Ujfalusi wrote:
On 04/11/2014 01:40 AM, Joel Fernandes wrote:
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
check for the direction has been already done in the function calling
On 04/11/2014 11:43 AM, Vinod Koul wrote:
On Tue, Apr 01, 2014 at 04:06:04PM +0300, Peter Ujfalusi wrote:
Pause/Resume can be used by the audio stack when the stream is paused/resumed
The edma platform code has support for this and the legacy audio stack used
this.
Signed-off-by: Peter
On 04/11/2014 11:47 AM, Vinod Koul wrote:
On Thu, Apr 10, 2014 at 11:36:30AM -0500, Joel Fernandes wrote:
On 04/01/2014 08:06 AM, Peter Ujfalusi wrote:
To improve latency with cyclic DMA operation it is preferred to
use different eventq/tc than the default which is used by all
other drivers
On 04/16/2014 07:59 AM, Peter Ujfalusi wrote:
[..]
If the dma-priority is missing we should assume lowest priority (0).
The highest priority depends on the platform. For eDMA3 in AM335x it is
three
level. For designware controller you might have the range 0-8 as valid.
The question is how
changed, 83 insertions(+), 26 deletions(-)
I reviewed and tested all the patches in the new series to make sure it
doesn't break anything with non-cyclic users (MMC and Crypto).
Reviewed-and-Tested-by: Joel Fernandes jo...@ti.com
regards,
-Joel
The vchan lock in edma_callback is acquired in hard interrupt context. As
interrupts are already disabled, there's no point in save/restoring interrupt
mask bit or cpsr flags.
Get rid of flags local variable and use spin_lock instead of spin_lock_irqsave.
Signed-off-by: Joel Fernandes jo
: Dan Williams dan.j.willi...@intel.com
Cc: Russell King rmk+ker...@arm.linux.org.uk
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/virt-dma.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/virt-dma.c b/drivers/dma/virt-dma.c
index 6f80432
On 04/18/2014 03:50 AM, Russell King - ARM Linux wrote:
On Thu, Apr 17, 2014 at 07:56:50PM -0500, Joel Fernandes wrote:
Free the vd (virt descriptor) after the callback is called. In EDMA driver
atleast which uses virt-dma, we make use of the desc during the callback and
if
its dangerously
We add DMA memcpy support to EDMA driver. Successful tests performed using
dmatest kernel module. Copy alignment is set to DMA_SLAVE_BUSWIDTH_4_BYTES and
users must ensure length is aligned so that copy is performed fully.
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c | 51
Hi Vinod, Dan,
On 04/14/2014 06:41 AM, Peter Ujfalusi wrote:
Hi,
Changes since v2:
- Dropped patch 10 from v2 (simplify direction configuration...)
- Dropped the channel priority related patches since we are going to go via
different route for configuring the priority.
- Added ACK from
edma param struct is now within an edma_pset struct introduced in Thomas
Gleixner's edma tx status series. Update memcpy function for the same.
Cc: Thomas Gleixner t...@linutronix.de
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma/edma.c |4 ++--
1 file changed, 2 insertions(+), 2
The granular residue accounting code uses certain variables specifically
for residue accounting. Document these in the structure declaration.
Also move around some elements and group them together.
Cc: Thomas Gleixner t...@linutronix.de
Signed-off-by: Joel Fernandes jo...@ti.com
---
drivers/dma
On 05/27/2014 05:22 AM, Peter Ujfalusi wrote:
On 05/27/2014 12:32 AM, Olof Johansson wrote:
[..]
I came across this patch when I was looking at a pull request from
Sekhar for EDMA cleanups, and it made me look closer at the contents
of this file.
The include/linux/platform_data/ directory
53 matches
Mail list logo
