Re: [PATCH 2/6] ARM: DTS: da850: Add node for edma0

2014-08-01 Thread Sekhar Nori 
On Friday 01 August 2014 10:39 AM, Peter Ujfalusi wrote:
 On 07/31/2014 05:26 PM, Sergei Shtylyov wrote:
 On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:

 Add DT node for edma0.

 Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
 ---
   arch/arm/boot/dts/da850.dtsi | 6 ++
   1 file changed, 6 insertions(+)

 diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
 index b695548dbb4e..41ce4e8bf227 100644
 --- a/arch/arm/boot/dts/da850.dtsi
 +++ b/arch/arm/boot/dts/da850.dtsi
 @@ -150,6 +150,12 @@
   };

   };
 +edma0: edma@01c0 {
 +compatible = ti,edma3;
 +reg =0x0 0x1;

Why the mismatch between the unit-address part of the node name and the
 reg property?
 
 For some reason the whole da850 uses offset from 0x01c0 for the SoC IPs.
 The nodes are under 'soc' and that has the ranges attribute.
 I do not really like this either.

There is no reason I can remember for why we chose to go the offset +
ranges way. Probably based it on an early OMAP example. Right now lets
keep it that way unless there is a big disadvantage.

Thanks,
Sekhar
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH 2/6] ARM: DTS: da850: Add node for edma0

2014-07-31 Thread Sergei Shtylyov 

On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:


Add DT node for edma0.



Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
  arch/arm/boot/dts/da850.dtsi | 6 ++
  1 file changed, 6 insertions(+)



diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
index b695548dbb4e..41ce4e8bf227 100644
--- a/arch/arm/boot/dts/da850.dtsi
+++ b/arch/arm/boot/dts/da850.dtsi
@@ -150,6 +150,12 @@
};

};
+   edma0: edma@01c0 {
+   compatible = ti,edma3;
+   reg =   0x0 0x1;


   Why the mismatch between the unit-address part of the node name and the 
reg property?



+   interrupts = 11 13 12;
+   #dma-cells = 1;
+   };


WBR, Sergei

___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Re: [PATCH 2/6] ARM: DTS: da850: Add node for edma0

2014-07-31 Thread Peter Ujfalusi 
On 07/31/2014 05:26 PM, Sergei Shtylyov wrote:
 On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:
 
 Add DT node for edma0.
 
 Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
 ---
   arch/arm/boot/dts/da850.dtsi | 6 ++
   1 file changed, 6 insertions(+)
 
 diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
 index b695548dbb4e..41ce4e8bf227 100644
 --- a/arch/arm/boot/dts/da850.dtsi
 +++ b/arch/arm/boot/dts/da850.dtsi
 @@ -150,6 +150,12 @@
   };

   };
 +edma0: edma@01c0 {
 +compatible = ti,edma3;
 +reg =0x0 0x1;
 
Why the mismatch between the unit-address part of the node name and the
 reg property?

For some reason the whole da850 uses offset from 0x01c0 for the SoC IPs.
The nodes are under 'soc' and that has the ranges attribute.
I do not really like this either.

 
 +interrupts = 11 13 12;
 +#dma-cells = 1;
 +};
 
 WBR, Sergei
 

-- 
Péter
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source