Re: more on execute_array not complying with the specification

2011-02-05 Thread Martin J. Evans
On 03/02/2011 10:01, Tim Bunce wrote: On Wed, Feb 02, 2011 at 03:52:00PM +, Martin J. Evans wrote: [...] So, I think DBI works fine right now (given slight pod change) and don't want to complicate it or worse, break peoples existing code. Great! :) DBD:: Oracle on the other hand does not

Re: more on execute_array not complying with the specification

2011-02-03 Thread Tim Bunce
On Wed, Feb 02, 2011 at 03:52:00PM +, Martin J. Evans wrote: > > [...] > > So, I think DBI works fine right now (given slight pod change) and > don't want to complicate it or worse, break peoples existing code. Great! :) > DBD:: Oracle on the other hand does not but I believe John has alread

Re: more on execute_array not complying with the specification

2011-02-02 Thread John Scoles
On 02/02/2011 10:52 AM, Martin J. Evans wrote: The argument seems to have got confused here between what DBI does, what it says it does and DBD::Oracle (which does neither). I don't want (and don't think) any change (other than in pod) in DBI is necessary. The thread started with my observati

Re: more on execute_array not complying with the specification

2011-02-02 Thread Martin J. Evans
The argument seems to have got confused here between what DBI does, what it says it does and DBD::Oracle (which does neither). I don't want (and don't think) any change (other than in pod) in DBI is necessary. The thread started with my observations of differences between DBI and DBD::Oracle wit

Re: more on execute_array not complying with the specification

2011-02-02 Thread John Scoles
On 02/02/2011 7:15 AM, Tim Bunce wrote: On Tue, Feb 01, 2011 at 09:02:26PM +, Martin J. Evans wrote: On 01/02/2011 20:50, Tim Bunce wrote: On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote: My only concern is when it does error (no matter what the setting of AutoCommit) you alwa

Re: more on execute_array not complying with the specification

2011-02-02 Thread Tim Bunce
On Tue, Feb 01, 2011 at 09:02:26PM +, Martin J. Evans wrote: > On 01/02/2011 20:50, Tim Bunce wrote: > >On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote: > > >>My only concern is when it does error (no matter what the setting of > >>AutoCommit) you always get unef; > >Umm, yes. Retu

Re: more on execute_array not complying with the specification

2011-02-01 Thread Martin J. Evans
On 01/02/2011 20:50, Tim Bunce wrote: On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote: On 01/02/2011 10:48 AM, Tim Bunce wrote: On Mon, Jan 31, 2011 at 08:39:40PM +, Martin J. Evans wrote: I imagine most DBDs [if not all] that implement execute_array [Just a reminder that dr

Re: more on execute_array not complying with the specification

2011-02-01 Thread Tim Bunce
On Tue, Feb 01, 2011 at 10:58:14AM -0500, John Scoles wrote: > On 01/02/2011 10:48 AM, Tim Bunce wrote: > >On Mon, Jan 31, 2011 at 08:39:40PM +, Martin J. Evans wrote: > >>I imagine most DBDs [if not all] that implement execute_array > >[Just a reminder that drivers can opt to implement just >

Re: more on execute_array not complying with the specification

2011-02-01 Thread John Scoles
On 01/02/2011 11:04 AM, Martin J. Evans wrote: On 01/02/11 15:50, John Scoles wrote: On 01/02/2011 10:44 AM, Tim Bunce wrote: On Sun, Jan 30, 2011 at 05:46:49PM +, Martin J. Evans wrote: push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ]; so I guess the pod should sa

Re: more on execute_array not complying with the specification

2011-02-01 Thread Martin J. Evans
On 01/02/11 15:50, John Scoles wrote: > On 01/02/2011 10:44 AM, Tim Bunce wrote: >> On Sun, Jan 30, 2011 at 05:46:49PM +, Martin J. Evans wrote: >>> push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ]; >>> >>> so I guess the pod should say: >>> >>> "If the execution of a tu

Re: more on execute_array not complying with the specification

2011-02-01 Thread John Scoles
On 01/02/2011 10:48 AM, Tim Bunce wrote: On Mon, Jan 31, 2011 at 08:39:40PM +, Martin J. Evans wrote: I imagine most DBDs [if not all] that implement execute_array [Just a reminder that drivers can opt to implement just execute_for_fetch() and use the DBI's default execute_array() method,

Re: more on execute_array not complying with the specification

2011-02-01 Thread John Scoles
On 01/02/2011 10:44 AM, Tim Bunce wrote: On Sun, Jan 30, 2011 at 05:46:49PM +, Martin J. Evans wrote: push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ]; so I guess the pod should say: "If the execution of a tuple causes an error, then the corresponding status array

Re: more on execute_array not complying with the specification

2011-02-01 Thread Martin J. Evans
On 01/02/11 15:44, Tim Bunce wrote: > On Sun, Jan 30, 2011 at 05:46:49PM +, Martin J. Evans wrote: >> >> push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ]; >> >>so I guess the pod should say: >> >>"If the execution of a tuple causes an error, then the corresponding >> stat

Re: more on execute_array not complying with the specification

2011-02-01 Thread Tim Bunce
On Mon, Jan 31, 2011 at 08:39:40PM +, Martin J. Evans wrote: > I imagine most DBDs [if not all] that implement execute_array [Just a reminder that drivers can opt to implement just execute_for_fetch() and use the DBI's default execute_array() method, which then calls execute_for_fetch().] > t

Re: more on execute_array not complying with the specification

2011-02-01 Thread Tim Bunce
On Sun, Jan 30, 2011 at 05:46:49PM +, Martin J. Evans wrote: > > push @$tuple_status, [ $sth->err, $sth->errstr, $sth->state ]; > >so I guess the pod should say: > >"If the execution of a tuple causes an error, then the corresponding > status array element will be set to >a ref

Re: more on execute_array not complying with the specification

2011-01-31 Thread Martin J. Evans
On 30/01/2011 18:02, John Scoles wrote: One other thing I was picking up on is the case if you have autocommit on and RaiseError off I this case it if there was a an error while running in list mode it will allways return undef. Where looking at the spec one might expect to see undef and XX wh

Re: more on execute_array not complying with the specification

2011-01-31 Thread Martin J. Evans
On 30/01/2011 17:46, Martin J. Evans wrote: Hi, I'm still working on and off with execute_array problems hoping to get DBI and the spec to match and also investigating if the current implementation covers all possibilities. I've now written a simple test to see if it complies with the specifi

Re: more on execute_array not complying with the specification

2011-01-30 Thread John Scoles
One other thing I was picking up on is the case if you have autocommit on and RaiseError off I this case it if there was a an error while running in list mode it will allways return undef.  Where looking at the spec one might expect to see undef and XX which would be the # ot records effected? A

more on execute_array not complying with the specification

2011-01-30 Thread Martin J. Evans
Hi, I'm still working on and off with execute_array problems hoping to get DBI and the spec to match and also investigating if the current implementation covers all possibilities. I've now written a simple test to see if it complies with the specification (and will include it in DBD::ODBC) an