Re: extra dependancies vs. testability?

2006-01-11 Thread Ron Savage
On Thu, 12 Jan 2006 09:56:55 +1000, Robert Loomans wrote: Hi Robert > As a compromise, Tyler, how 'bout you only run the tests in this > case if SQLite is *already* installed? Other modules already do > things this way. eg, look at Log::Log4perl and the tests for LWP, Yeah, this should be ok. --

Re: Fwd: how to detect that we're running under CPAN::Testers?

2006-01-11 Thread JupiterHost.Net
Is there any way to tell if my package is being tested automatically under CPAN::Testers? Here's the situation: I've never used that module but this should work: if(exists $INC{'CPAN/Testers.pm'}) { print "I am probably running under CPAN::Testers\n"; } else { print "I am prob

Fwd: how to detect that we're running under CPAN::Testers?

2006-01-11 Thread Tyler MacDonald
Ron Savage suggested that the ideal way to handle the "end user vs. autotester" scenario was to encourage the autotesters to install DBD::SQLite2 (or perhaps set a valid DBI_DSN) for the testing. testers.cpan.org's existant autotest system doesn't seem to have a way to tell them this beyond

Re: extra dependancies vs. testability?

2006-01-11 Thread Robert Loomans
> > - If DBI_DSN is not set, default to depending on, and testing > > against, SQLite. > > No. People should have to explicitly set DBI_DSN to make it do something. > So, unset should be the same as set to empty string. I don't agree. As a compromise, Tyler, how 'bout you only run the tests in t

Perl DBI 1.50 Scalar::Util::weaken support test bug

2006-01-11 Thread Jason Wall
There is a line of bad code on line 279. I document the error here: http://www.walljm.com/comments.asp?post=4776 Essentially, 279 Scalar::Util::weaken(my $test = \"foo"); the \ is negating the " and instead of a reference, its returning something else. Hope this helps... its cause Ikonboar

Re: extra dependancies vs. testability?

2006-01-11 Thread Ron Savage
On Wed, 11 Jan 2006 13:45:30 -0800, Tyler MacDonald wrote: Hi Tyler I do understand your point, but I think you need to re-think this. > *whines* But this would break the functionality I was looking for > in the first place: good automated QA being in a somewhat self- So far so good. > contain

Re: extra dependancies vs. testability?

2006-01-11 Thread Tyler MacDonald
Ron Savage <[EMAIL PROTECTED]> wrote: > > - If DBI_DSN is not set, default to depending on, and testing > > against, SQLite. > No. People should have to explicitly set DBI_DSN to make it do something. > So, unset should be the same as set to empty string. *whines* But this would break the

Re: extra dependancies vs. testability?

2006-01-11 Thread Ron Savage
On Wed, 11 Jan 2006 13:07:18 -0800, Tyler MacDonald wrote: Hi Tyler > Currently, it *does* use the prompt() function supplied by > ExtUtils::MakeMaker, which is supposed to prompt you if you have a > controlling terminal, so long as PERL_MM_USE_DEFAULT is not set. Excellent! Much appreciated. -

Re: extra dependancies vs. testability?

2006-01-11 Thread Ron Savage
On Wed, 11 Jan 2006 13:19:41 -0800, Tyler MacDonald wrote: Hi Tyler > I've had some time to digest this, and it seems that rather than > coining an entirely new environment variable, I could use DBI_DSN: Good! Here are my votes: > - If DBI_DSN is set, use that as the DSN for testing, and don't

Re: extra dependancies vs. testability?

2006-01-11 Thread Tyler MacDonald
Tyler MacDonald <[EMAIL PROTECTED]> wrote: > > If you really want, make the SQLite tests optional if some environment > > variable is set (eg, SKIP_SQLLITE_TEST). > > OK, I like the environment variable thing. That gives me the > opportunity to warn a user installing manually via CPAN that t

Re: extra dependancies vs. testability?

2006-01-11 Thread Tyler MacDonald
Ron Savage <[EMAIL PROTECTED]> wrote: > On Tue, 10 Jan 2006 20:00:14 -0800, Tyler MacDonald wrote: > > Hi Tyler > > > OK, I like the environment variable thing. That gives me the > > opportunity to warn a user installing manually via CPAN that they > > don't have to install SQLite2 if they don't

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Tim Bunce
Great. Thanks Tom. Tim. On Wed, Jan 11, 2006 at 01:10:43PM +0100, Tom Schindl wrote: > and here's the proposed patch hopefully my english is good enough. > > Tom > Index: DBI.pm > === > --- DBI.pm(Revision 2381) > +++ DBI.pm

Re: Compiling DBI on Solaris: USE_LONG_DOUBLE

2006-01-11 Thread Tim Bunce
On Fri, Jan 06, 2006 at 06:05:51PM +, Tim Bunce wrote: > On Fri, Jan 06, 2006 at 09:07:42AM -0800, Gerald Gallagher wrote: > > Trying to compile DBI 1.50 on Solaris 8 using Sun WorkShop 6. The > > "40profile" test fails because dbi_profile_merge is returning way too many > > decimal places.

Re: DBI 1.48 connection failure to MS SQL

2006-01-11 Thread John Scoles
> "Claire Lee" wrote > >I'm on Windows XP. Forgive my ignorance, can you >explain why DBI:ODBC needs to be recompiled? Why do >you think this may be the problem? I've always thought >I can download a module and use it. Never thought a >later DBI version will be incompatible with an older >one. Than

Re: DBD::Oracle and 10g

2006-01-11 Thread John Scoles
Opps me bad typo in the cut and paste. I hate computers. Yest the '.' is needed. ""Andy Hassall"" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > > Yes there is a newer Makfile.pl You might want to try that. > > > > One other quick suggestion id to set > > > > NLS_LANG=WE8ISO8859P15

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Peter J. Holzer
On 2006-01-10 17:17:21 +, Tim Bunce wrote: > On Tue, Jan 10, 2006 at 12:47:54PM +0100, Peter J. Holzer wrote: > > Anyway, I rather frequently find that the "most natural" way to > > represent a query result is an array of hashes: Each row is hashref, but > > the the rows are in an array(ref) so

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Peter J. Holzer
On 2006-01-11 10:34:21 +0100, Peter J. Holzer wrote: > On 2006-01-10 17:17:21 +, Tim Bunce wrote: > > Anything wrong with the existing > > > > my $emp = $dbh->selectall_arrayref("...", { Slice => {} }); > > > > ? > > Nothing, except that I didn't know about it. > > Looks like it was too

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Tom Schindl
and here's the proposed patch hopefully my english is good enough. Tom Index: DBI.pm === --- DBI.pm (Revision 2381) +++ DBI.pm (Arbeitskopie) @@ -4014,7 +4014,17 @@ In which case the array is copied and each value decremented before

Re: extra dependancies vs. testability?

2006-01-11 Thread Ron Savage
On Tue, 10 Jan 2006 20:00:14 -0800, Tyler MacDonald wrote: Hi Tyler > OK, I like the environment variable thing. That gives me the > opportunity to warn a user installing manually via CPAN that they > don't have to install SQLite2 if they don't want. Just for the record: When I install a set of

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Tim Bunce
On Wed, Jan 11, 2006 at 10:37:58AM +0100, Tom Schindl wrote: > Tim Bunce wrote: > >Anything wrong with the existing > > > >my $emp = $dbh->selectall_arrayref("...", { Slice => {} }); > > > >? > >Please spread the word. Way too many people seem to not know about this! > > Maybe if there would

Re: Convenience function selectall_hasharrayref

2006-01-11 Thread Tom Schindl
Tim Bunce wrote: >On Tue, Jan 10, 2006 at 12:47:54PM +0100, Peter J. Holzer wrote: > > >>or selectall_arrayhashref? >> >>Anyway, I rather frequently find that the "most natural" way to >>represent a query result is an array of hashes: Each row is hashref, but >>the the rows are in an array(ref)