Hi, I confirm that subqueries are implemented in the 1.50RC branch (have a look at the L<CHANGES> section).
Concerning tests : SQLA 1.50 often generates less parentheses than previous versions. So the output is equivalent in semantics, but not in surface syntax; as a result, the applications will most probably continue to work , but the tests do fail because the best they can do is to check the resulting SQL syntax. It would be quite difficult and rather pointless to try to generate exactly the same parentheses as before; so instead, there is a test module SQL::Abstract::Test that implements a test function is_same_sql_bind(..) that compares SQL statements on abstract level, ignoring unnecessary parentheses. As an example, attached is a a test rewrite for SQL::Abstract::Limit . Yes it would be great if somebody could invest some time in testing it against DBIx-Class. Best regards, Laurent Dami >-----Message d'origine----- >De : Peter Rabbitson [mailto:[EMAIL PROTECTED] >Envoyé : vendredi, 31. octobre 2008 23:49 >À : Class user and developer list >Objet : Re: [Dbix-class] SQL::Abstract 1.x subqueries patch > >BUCHMULLER Norbert wrote: >> Hi, >> >> do you still accept patches for SQL::Abstract 1.x, or should >I wait for >> 2.0 to come out instead? (BTW, what's the proposed time >frame for that?) >> > >There is a mostly-working-1.x-rc at >http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branch >es/1.50_RC. >Patches should be made against it afaik, although it is very possible >this particular bit has been already implemented. > >Also the branch suffers from major shortage of volunteers. It >passes its >own tests but fails reather hard if subjected to the test suite of >dbix-class (i.e. added to PERL5LIB before running make test on the dbic >trunk). So if you can spend some cycles on it, it would be >rather fantastic. > >Cheers > >_______________________________________________ >List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class >IRC: irc.perl.org#dbix-class >SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ >Searchable Archive: >http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk >
01.sql.t
Description: 01.sql.t
_______________________________________________ List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class IRC: irc.perl.org#dbix-class SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/ Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
