Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread Ash Berlin
On 3 Nov 2008, at 12:28, Ash Berlin wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. If you are going to make changes to DBIC, can you please so on a branch (assuming you have commit access, if

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread Ash Berlin
On 3 Nov 2008, at 11:46, BUCHMULLER Norbert wrote: On Fri, 31 Oct 2008 23:48:56 +0100 Peter Rabbitson [EMAIL PROTECTED] wrote: There is a mostly-working-1.x-rc at http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branches/1.50_RC . Patches should be made against it afaik, although

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Fri, 31 Oct 2008 23:48:56 +0100 Peter Rabbitson [EMAIL PROTECTED] wrote: There is a mostly-working-1.x-rc at http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branches/1.50_RC. Patches should be made against it afaik, although it is very possible this particular bit has been already

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Mon, 3 Nov 2008 12:32:24 + Ash Berlin [EMAIL PROTECTED] wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. Green light, cool. I'll do my best to clean it up. If you are going to make

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Mon, 3 Nov 2008 12:28:40 + Ash Berlin [EMAIL PROTECTED] wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. Matters got bit more complicated: some bits should be merged into