Re: [Dbix-class] find_or_create and unique constraints

2010-10-15 Thread Peter Rabbitson
Bill Moseley wrote: Two issues I'd like to see discussed here is if DBIC should throw an exception if find() returns more than one row (instead of a warning), and if it makes sense to fall back to the full criteria passed to find() if no unique key can be determined. I want to make sure I am

Re: [Dbix-class] find_or_create and unique constraints

2010-10-15 Thread Bill Moseley
On Fri, Oct 15, 2010 at 1:18 AM, Peter Rabbitson rabbit+d...@rabbit.usrabbit%2bd...@rabbit.us wrote: Bill Moseley wrote: Two issues I'd like to see discussed here is if DBIC should throw an exception if find() returns more than one row (instead of a warning), and if it makes sense to fall

Re: [Dbix-class] find_or_create and unique constraints

2010-10-15 Thread Ashley Pond V
On Fri, Oct 15, 2010 at 1:18 AM, Peter Rabbitson rabbit+d...@rabbit.us wrote: I want to make sure I am getting this right - are you proposing that we discuss drastically changing a stable API, potentially breaking DBIC for hundreds if not thousands of users, all for the sake of correctness? I