RE: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-05 Thread Dami Laurent (PJ)
-Message d'origine- De : Zbigniew Lukasiak [mailto:[EMAIL PROTECTED] Envoyé : mercredi, 5. novembre 2008 14:58 À : DBIx::Class user and developer list Objet : Re: [Dbix-class] SQL::Abstract 1.x subqueries patch I've started testing it with the latest DBIC. Here is a test I propose

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-04 Thread Zbigniew Lukasiak
One thing that I am really missing from SQL::A is a way to specify an arbitrary SQL fragment together with bindings and have it interpolated into the rest of the query and bindings. In DBIC with 'search_literal' method and 'where' attribute you can add arbitrary SQL - but only at the beginning or

RE: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-04 Thread Dami Laurent (PJ)
-Message d'origine- De : Zbigniew Lukasiak [mailto:[EMAIL PROTECTED] Envoyé : mardi, 4. novembre 2008 09:25 À : DBIx::Class user and developer list Objet : Re: [Dbix-class] SQL::Abstract 1.x subqueries patch One thing that I am really missing from SQL::A is a way to specify

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-04 Thread BUCHMULLER Norbert
On Tue, 4 Nov 2008 09:24:48 +0100 Zbigniew Lukasiak [EMAIL PROTECTED] wrote: One thing that I am really missing from SQL::A is a way to specify an arbitrary SQL fragment together with bindings and have it interpolated into the rest of the query and bindings. Yeah, that exactly was the feature

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread Ash Berlin
On 3 Nov 2008, at 12:28, Ash Berlin wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. If you are going to make changes to DBIC, can you please so on a branch (assuming you have commit access, if

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread Ash Berlin
On 3 Nov 2008, at 11:46, BUCHMULLER Norbert wrote: On Fri, 31 Oct 2008 23:48:56 +0100 Peter Rabbitson [EMAIL PROTECTED] wrote: There is a mostly-working-1.x-rc at http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branches/1.50_RC . Patches should be made against it afaik, although

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Fri, 31 Oct 2008 23:48:56 +0100 Peter Rabbitson [EMAIL PROTECTED] wrote: There is a mostly-working-1.x-rc at http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branches/1.50_RC. Patches should be made against it afaik, although it is very possible this particular bit has been already

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Mon, 3 Nov 2008 12:32:24 + Ash Berlin [EMAIL PROTECTED] wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. Green light, cool. I'll do my best to clean it up. If you are going to make

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-03 Thread BUCHMULLER Norbert
On Mon, 3 Nov 2008 12:28:40 + Ash Berlin [EMAIL PROTECTED] wrote: Yeah, I think the best plan of attack is to move as much out of DBIC::SQL::A as possible, and then bump the dep on DBIC to SQL::A 1.50. Matters got bit more complicated: some bits should be merged into

RE: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-11-02 Thread Dami Laurent (PJ)
regards, Laurent Dami -Message d'origine- De : Peter Rabbitson [mailto:[EMAIL PROTECTED] Envoyé : vendredi, 31. octobre 2008 23:49 À : Class user and developer list Objet : Re: [Dbix-class] SQL::Abstract 1.x subqueries patch BUCHMULLER Norbert wrote: Hi, do you still accept patches

[Dbix-class] SQL::Abstract 1.x subqueries patch

2008-10-31 Thread BUCHMULLER Norbert
Hi, do you still accept patches for SQL::Abstract 1.x, or should I wait for 2.0 to come out instead? (BTW, what's the proposed time frame for that?) I rather miss the subquery functionality from 1.x to be able to write SQL stored procedure calls on the right-hand side of WHERE conditions like

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-10-31 Thread BUCHMULLER Norbert
On Fri, 31 Oct 2008 20:30:54 +0100 BUCHMULLER Norbert [EMAIL PROTECTED] wrote: The attached patch adds subquery support to the 1.x trunk. (Includes the corresponding tests taken adapted from 2.000 trunk.) Oops, I forgot the documentation. Here goes the patch again. norbi Index:

Re: [Dbix-class] SQL::Abstract 1.x subqueries patch

2008-10-31 Thread Peter Rabbitson
BUCHMULLER Norbert wrote: Hi, do you still accept patches for SQL::Abstract 1.x, or should I wait for 2.0 to come out instead? (BTW, what's the proposed time frame for that?) There is a mostly-working-1.x-rc at http://dev.catalyst.perl.org/repos/bast/SQL-Abstract/1.x/branches/1.50_RC.