Re: [Dbix-class] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

2013-02-22 Thread Will Crawford
It would probably be more intuitive to return something like: { element = { concept = { concept_id = nnn, foldername = 'xxx' }, ... }, ... } ? I've a couple of similar queries that I wrote before I started using HRI much, though I had to use +select/+as then

Re: [Dbix-class] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

2013-02-22 Thread Peter Rabbitson
On Fri, Feb 22, 2013 at 11:23:50AM +, Will Crawford wrote: It would probably be more intuitive to return something like: { element = { concept = { concept_id = nnn, foldername = 'xxx' }, ... }, ... } ? At first glance yes. The problem here is that you

Re: [Dbix-class] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

2013-02-22 Thread Will Crawford
On 22 February 2013 11:36, Peter Rabbitson rabbit+d...@rabbit.us wrote: At first glance yes. The problem here is that you are incorrectly assuming that given 'concept.concept_id' one can simply infer we are talking about the 'concept' from join = { element = 'concept' }. However the moment

Re: [Dbix-class] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

2013-02-22 Thread Peter Rabbitson
On Fri, Feb 22, 2013 at 11:45:54AM +, Will Crawford wrote: On 22 February 2013 11:36, Peter Rabbitson rabbit+d...@rabbit.us wrote: At first glance yes. The problem here is that you are incorrectly assuming that given 'concept.concept_id' one can simply infer we are talking about the

Re: [Dbix-class] [ANNOUNCE] A much faster DBIx::Class public trial round two - v0.08241

2013-02-22 Thread Peter Rabbitson
On Fri, Feb 22, 2013 at 11:05:53PM +1100, Peter Rabbitson wrote: . . . the map is strictly mirroring the current relationship graph of your schema. To clarify this bit as it is in contradiction with http://lists.scsys.co.uk/pipermail/dbix-class/2013-February/09.html The old behavior will

[Dbix-class] search on row-has_many fails if row has prefetch join after 0.08196 - 0.08206 upgrade

2013-02-22 Thread Chisel
At work we had to freeze our DBIC at 0.08196 until the prefetch/namespace bug was fixed ... which it was recently. Internally we've built the new perl+cpandeps RPM including DBIx::Class 0.08206. Things are looking great for the prefetch/namespace fix but something has come to light this week that

Re: [Dbix-class] search on row-has_many fails if row has prefetch join after 0.08196 - 0.08206 upgrade

2013-02-22 Thread Peter Rabbitson
On Fri, Feb 22, 2013 at 04:46:46PM +, Chisel wrote: At work we had to freeze our DBIC at 0.08196 until the prefetch/namespace bug was fixed ... which it was recently. Internally we've built the new perl+cpandeps RPM including DBIx::Class 0.08206. Things are looking great for the

Re: [Dbix-class] search on row-has_many fails if row has prefetch join after 0.08196 - 0.08206 upgrade

2013-02-22 Thread Chisel
On Fri, Feb 22, 2013 at 4:58 PM, Peter Rabbitson rabbit+d...@rabbit.us wrote: The test is comprehensive enough, no further questions. It would be great if you could convert it to a DBIC-internal test, for example based off of: