Re: Resend: [PATCH] DCCP: Divide by zero fix

2006-02-28 Thread Arnaldo Carvalho de Melo
On 2/28/06, Ian McDonald [EMAIL PROTECTED] wrote: Arnaldo, Haven't seen this going in so resending... What a coincidence, I'm testing this patch right now, and I'm afraid it has some bug or makes it more likely that some other bug happens, the machine soft locks with it enabled and when using

[PATCH 3/4] [DCCP] options: Fix some aspects of mandatory option processing

2006-02-28 Thread Arnaldo Carvalho de Melo
According to dccp draft (draft-ietf-dccp-spec-13.txt) section 5.8.2 (Mandatory Option) the following patch correct the handling of the following cases: 1) ... and any Mandatory options received on DCCP-Data packets MUST be ignored. 2) The connection is in error and should be reset with Reset

[PATCH 2/4] [DCCP] ccid2: coding style cleanups

2006-02-28 Thread Arnaldo Carvalho de Melo
No changes in the logic where made. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid2.c | 76 1 files changed, 26 insertions(+), 50 deletions(-) 1c6ddda9288aba6a761b45357d119a47df165d4a diff --git

[PATCH 4/4] [DCCP] ccid3: Divide by zero fix

2006-02-28 Thread Arnaldo Carvalho de Melo
In rare circumstances 0 is returned by dccp_li_hist_calc_i_mean which leads to a divide by zero in ccid3_hc_rx_packet_recv. Explicitly check for zero return now. Update copyright notice at same time. Found by Arnaldo. Signed-off-by: Ian McDonald [EMAIL PROTECTED] Signed-off-by: Arnaldo Carvalho

[PATCH 0/4][DCCP]: Fixes and cleanups

2006-02-28 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git Best Regards, - Arnaldo ccids/ccid2.c | 77 + ccids/ccid3.c | 11 +- ipv6.c| 257 +- options.c |

[PATCH 1/4] [DCCP] ipv6: cleanups

2006-02-28 Thread Arnaldo Carvalho de Melo
No changes in the logic were made, just removing trailing whitespaces, etc. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ipv6.c | 256 --- 1 files changed, 129 insertions(+), 127 deletions(-)

Re: [PATCH 0/4][DCCP]: Fixes and cleanups

2006-02-28 Thread David S. Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Tue, 28 Feb 2006 19:09:02 -0300 Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git All looks good, pulled. Thanks a lot. - To unsubscribe from this list: send the line unsubscribe dccp in

[BUG] DCCP : Suspected race in ackvec code

2006-02-28 Thread Ian McDonald
When send_ackvec sysctl is on DCCP locks the machine. Unfortunately it doesn't send any output to the kernel. Test cases: On receive end (10.0.2.2): ./ttcp_acme -c -l500 -r On send end (10.0.7.7): ./ttcp_acme -c -l500 -n1000 -t 10.0.2.2 And the setup on 10.0.5.5 (which provides a route between

Re: [BUG] DCCP : Suspected race in ackvec code

2006-02-28 Thread Arnaldo Carvalho de Melo
On 2/28/06, Ian McDonald [EMAIL PROTECTED] wrote: When send_ackvec sysctl is on DCCP locks the machine. Unfortunately it doesn't send any output to the kernel. I'm getting below results by just stopping the syslog daemon and setting printk log level to 9: [EMAIL PROTECTED] ~]# service syslog