Re: [PATCH 3/6]: Fix calculation of t_ipi time of scheduled transmission

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/21/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Fix calculation of t_ipi time of scheduled transmission Problem: Currently packet transmissions are not scheduled according to [RFC 3448, 4.6] and will, in the worst case, be sent later than necessary. If scheduled

Re: [PATCH 2/6]: Simplify control flow in the calculation of t_ipi

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/26/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: On 11/21/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Simplify control flow in the calculation of t_ipi This patch performs a simplifying (performance) optimisation: In each call of the inline function

Re: [PATCH 4/6]: Simplify control flow of ccid3_hc_tx_send_packet

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/21/06, Ian McDonald [EMAIL PROTECTED] wrote: On 11/22/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Simplify control flow of ccid3_hc_tx_send_packet This makes some logically equivalent simplifications, by replacing rc - values plus goto's with direct return statements.

Re: [PATCH 1/10]: Avoid congestion control on zero-sized data packets

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Avoid congestion control on zero-sized data packets This resolves an `XXX' in ccid3_hc_tx_send_packet(). The function is only called on Data and DataAck packets and returns a negative result on zero-sized messages. This is a

Re: [PATCH 3/10]: Resolve small FIXME

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Resolve small FIXME This considers the case - ACK received while no packet has been sent so far. Resolved by printing a (rate-limited) warning message. Further removes an unnecessary BUG_ON in ccid3_hc_tx_packet_recv, received

Re: [PATCH 4/10]: Consolidate timer resets

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Consolidate timer resets The specification in [RFC 3448, 4.4, step (3)] is impossible to implement: when no feedback has been received, the value of RTT is undefined as per [RFC 3448, 4.2]. Hence we can not set the timeout value to

Re: [PATCH 5/10]: Consistently update t_nom, t_ipi, t_delta

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3] Consistently update t_nom, t_ipi, t_delta This patch * consolidates updating of parameters (t_nom, t_ipi, t_delta) which need to be updated at the same time, since they are inter-dependent * removes two inline functions which

Re: [PATCH 6/10]: Consolidate handling of t_RTO

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3] Consolidate handling of t_RTO This patch * removes setting t_RTO in ccid3_hc_tx_init (per [RFC 3448, 4.2], t_RTO is undefined until feedback has been received); * makes some trivial changes (updates of comments); * performs a

Re: [PATCH 9/10]: Add documentation for TFRC structures

2006-11-26 Thread Arnaldo Carvalho de Melo
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote: [NET]: Add documentation for TFRC structures This adds documentation for the TFRC structure fields. Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Thanks, applied. - Arnaldo - To unsubscribe from this list: send the line unsubscribe dccp

Re: [PATCH 1/10]: Avoid congestion control on zero-sized data packets

2006-11-26 Thread Ian McDonald
On 11/25/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Avoid congestion control on zero-sized data packets Signed-off-by: Ian McDonald [EMAIL PROTECTED] I think in both of these functions we should change len to unsigned or make more explicit checks as we can have problems with

Re: [PATCH 0/10] [RFC]: CCID 3 updates

2006-11-26 Thread Ian McDonald
On 11/25/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: On Fri, Nov 24, 2006 at 04:19:04PM +, Gerrit Renker wrote: I have cut this into 10 small pieces to make reviewing easier. If everyone is happy with it, I can re-send it as one piece. I'll look at it probably tomorrow

Re: [PATCH 3/10]: Resolve small FIXME

2006-11-26 Thread Ian McDonald
On 11/25/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3]: Resolve small FIXME Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group Department of Computer Science University of Waikato New

Re: [PATCH 5/10]: Consistently update t_nom, t_ipi, t_delta

2006-11-26 Thread Ian McDonald
On 11/25/06, Gerrit Renker [EMAIL PROTECTED] wrote: [CCID 3] Consistently update t_nom, t_ipi, t_delta Acked-by: Ian McDonald [EMAIL PROTECTED] * ties updating these parameters to updating the sending rate X, exploiting that all three parameters in turn depend on X; and using a small

Re: [PATCH 9/10]: Add documentation for TFRC structures

2006-11-26 Thread Ian McDonald
On 11/25/06, Gerrit Renker [EMAIL PROTECTED] wrote: [NET]: Add documentation for TFRC structures Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group Department of Computer Science University