Re: [PATCH 0/6] DCCP: Implement TFRC Faster Restart

2007-09-05 Thread Gerrit Renker
| When there is little or no documentation in the code saying which variable or piece of | code belongs where, then each time someone wants to change a bit of code has to reverse- | engineer what actually is going on. This can be very time-consuming. So I was not thinking | in terms of

[PATCH 2/6] DCCP: Add setsocketopts for CCIDs

2007-09-05 Thread Ian McDonald
For faster restart and TFRCbis we need to pass socket options down to CCIDs. Add framework in for this. Shift check for LISTEN as part of this, as suggested by Gerrit Renker. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccid.h b/net/dccp/ccid.h index c65cb24..0067526

[PATCH 3/6] DCCP: Introduce CCID3 extensions

2007-09-05 Thread Ian McDonald
In this patch we introduce the extension TFRC faster restart. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.h b/net/dccp/ccids/ccid3.h index 5a23b62..6de73f7 100644 --- a/net/dccp/ccids/ccid3.h +++ b/net/dccp/ccids/ccid3.h @@ -116,6 +116,7 @@ struct

[PATCH 5/6] DCCP: Check if faster restart is on

2007-09-05 Thread Ian McDonald
This adds new helper functions to check if faster restart is turned on. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.h b/net/dccp/ccids/ccid3.h index c77c8fb..7edbf70 100644 --- a/net/dccp/ccids/ccid3.h +++ b/net/dccp/ccids/ccid3.h @@ -182,4 +182,11 @@

[PATCH 4/6] DCCP: Add framework for faster restart

2007-09-05 Thread Ian McDonald
Set up options for enabling TFRC options. Also add variables for faster restart. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/include/linux/dccp.h b/include/linux/dccp.h index 1f696f9..17a8016 100644 --- a/include/linux/dccp.h +++ b/include/linux/dccp.h @@ -209,7 +209,9 @@

[PATCH 6/6] DCCP: Implement faster restart

2007-09-05 Thread Ian McDonald
This implements TFRC faster restart as per: draft-ietf-dccp-tfrc-faster-restart-03.txt and with changes from: http://www3.ietf.org/proceedings/07jul/slides/dccp-6.pdf Most notably we don't do pings. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.c

Re: [PATCH 0/10]: Support for passive close

2007-09-05 Thread Ian McDonald
On 7/18/07, Gerrit Renker [EMAIL PROTECTED] wrote: | Please note your method works perfectly fine and is an acceptable fix, | and can go in. My method may not even work as I'm thinking out loud | here really. This really is appreciated since by looking at the same thing one often gets

Re: [PATCH 1/10]: Separate protocol states into general/specific

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: http://iansblog.jandi.co.nz - To unsubscribe from this list: send the line

Re: [PATCH 2/10]: Make PARTOPEN an autonomous state

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Make PARTOPEN an autonomous state This decouples PARTOPEN from TCP-specific stream-states, as suggested by the FIXME-comment. The code has been checked with regard to dependency on PARTOPEN and FIN_WAIT1 states (to which PARTOPEN

Re: [PATCH 3/10]: Dedicated auxiliary states to support passive-close

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Dedicated auxiliary states to support passive-close Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog:

Re: [PATCH 4/10]: Basic support for passive-close

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Basic support for passive-close This implements necessary state transitions for the two forms of passive-close * PASSIVE_1, which is entered when a host receives Close; * PASSIVE_2, which is entered when a client receives CloseReq.

Re: [PATCH 5/10]: Perform SHUT_RD and SHUT_WR on receiving close

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Perform SHUT_RD and SHUT_WR on receiving close The first change is to close the write-end in addition to the read-end when a fin-like segment (Close or CloseReq) is received by DCCP. This accounts for the fact that DCCP, in contrast

Re: [PATCH 6/10]: Reduce the number of writable states

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Reduce the number of writable states Since DCCP requires to close both ends of a connection simultaneously, permission to write in state DCCP_CLOSING is removed in dccp_sendmsg(): * if the sending end closed, it would encounter a

Re: [PATCH 7/10]: Shift the retransmit timer for active-close into output.c

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Shift the retransmit timer for active-close into output.c When performing active close, RFC 4340, 8.3. requires to retransmit the Close/CloseReq with a backoff-retransmit timer starting at intially 2 RTTs. This patch shifts the

Re: [PATCH 9/10]: Support for server holding timewait state

2007-09-05 Thread Ian McDonald
On 7/13/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Support for server holding timewait state This adds a socket option and signalling support for the case where the server holds timewait state on closing the connection, as described in RFC 4340, 8.3. Since holding timewait state at

Re: [PATCH 1/3]: Honour and make use of shutdown option set by user

2007-09-05 Thread Ian McDonald
On 8/10/07, Gerrit Renker [EMAIL PROTECTED] wrote: [DCCP]: Honour and make use of shutdown option set by user Signed-off-by: Gerrit Renker [EMAIL PROTECTED] Signed-off-by: Ian McDonald [EMAIL PROTECTED] -- Web1: http://wand.net.nz/~iam4/ Web2: http://www.jandi.co.nz Blog: