Re: [BUG] DCCP : Suspected race in ackvec code

2006-02-28 Thread Arnaldo Carvalho de Melo
On 2/28/06, Ian McDonald [EMAIL PROTECTED] wrote: When send_ackvec sysctl is on DCCP locks the machine. Unfortunately it doesn't send any output to the kernel. I'm getting below results by just stopping the syslog daemon and setting printk log level to 9: [EMAIL PROTECTED] ~]# service syslog

[PATCH 2/3] [DCCP]: Uninline some functions

2006-02-25 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ccids/ccid3.c | 10 + net/dccp/dccp.h| 49 ++--- net/dccp/input.c |7 +++--- net/dccp/output.c |2 +- net/dccp/proto.c | 52

[PATCH 3/3] [DCCP] ipv6: Add missing ipv6 control socket

2006-02-25 Thread Arnaldo Carvalho de Melo
way for freeing the control sockets in upcoming changesets. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/Kconfig |9 --- net/dccp/ccids/ccid3.c |9 --- net/dccp/dccp.h|4 +-- net/dccp/ipv4.c| 65

[PATCH 1/7] [DCCP]: Generalize dccp_v4_send_reset

2006-02-23 Thread Arnaldo Carvalho de Melo
Renaming it to dccp_send_reset and moving it from the ipv4 specific code to the core dccp code. This fixes some bugs in IPV6 where timers would send v4 resets, etc. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h |6 +- net/dccp/input.c |2 +- net

[PATCH 3/7] [DCCP]: Move dccp_[un]hash from ipv4.c to the core

2006-02-23 Thread Arnaldo Carvalho de Melo
As this is used by both ipv4 and ipv6 and is not ipv4 specific. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h |1 + net/dccp/ipv4.c | 14 +- net/dccp/ipv6.c |2 +- net/dccp/proto.c | 14 ++ 4 files changed, 17 insertions

[PATCH 2/7] [DCCP]: Move dccp_v4_{init,destroy}_sock to the core

2006-02-23 Thread Arnaldo Carvalho de Melo
Removing one more ipv6 uses ipv4 stuff case in dccp land. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/dccp.h |4 +- net/dccp/ipv4.c | 106 +++--- net/dccp/ipv6.c |4 +- net/dccp/proto.c | 102

[PATCH 7/7] [DCCP]: Move the IPv4 specific bits from proto.c to ipv4.c

2006-02-23 Thread Arnaldo Carvalho de Melo
is legacy, I only want ipv6 dude! direction. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/Makefile |7 +-- net/dccp/dccp.h|6 -- net/dccp/ipv4.c| 140 ++-- net/dccp/options.c |2 + net/dccp/output.c |2

[PATCH 3/4] [DCCP]: Call dccp_feat_init more early in dccp_v4_init_sock

2006-02-22 Thread Arnaldo Carvalho de Melo
So that dccp_feat_clean doesn't get confused with uninitialized list_heads. Noticed when testing with no ccid kernel modules. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/dccp/ipv4.c |9 - 1 files changed, 4 insertions(+), 5 deletions

[PATCH 1/4] [DCCP]: Make CCID2 be the default

2006-02-22 Thread Arnaldo Carvalho de Melo
setsockopt to specify the desired CCID, etc. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- include/linux/dccp.h |9 - 1 files changed, 0 insertions(+), 9 deletions(-) 499dbc5e7f577a3a1712cee8dcb0e540082ab81d diff --git a/include/linux/dccp.h b/include/linux/dccp.h index

Re: [PATCH] 1/1 dccp: transmit buffering

2006-02-21 Thread Arnaldo Carvalho de Melo
On 2/20/06, Ian McDonald [EMAIL PROTECTED] wrote: Arnaldo, (or anybody else) I can get it working with the extra lock but not without... Comments inline and at the end. Help much appreciated! Please leave the extern Yep! I guess we don't need this lock, but instead use bh_lock_sock,

[PATCH 1/1][DCCP]: sparse endianness annotations

2006-02-21 Thread Arnaldo Carvalho de Melo
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Signed-off-by: Al Viro [EMAIL PROTECTED] -- include/linux/dccp.h | 52 +++-- net/dccp/ccids/ccid3.c |6 ++--- net/dccp/dccp.h

Re: [PATCH 1/1][DCCP]: sparse endianness annotations

2006-02-21 Thread Arnaldo Carvalho de Melo
On 2/21/06, David S. Miller [EMAIL PROTECTED] wrote: From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Tue, 21 Feb 2006 21:49:14 -0300 Do you prefer? Today I talked with our git guy (Eduardo Habkost) and changed my mind, doing things (duh!) in master and using git-fetch/ git-rebase

[PATCH 1/2][DCCP] CCID: Improve CCID infrastructure

2006-02-20 Thread Arnaldo Carvalho de Melo
Carvalho de Melo [EMAIL PROTECTED] 1140438322 -0300 committer Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1140438322 -0300 [DCCP] CCID: Improve CCID infrastructure 1. No need for -ccid_init nor -ccid_exit, this is what module_{init,exit} does and anynways neither ccid2 nor ccid3 were using it. 2

Re: 2.6.16-rc4-mm1

2006-02-20 Thread Arnaldo Carvalho de Melo
On 2/20/06, Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote: Patrick McHardy schrieb: Reuben Farrelly wrote: Minor dependency issue: My compile failed with this.. CC [M] net/netfilter/xt_dccp.o In file included from net/netfilter/xt_dccp.c:15: include/linux/dccp.h:341:2: error:

Re: [PATCH 1/1]: [CCID2]: Fix the use of the RTO timer

2006-02-15 Thread Arnaldo Carvalho de Melo
On 2/14/06, Andrea Bittau [EMAIL PROTECTED] wrote: Drop sock reference count on timer expiration and reset. There was a hybrid use of standard timers and sk_timers. This caused the reference count of the sock to be incorrect when resetting the RTO timer. The sock reference count should now

Re: Discussion of ECN API?

2005-12-20 Thread Arnaldo Carvalho de Melo
I'm not aware of any, at the same time I think DCCP should at least expose the info on ack vectors,so the question is: is the information available on ack vectors enough for you (the app writers?)? - Arnaldo On 12/19/05, Bruce Barnett [EMAIL PROTECTED] wrote: I've been involved with the

[PATCH 2/2][IP_SOCKGLUE]: Remove most of the tcp specific calls

2005-12-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree 99f9e56a48a5a7a783875df630e84c91fd06488a parent 793a36f474b6d9991f6c1c218041e350cda57195 author Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1134430852 -0200

Re: [PATCH 2/2][IP_SOCKGLUE]: Remove most of the tcp specific calls

2005-12-12 Thread Arnaldo Carvalho de Melo
On 12/12/05, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Oops, there was a bug introduced by this patch at this hunk: @@ -870,7 +872,7 @@ static struct sock * tcp_v6_syn_recv_soc

Re: [PATCH 1/4][DCCP]: Introduce DCCPv6

2005-12-11 Thread Arnaldo Carvalho de Melo
On 12/11/05, Francois Romieu [EMAIL PROTECTED] wrote: Arnaldo Carvalho de Melo [EMAIL PROTECTED] : [...] index 000..23058dc --- /dev/null +++ b/net/dccp/ipv6.c [...] +static void dccp_v6_ctl_send_reset(struct sk_buff *rxskb) +{ [...] + skb = alloc_skb(MAX_HEADER + sizeof(struct

[PATCH 6/6][DCCP]: Introduce dccp_ipv4_af_ops

2005-12-01 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git Best Regards, - Arnaldo tree 123eb3b4b48c74759e83249eebf9d5e0897ade9c parent c31a8d1bb087e6f7b231f00dc611bd505d96d9c6 author Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1133484923 -0200

Re: Please confirm this kernel crash using DCCP

2005-10-25 Thread Arnaldo Carvalho de Melo
On 10/25/05, Ian McDonald [EMAIL PROTECTED] wrote: I just tried replicating this but it didn't do the same for me. It did run slow due to constant resyncing like you were having also. This is a problem that we are aware of but shouldn't cause the crash. I don't claim to understand what the

Re: [BUG] Kernel crash from DCCP Fwd: TTCP crash

2005-10-17 Thread Arnaldo Carvalho de Melo
On 10/17/05, Herbert Xu [EMAIL PROTECTED] wrote: On Tue, Oct 18, 2005 at 11:01:40AM +1300, Ian McDonald wrote: [c01034ee] dump_stack+0x1e/0x30 [c0319c25] ip_options_echo+0x45/0x360 [c033a866] icmp_send+0x106/0x3d0 [c0315a8c] ipv4_link_failure+0x2c/0x60 [c0338a97]

<    1   2   3   4   5