/home/acme/git/net-2.6/net/dccp/ipv6.c:
struct ipv6_mc_socklist | -8
1 struct changed
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/net/if_inet6.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/if_inet6.h b/include/net/if_inet6
*/
/* last cacheline: 8 bytes */
};
After:
[EMAIL PROTECTED] net-2.6]$ codiff net/dccp/ipv6.o.old net/dccp/ipv6.o
/home/acme/git/net-2.6/net/dccp/ipv6.c:
struct inet6_dev | -8
1 struct changed
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/net/if_inet6.h |2 +-
1
cachelines.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/tcp.h |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/tcp.h b/include/linux/tcp.h
index 08027f1..f48644d 100644
--- a/include/linux/tcp.h
+++ b/include/linux/tcp.h
+8
dccp_ipv6_af_ops 96 104 +8
dccp_v6_request_recv_sock 15141519 +5
dccp_v6_hash 68 61 -7
dccp_v6_get_port 31 - -31
Signed-off-by: Arnaldo Carvalho
/home/acme/git/net-2.6/net/dccp/ipv6.c:
struct dccp_sock | -8
struct dccp6_sock | -8
2 structs changed
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/dccp.h b
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6
Best Regards,
- Arnaldo
include/linux/dccp.h |2 -
include/linux/tcp.h|6 ++-
include/net/if_inet6.h |4 +-
/home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c:
struct inet_timewait_sock | -8
struct tcp_timewait_sock | -8
2 structs changed
tcp_v6_rcv| -6
1 function changed, 6 bytes removed, diff: -6
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/net
Em Thu, Jan 31, 2008 at 08:57:53PM +0100, Eric Dumazet escreveu:
Arnaldo Carvalho de Melo a écrit :
/home/acme/git/net-2.6/net/ipv6/tcp_ipv6.c:
struct tcp_sock | -16
struct tcp6_sock | -16
2 structs changed
Now it is at:
/* size: 1552, cachelines: 25 */
/* paddings: 2, sum
Em Wed, Jan 09, 2008 at 12:28:27PM +, Gerrit Renker escreveu:
Roland, -
apparently, i got crashes when loading/unloading other driver modules just
after ccid2 or ccid3 had been loaded/unloaded _once_ (have not used them at
all, just modprobe module;modprobe -r module)
snip
the
Em Fri, Jan 04, 2008 at 11:25:29AM +1300, Ian McDonald escreveu:
On Jan 4, 2008 11:19 AM, Tomasz Grobelny [EMAIL PROTECTED] wrote:
I think I almost got it. Thanks a lot for the detailed explanation. But I've
got two more questions:
1. How can I control the amount of memory allowed to be
Em Wed, Jan 02, 2008 at 11:34:25PM +0100, Tomasz Grobelny escreveu:
Dnia Wednesday 02 of January 2008, Arnaldo Carvalho de Melo napisał:
Em Wed, Jan 02, 2008 at 01:41:16AM +0100, Tomasz Grobelny escreveu:
When I use dccp does sendmsg function block (until it sends the packet)?
If so
Em Sun, Dec 30, 2007 at 04:18:36PM +0100, Tomasz Grobelny escreveu:
On Friday 28 December 2007, I wrote:
Dnia Wednesday 26 of December 2007, napisałeś:
What are the panics you are getting? It might be worth posting them to
the list.
Here is the screenshot I captured a few days ago.
Em Tue, Jan 01, 2008 at 10:30:56PM +0100, Tomasz Grobelny escreveu:
Dnia Tuesday 01 of January 2008, Arnaldo Carvalho de Melo napisał:
Em Sun, Dec 30, 2007 at 04:18:36PM +0100, Tomasz Grobelny escreveu:
On Friday 28 December 2007, I wrote:
Dnia Wednesday 26 of December 2007, napisałeś
Em Wed, Jan 02, 2008 at 01:41:16AM +0100, Tomasz Grobelny escreveu:
When I use dccp does sendmsg function block (until it sends the packet)? If
so, should it? In either case, how to make it just queue the packet and
return?
The interface is the same as for other AF_INET transports, use
Em Wed, Jan 02, 2008 at 01:57:14AM +0100, Tomasz Grobelny escreveu:
Dnia Wednesday 02 of January 2008, Arnaldo Carvalho de Melo napisał:
If the kernel oopses, if the results are the same or are some problem
introduced in the patches by Gerrit. I.e. you would help us to narrow
down
Em Tue, Dec 25, 2007 at 08:23:05AM +1300, Ian McDonald escreveu:
On 12/25/07, Tomasz Grobelny [EMAIL PROTECTED] wrote:
As http://www.erg.abdn.ac.uk/ seems to be down at least since yesterday I'd
like to ask whether any mirror of dccp git tree and/or dccp patches to
mainline kernel is
Em Tue, Dec 18, 2007 at 12:41:08PM +, Gerrit Renker escreveu:
[CCID3]: Whitespace cleanups and outdated documentation
This removes outdated documentation which had been forgotten to be
removed (x_recv, rtt now appear twice, p was removed from rx_sock);
and removes new whitespace.
Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 173 +++-
1 files changed, 84 insertions(+), 89 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
net/dccp/ccids/ccid3.c | 252
+-
net/dccp/ccids/ccid3.h |8 -
net/dccp/dccp.h|6 -
3 files
[EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 11 ---
net/dccp/ccids/ccid3.h |8
2 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net
Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index b138e20..ebe59d9 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -153,12 +153,6 @@ static inline u64 max48(const u64 seq1
recent document (RFC 3448 is almost 5 years old)
* concepts in rfc3448bis arose from a real, working implementation
(cf. sec. 12)
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp
Em Fri, Dec 14, 2007 at 11:29:14AM -0800, David Miller escreveu:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Thu, 13 Dec 2007 23:41:59 -0200
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Pulled, but could you please reformat
From: Gerrit Renker [EMAIL PROTECTED]
This replaces 4 individual assignments for `len' with a single
one, placed where the control flow of those 4 leads to.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL
, where - in absence of a known RTT - the fallback value specified in
RFC 4340, 3.4 is used.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/output.c | 13 -
net/dccp
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
Documentation/networking/dccp.txt |6 +
include/linux/dccp.h | 24 ++-
net/dccp/dccp.h | 10 ++-
net/dccp/feat.c
PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h |5 +++--
net/dccp/input.c |6 +++---
net/dccp/ipv4.c |8
net/dccp/ipv6.c |8
net/dccp/options.c | 34
PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h|1 +
net/dccp/options.c | 32 ++--
net/dccp/output.c |2 +-
3 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index 3af3320
]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/minisocks.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/net/dccp/minisocks.c b/net/dccp/minisocks.c
index 831b76e..b1d5da6 100644
--- a/net/dccp/minisocks.c
+++ b/net/dccp/minisocks.c
to be resolved in
a separate patch.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/options.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/net/dccp/options.c
places and think
it
makes sense to put this into a self-contained function (dccp_enqueue()).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/input.c | 22 +++---
1
of
120 seconds it takes (as might be expected) almost twice as long, about 23
minutes.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |9 -
1 files changed, 8
PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
Documentation/networking/dccp.txt |6 ++
include/linux/dccp.h |3 +++
net/dccp/output.c |6 --
net/dccp/proto.c | 13 -
4 files changed, 25 insertions
with
'!dccp_packet_without_ack()', since Timestamp Echo can be carried on any packet
(5.8 and 13.3).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h | 16 -
net/dccp
From: Gerrit Renker [EMAIL PROTECTED]
This adds documentation for the ccid_operations structure.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccid.h | 35
Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccid.c|8
net/dccp/ccids/ccid2.c |2 +-
net/dccp/ccids/ccid3.c |2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
[EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccid.h |2 ++
net/dccp/output.c | 30 +++---
2 files changed, 25 insertions(+), 7 deletions(-)
diff --git a/net/dccp/ccid.h b/net/dccp
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
net/dccp/ccid.c|8
net/dccp/ccid.h| 37 ++---
net/dccp/ccids/ccid2.c |2 +-
tfrc_rx_hist_loss_prev() and tfrc_rx_hist_last_rcv(), which in turn
require the definition of the other inlines (macros).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/packet_history.c | 35 ---
net
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/packet_history.c | 26 --
net/dccp/ccids/lib/packet_history.h | 35 +++
2 files changed, 31 insertions(+), 30 deletions(-)
diff --git a/net/dccp/ccids/lib
of ccid3_hc_rx_sock (capitalisation) is made consistent.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |2 --
net/dccp/ccids/ccid3.h |4 ++--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/dccp
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/net/dccp/ccids/ccid3.c |2
b/net/dccp/ccids/ccid3.h |5
b/net/dccp/ccids/lib/loss_interval.c | 161 ++-
PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 72 ++--
net/dccp/ccids/ccid3.h | 10 ++--
net/dccp/ccids/lib/loss_interval.c | 18
net/dccp
From: Gerrit Renker [EMAIL PROTECTED]
A ringbuffer-based implementation of loss interval history is easier to
maintain, allocate, and update.
The `swap' routine to keep the RX history sorted is due to and was written
by Arnaldo Carvalho de Melo, simplifying an earlier macro-based variant
Em Wed, Dec 12, 2007 at 04:56:32PM +, Gerrit Renker escreveu:
| This time around I'm not doing any reordering, just trying to use your
| patches as is, but adding this patch as-is produces a kernel that will
| crash, no?
|
| The loss history and the RX/TX packet history slabs are all
Em Tue, Dec 11, 2007 at 09:42:38AM +, Gerrit Renker escreveu:
| When interfacing we must make sure that ccid3 tfrc_lh_slab is created
| and then tfrc_li_cachep is not needed. I'm doing this while keeping
| the structure of the patches, i.e. one introducing, the other removing.
| But we
Em Tue, Dec 11, 2007 at 02:21:28PM +, Gerrit Renker escreveu:
| I am new of this mailing list and I am really interested in the
| measurements you are performing with DCCP.
This was more of a regression test, as there had been recent changes in
the test tree, to see that the kernel (not
Em Mon, Dec 10, 2007 at 11:31:53AM +, Gerrit Renker escreveu:
|
|distcc[24516] ERROR: compile
/root/.ccache/packet_his.tmp.aspire.home.net.24512.i on _tiptop failed
|/usr/src/davem-2.6/net/dccp/ccids/lib/packet_history.c: In function
'__one_after_loss':
|
Em Sat, Dec 08, 2007 at 10:06:28AM +, Gerrit Renker escreveu:
This hooks up the TFRC Loss Interval database with CCID 3 packet reception.
In addition, it makes the CCID-specific computation of the first loss
interval (which requires access to all the guts of CCID3) local to ccid3.c.
The
Em Sat, Dec 08, 2007 at 10:06:21AM +, Gerrit Renker escreveu:
Just some tidy-ups to keep git/quilt happy. Also moved up the
comment Receiver routines above the first occurrence of RX
history routines.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Thanks, applied.
-
To unsubscribe from
Em Sat, Dec 08, 2007 at 10:06:22AM +, Gerrit Renker escreveu:
This separates RX/TX initialisation and puts all packet history / loss
intervals
initialisation into tfrc.c.
The organisation is uniform: slab declaration - {rx,tx}_init() -
{rx,tx}_exit()
NAK, you can't call a __exit marked
Em Sat, Dec 08, 2007 at 10:06:23AM +, Gerrit Renker escreveu:
This removes two things which now have become redundant:
1. The function tfrc_rx_hist_entry_delete() is no longer referenced anywhere.
2. The CCID3 HC-receiver still inserted timestamps, but received timestamps
are not
Em Sat, Dec 08, 2007 at 10:06:25AM +, Gerrit Renker escreveu:
This moves the inlines (which were previously declared as macros) back into
packet_history.h since
the loss detection code needs to be able to read entries from the RX history
in order to create the
relevant loss entries: it
From: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/packet_history.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/net/dccp/ccids/lib/packet_history.c
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/net/dccp/ccids/ccid3.c | 16
b/net/dccp/ccids/lib/loss_interval.c |2 +-
b/net/dccp/ccids/lib/packet_history.c | 13
Em Thu, Dec 06, 2007 at 02:02:25PM +, Gerrit Renker escreveu:
| The first six patches in this series are unmodified, so if you
| are OK with them please send me your Signed-off-by.
Patches [1/7], [2/7], and [6/7] already have a signed-off and there are
no changes. Just acknowledged
From: Gerrit Renker [EMAIL PROTECTED]
Only the sender sets window counters [RFC 4342, sections 5 and 8.1].
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |1
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 35 ++---
net/dccp/ccids/lib/packet_history.c | 95
[EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 288 --
net/dccp/ccids/ccid3.h | 14 +-
net/dccp/ccids/lib/loss_interval.c | 13 ++-
net/dccp/ccids/lib/packet_history.c | 290
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/net/dccp/ccids/Kconfig | 13
b/net/dccp/ccids/ccid3.c | 35 --
b/net/dccp/ccids/ccid3.h | 14
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/lib/packet_history.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/net/dccp/ccids/lib/packet_history.c
b/net/dccp/ccids/lib
: renamed tfrc_module.c to tfrc.c, and made CONFIG_IP_DCCP_CCID3
select IP_DCCP_TFRC_LIB.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/Kconfig | 13 ++---
net
Em Wed, Dec 05, 2007 at 09:35:30AM +, Gerrit Renker escreveu:
Quoting Arnaldo:
| Em Tue, Dec 04, 2007 at 06:55:17AM +, Gerrit Renker escreveu:
| NAK. You have changed the control flow of the algorithm and the underlying
| data structure. Originally it had been an array of pointers,
Em Wed, Dec 05, 2007 at 02:53:09PM +, Gerrit Renker escreveu:
| Thanks, I folded this into the reorganized RX history handling patch,
| together with reverting ccid3_hc_rx_packet_recv to very close to your
| original patch, with this changes:
|
| 1. no need to calculate the payload size
Em Wed, Dec 05, 2007 at 01:55:11PM +, Gerrit Renker escreveu:
| @@ -788,8 +782,8 @@ static void ccid3_hc_rx_packet_recv(stru
|if (unlikely(hcrx-ccid3hcrx_state == TFRC_RSTATE_NO_DATA)) {
|if (is_data_packet) {
|do_feedback = FBACK_INITIAL;
| +
Em Wed, Dec 05, 2007 at 11:19:44AM +, Gerrit Renker escreveu:
This revision fixes a bug present in the per-socket allocation of RX history
entries; identification of this bug is thanks to Arnaldo Carvalho de Melo.
The bug was in not deallocating history entries when the allocation
Em Wed, Dec 05, 2007 at 11:19:45AM +, Gerrit Renker escreveu:
This fixes a problem in the initial revision of the patch: The loss interval
history was not de-allocated when the initialisation of the packet history
failed. The identification of this problem is also thanks due to Arnaldo.
Note: removed Ingo from the CC list, I had added it first just because
he advocated reducing the number of mailing lists, so I wanted him to
know that we're trying to do that.
Em Wed, Dec 05, 2007 at 10:27:36AM +, Gerrit Renker escreveu:
Today being Wednesday, below is some feedback after
Em Wed, Dec 05, 2007 at 11:19:46AM +, Gerrit Renker escreveu:
This patch removes the following redundancies:
* ccid3_hc_rx_update_s() is only called for data packets (that is what it
should be called for);
* each call to ccid3_hc_rx_update_s() is wrapped inside a if
(is_data_packet)
Em Mon, Dec 03, 2007 at 08:35:12AM +, Gerrit Renker escreveu:
Hi Arnaldo,
hank you for going through this. I have just backported your recent patches
of 2.6.25
to the DCCP/CCID4/Faster Restart test tree at
git://eden-feed.erg.abdn.ac.uk/dccp_exp {dccp,ccid4,dccp_fr}
as per
Em Mon, Dec 03, 2007 at 01:49:47PM +, Gerrit Renker escreveu:
| Are you suggesting using netdev exclusively or in addition to [EMAIL
PROTECTED]
|
| Well, since at least one person that has contributed significantly in
| the past has said he can't cope with traffic on netdev, we can CC
From: Gerrit Renker [EMAIL PROTECTED]
Only the sender sets window counters [RFC 4342, sections 5 and 8.1].
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |1
: renamed tfrc_module.c to tfrc.c, and made CONFIG_IP_DCCP_CCID3
select IP_DCCP_TFRC_LIB.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/Kconfig | 13 ++---
net
From: Gerrit Renker [EMAIL PROTECTED]
as per RFC 4340, sec. 7.7.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h | 12
1 files changed, 12 insertions(+), 0
This is in preparation for merging the new rx history code written by Gerrit
Renker.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 32 ++--
net/dccp/ccids/lib/loss_interval.c | 14 +++---
net/dccp/ccids/lib/packet_history.c
Em Fri, Nov 30, 2007 at 12:19:36PM +, Gerrit Renker escreveu:
Sorry I only got this email today and it is a busy day, too.
The changes look good and are in general a further improvement on the
code. I like the idea of hiding the internals of the list structure in
the source file.
I
Hi Gerrit,
Coming back to hiding the TX history data structures, take a
look at what I'm commiting to my tree:
1. struct tfrc_tx_hist_entry is completely hidden in
net/dccp/ccids/lib/packet_history.c
2. I found tfrc_tx_hist_when confusing and returning two results, if it
had found
Hi Herbert,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Thanks a lot!
- Arnaldo
commit f1ff09e7955a2cffa3dfdda8a63a1ce991f11a7b
Author: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Thu Nov 29 22:47:15 2007 -0200
[TFRC
Em Wed, Nov 28, 2007 at 08:35:08AM +, Gerrit Renker escreveu:
[DCCP]: Use AF-independent rebuild_header routine
This fixes a nasty bug: dccp_send_reset() is called by both DCCPv4 and
DCCPv6, but uses
inet_sk_rebuild_header() in each case. This leads to unpredictable and weird
Em Wed, Nov 28, 2007 at 08:35:11AM +, Gerrit Renker escreveu:
[DCCP]: Remove duplicate test for CloseReq
This removes a redundant test for unexpected packet types. In
dccp_rcv_state_process
it is tested twice whether a DCCP-server has received a CloseReq (Step 7):
* first in the
Em Wed, Nov 28, 2007 at 08:35:10AM +, Gerrit Renker escreveu:
[DCCP]: Integrate state transitions for passive-close
This adds the necessary state transitions for the two forms of passive-close
* PASSIVE_CLOSE- which is entered when a host receives a Close;
* PASSIVE_CLOSEREQ -
Em Wed, Nov 28, 2007 at 08:35:09AM +, Gerrit Renker escreveu:
[DCCP]: Dedicated auxiliary states to support passive-close
This adds two auxiliary states to deal with passive closes:
* PASSIVE_CLOSE(reached from OPEN via reception of Close)and
* PASSIVE_CLOSEREQ (reached from
the dccp_tfrc_lib module
init routine is called.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 57 --
net/dccp/ccids/ccid3.h |3 +-
net/dccp/ccids/lib/loss_interval.c | 12 ++--
net/dccp/ccids/lib/packet_history.c
indicates it is unusable.
Last, dccp_finish_passive_close sets either DCCP_CLOSED or DCCP_CLOSING =
TCP_CLOSING, so that
sk_stream_wait_close() will wait for the final Reset (which will trigger
CLOSING = CLOSED).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de
[EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h | 56 ++---
net/dccp/proto.c | 22 ++-
2 files changed, 51 insertions(+), 27 deletions(-)
diff --git a/include/linux/dccp.h b
Resets were sent, in other not.
The fix is to use the AF-independent rebuild_header routine.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/output.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net
Hi Herbert,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.25
Best Regards,
- Arnaldo
b/include/linux/dccp.h| 56 +
b/net/dccp/ccids/ccid3.c | 57 --
b/net/dccp/ccids/ccid3.h
is necesssary since dccp_rcv_closereq() is also called from
__dccp_rcv_established().
This patch removes the duplicate test.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/input.c |6 ++
1 files changed, 2 insertions
,
due to RFC 4340, 11.3) has been added.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c |9 +
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/net
From: Gerrit Renker [EMAIL PROTECTED]
This replaces use of normal subtraction with modulo-48 subtraction.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c |9
.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c
This is because in the next patch CCID2 will assume that dccps_mss_cache is
non-zero.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/proto.c | 25 +
1 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/net/dccp/proto.c b/net/dccp
PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c | 20 +++-
1 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c
index ef19fb8..9c5b6c7 100644
--- a/net/dccp/ccids/ccid2.c
will not necessarily use the same variables
as used by
the unfinished one; hence the old variables have been removed.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c | 23
From: Gerrit Renker [EMAIL PROTECTED]
This replaces the field member `numdupack', which was used as a read-only
constant in the code, with a #define.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL
.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/proto.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index
, a BUG_ON test for negative values now becomes obsolete (for safety
not removed,
but replaced with a less annoying `DCCP_BUG').
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2
-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/proto.c | 15 +--
1 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index
From: Gerrit Renker [EMAIL PROTECTED]
This removes a variable `ccid2hctx_sent' which is incremented but
never referenced/read (i.e., dead code).
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ackvec.c | 163 +
net/dccp/ackvec.h | 62 ++--
2 files changed, 108 insertions(+), 117 deletions(-)
diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c
index 83378f3
1 - 100 of 422 matches
Mail list logo
