Re: [deal.II] Small bug in ConstraintMatrix::add_entries () ?!

2018-08-23 Thread Dustin Kumor
Daniel, thanks for the hint. I will have a look at this on the weekend. Best, Dustin Am Donnerstag, 23. August 2018 13:45:41 UTC+2 schrieb Daniel Arndt: > > Dustin, > > I can put that into a pull request but I've never done this before so I'm >> going to need someone guiding me through the

Re: [deal.II] Small bug in ConstraintMatrix::add_entries () ?!

2018-08-23 Thread Daniel Arndt
Dustin, I can put that into a pull request but I've never done this before so I'm > going to need someone guiding me through the whole process. > Same for the test writing issue. > Have a look at https://github.com/dealii/dealii/wiki/Contributing and don't hesitate to ask if you have questions.

Re: [deal.II] Small bug in ConstraintMatrix::add_entries () ?!

2018-08-23 Thread Dustin Kumor
Dear Wolfgang I can put that into a pull request but I've never done this before so I'm going to need someone guiding me through the whole process. Same for the test writing issue. Best regards Dustin Am Mittwoch, 22. August 2018 23:25:11 UTC+2 schrieb Wolfgang Bangerth: > > > Dustin, > good

Re: [deal.II] Small bug in ConstraintMatrix::add_entries () ?!

2018-08-22 Thread Wolfgang Bangerth
Dustin, good observation. I think you have found a bug indeed. I've put this here for now: https://github.com/dealii/dealii/issues/7101 Your fix seems reasonable to me. Do you want to put that into a pull request? Let us know if you need help with that (and with writing a test). (For

[deal.II] Small bug in ConstraintMatrix::add_entries () ?!

2018-08-22 Thread Dustin Kumor
Dear all, in my opinion there is a small bug in the implementation of the ConstraintMatrix member function add_entries in file constraint_matrix.cc (release Version 9.0, lines 224-261). The current piece of code is: 224 void 225 ConstraintMatrix::add_entries 226 (const size_type