Re: [deal.II] issues with manifold id (at least in codim-1) revealed by PR 7775

2019-03-19 Thread Wolfgang Bangerth
On 3/19/19 4:17 AM, luca.heltai wrote: > what would you think of a function in GridTools like > > GridTools::propagate_internal_manifold_ids(tria, disambiguation_function) > > that would loop over all cells, loop over all faces, check if the neighbor > manifold id is the same of this cell, and

Re: [deal.II] issues with manifold id (at least in codim-1) revealed by PR 7775

2019-03-19 Thread luca.heltai
Nicola, what would you think of a function in GridTools like GridTools::propagate_internal_manifold_ids(tria, disambiguation_function) that would loop over all cells, loop over all faces, check if the neighbor manifold id is the same of this cell, and i) the two ids are the same: assign the

Re: [deal.II] issues with manifold id (at least in codim-1) revealed by PR 7775

2019-03-15 Thread Nicola Giuliani
I agree that the choice is ambiguous on the faces. However a practical problem remains, let's assume that a user wants to import a very big geometry with a lot of internal faces. Right now he would need to specify all the possible faces in the input file (with an increasing possibility of

Re: [deal.II] issues with manifold id (at least in codim-1) revealed by PR 7775

2019-03-13 Thread luca.heltai
I believe the first point is a bug of the read_ucd function. I opened an issue for this (https://github.com/dealii/dealii/issues/7802) The second point, however, is a feature. What should you do when two material ids meet? I think it is the responsability of the user to make sure that the

[deal.II] issues with manifold id (at least in codim-1) revealed by PR 7775

2019-03-08 Thread Nicola Giuliani
Dear all, PR 7775 has revealed some critical issues in the handling of manifold_id in codim-1 domain. -) I believe that GridIn.read_ucd appears to ignore manifold ids associated to the cells, it seems to me that the flag apply_all_indicators_to_manifold_ids does not affect the manifold id for