Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Wolfgang Schweer writes: > Sure, but see above. I'm pretty sure once the Packages list has been > dropped, re-adding Recommends: tfptd-hpa | atftpd to tasks/main-server > would do no harm. I am (also after reading tasksel's README) ready to drop the explicit packages list. However, there was probably an (undocumented) reason why it is there for udebs -- I just took this over from the Perl script, and I guess that from the blends debian-edu is the main/only use of udebs. I'll do that tomorrow, unless someone complains. Cheers Ole
Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
On Thu, Jul 12, 2018 at 12:09:24PM +0200, Ole Streicher wrote: > far as I looked into, the test calles > > /usr/share/debian-edu-config/tools/debian-edu-bless > > and this script seems to be unable to handle alternatives. The script 'debian-edu-bless' uses tasksel to install packages, so debian-edu-tasks.desc is involved as well: Both the meta-package listed as Key and all packages in the Packages list are installed. The meta-package handles alternatives as usual (these are taken from the tasks file as is). Only if _all_ alternatives are installed because they belong to the Packages list and if there are conflicting ones among them, the installation breaks. We decided to drop the conflicting atftpd package to get feedback if the installation would be successful. > IMO it would not be a good solution to just limit the packages to the > first alternative, since that would break the idea of alternatives. Sure, but see above. I'm pretty sure once the Packages list has been dropped, re-adding Recommends: tfptd-hpa | atftpd to tasks/main-server would do no harm. Thanks for taking your time, Wolfgang signature.asc Description: PGP signature
Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Wolfgang Schweer writes: > On Thu, Jul 12, 2018 at 08:45:46AM +0200, Ole Streicher wrote: >> Wolfgang Schweer writes: >> > Generated with blends-dev 0.7.1 the list contains tftpd-hpa as well. As >> > both packages conflict, the installation breaks, see: >> > https://ci.debian.net/data/autopkgtest/testing/amd64/d/debian-edu/591122/log.gz >> >> This also may be a bug in the handling of the "Packages" field during >> udeb installation, which was just not exposed until now. > > I guess the only problem has been that both conflicting alternatives > showed up in the 'Packages: list'. > With atftpd removed from tasks/main-server, things are ok again, see: > https://ci.debian.net/packages/d/debian-edu/testing/amd64/ > > This removal has been the only change between versions 2.30 and 2.31, > see: https://salsa.debian.org/debian-edu/debian-edu/commits/master Are you sure that this is not a bug in the Debian Edu environment? As far as I looked into, the test calles /usr/share/debian-edu-config/tools/debian-edu-bless and this script seems to be unable to handle alternatives. IMO it would not be a good solution to just limit the packages to the first alternative, since that would break the idea of alternatives. Cheers Ole
Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
On Thu, Jul 12, 2018 at 08:45:46AM +0200, Ole Streicher wrote: > Wolfgang Schweer writes: > > Generated with blends-dev 0.7.1 the list contains tftpd-hpa as well. As > > both packages conflict, the installation breaks, see: > > https://ci.debian.net/data/autopkgtest/testing/amd64/d/debian-edu/591122/log.gz > > > > This also may be a bug in the handling of the "Packages" field during > udeb installation, which was just not exposed until now. I guess the only problem has been that both conflicting alternatives showed up in the 'Packages: list'. With atftpd removed from tasks/main-server, things are ok again, see: https://ci.debian.net/packages/d/debian-edu/testing/amd64/ This removal has been the only change between versions 2.30 and 2.31, see: https://salsa.debian.org/debian-edu/debian-edu/commits/master Wolfgang signature.asc Description: PGP signature
Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Wolfgang Schweer writes: > On Wed, Jul 11, 2018 at 09:41:05PM +0200, Ole Streicher wrote: >> However, I am not sure about the required format to udeb .desc files. As >> you describe it, the situation is: >> >> * the Package: field is not needed for udebs >> * but if it is there and contains alternatives, the installation breaks. >> >> Do I understand you correctly? > > Yes, if there are conflicting packages among the listed alternatives. > But please note that I am no expert. OK, so I will wait a day for other comments. If nobody else complains, I will merge your proposal and upload a new version. > Generated with blends-dev 0.6.100, debian-edu-tasks.desc had the > 'Packages: list' with only one package of alternatives, the first one. > Example: tasks/main-server with Recommends: atftpd | tftpd-hpa ended up > in debian-edu-tasks.desc with only atftpd listed below 'Packages: list'. > Generated with blends-dev 0.7.1 the list contains tftpd-hpa as well. As > both packages conflict, the installation breaks, see: > https://ci.debian.net/data/autopkgtest/testing/amd64/d/debian-edu/591122/log.gz > This also may be a bug in the handling of the "Packages" field during udeb installation, which was just not exposed until now. Cheers Ole
Re: Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Hi Ole, On Wed, Jul 11, 2018 at 09:41:05PM +0200, Ole Streicher wrote: > However, I am not sure about the required format to udeb .desc files. As > you describe it, the situation is: > > * the Package: field is not needed for udebs > * but if it is there and contains alternatives, the installation breaks. > > Do I understand you correctly? Yes, if there are conflicting packages among the listed alternatives. But please note that I am no expert. To my understandig (after reading /usr/share/doc/tasksel/README.gz) all packages listed below 'Packages: list' are installed plus the packages pulled in via the meta-package in the Key: field. So the Key: field seems to be enough. If you take a look at /usr/share/tasksel/descs/debian-tasks.desc it's only Key: fields. Generated with blends-dev 0.6.100, debian-edu-tasks.desc had the 'Packages: list' with only one package of alternatives, the first one. Example: tasks/main-server with Recommends: atftpd | tftpd-hpa ended up in debian-edu-tasks.desc with only atftpd listed below 'Packages: list'. Generated with blends-dev 0.7.1 the list contains tftpd-hpa as well. As both packages conflict, the installation breaks, see: https://ci.debian.net/data/autopkgtest/testing/amd64/d/debian-edu/591122/log.gz (search for the 4th occurence of 'command2'). Thanks for caring, Wolfgang signature.asc Description: PGP signature
Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Ho Wolfgang, On 11.07.2018 18:40, Wolfgang Schweer wrote: > The Packages: list now contains all alternative packages instead of only > the first one, e.g. tftpd-hpa | atftpd lists both packages which breaks > installation. I guess the fix for #785678 caused this. > > The Packages: field doesn't seem to be needed for a valid desc file. > Please consider to think about the alternatives again or maybe apply > this change: I would prefer to apply your change; mainly because it removes the special handling of udebs in one place (and fewer special cases is always better). However, I am not sure about the required format to udeb .desc files. As you describe it, the situation is: * the Package: field is not needed for udebs * but if it is there and contains alternatives, the installation breaks. Do I understand you correctly? Best Ole
Bug#903593: python3-blends: shouldn't write Packages: list in case the udeb option is set
Package: python3-blends
Version: 0.7.1
Severity: wishlist
Hi,
while testing Debian Edu I noticed that installations fail due to
an incorrect debian-edu-tasks.desc file.
The Packages: list now contains all alternative packages instead of only
the first one, e.g. tftpd-hpa | atftpd lists both packages which breaks
installation. I guess the fix for #785678 caused this.
The Packages: field doesn't seem to be needed for a valid desc file.
Please consider to think about the alternatives again or maybe apply
this change:
--- a/blends.py 2018-07-11 18:05:17.147774296 +0200
+++ b/blends.py 2018-07-11 18:04:46.795867954 +0200
@@ -438,10 +438,6 @@
for key, value in self.tests.items():
d['Test-' + key] = value
d['Key'] = '\n {}'.format(self.package_name)
-if udeb:
-d['Packages'] = 'list\n ' + \
- '\n '.join(sorted(d.name for d in itertools.chain(
- *(self.recommends + self.dependencies
return d
def update(self, cache):
Wolfgang
signature.asc
Description: PGP signature
