Jérémy Bobbio [EMAIL PROTECTED] writes:
The work on this got little bit out of hand as I fixed all issues along
the way, and I am a little bit uncomfortable in introducing so much
changes at this stage of the release process.
I believe you both are doing very well regarting this patchset and
Hi,
If there are no more comments on this patch, what's the next step ? I'll be
off in vacation from tomorrow for next week and won't be able to read my
mails, so if something must be done to integrate it in Lenny someone else
will have to take care of this.
If what's missing is the
Hi,
Here are the patches concerning the functional changes. I also modified the
error strings to follow Christian Perrier's advices. Please note that this
patch adds a new string, Multiple disks, that should be translated.
Cheers,
Grégory
diff -ruN --exclude=.svn --exclude=debian
On Sat, Aug 02, 2008 at 11:14:48AM +0200, Grégory Oestreicher wrote:
Le samedi 02 août 2008 01:21, Jérémy Bobbio a écrit :
NACK for get_disk_infos(). This name does not reflect at all what the
function does, as far as I understand it.
It puts in global scope some attributes about the last
Le dimanche 03 août 2008 09:06, Jérémy Bobbio a écrit :
It puts in global scope some attributes about the last free partition
found on the disk. So what about get_last_free_partition_infos() ?
A lot more meaningful, indeed. :)
Here is an updated patch for the refactoring part, which also
On Thu, Jul 31, 2008 at 10:31:11PM +0200, Grégory Oestreicher wrote:
Le mercredi 30 juillet 2008 01:48, Jérémy Bobbio a écrit :
Some minor refactoring was needed when writing the code, so why not doing
it while it's still hot ? However I can submit two separate patches if
it's clearer.
Le samedi 02 août 2008 01:21, Jérémy Bobbio a écrit :
NACK for get_disk_infos(). This name does not reflect at all what the
function does, as far as I understand it.
It puts in global scope some attributes about the last free partition found on
the disk. So what about
We need to create the envelope only if one is not defined. This is the case
when :
- the default device is not part of a PV declaration in the scheme (a PV
is declared when there's a method{ lvm } or method{ crypto }
attribute).
- the recipe contains a PV declaration
Le mercredi 30 juillet 2008 01:48, Jérémy Bobbio a écrit :
Some minor refactoring was needed when writing the code, so why not doing
it while it's still hot ? However I can submit two separate patches if
it's clearer.
I'm already asking quite some work, but if you have the energy, it would
Grégory Oestreicher [EMAIL PROTECTED] writes:
Le mercredi 30 juillet 2008 01:48, Jérémy Bobbio a écrit :
Some minor refactoring was needed when writing the code, so why not doing
it while it's still hot ? However I can submit two separate patches if
it's clearer.
I'm already asking quite
Le mardi 29 juillet 2008 02:18, Jérémy Bobbio a écrit :
+# This function was copied from another file
(partman-auto/lib/initial_auto). +# Maybe it should be useful to put it
in auto-shared.sh or in base.sh +dev_to_partman () {
[…]
It is already in partman-auto-raid, so I think it should
On Tue, Jul 29, 2008 at 07:42:26PM +0200, Grégory Oestreicher wrote:
Le mardi 29 juillet 2008 02:18, Jérémy Bobbio a écrit :
+# This function was copied from another file
(partman-auto/lib/initial_auto). +# Maybe it should be useful to put it
in auto-shared.sh or in base.sh
Hi,
Here is an updated version of the patch, dealing with LVM+crypto, as
suggested by Jérémy Bobbio. This patch also incorporate his modifications
to add the possibility to define a custom LV name (see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=484272).
This patch have been tested in the
Damn, once again there are some remains from my tests... Please disregard
the file partman-auto-lvm-multiple-disks-20080728.diff from my previous
message. Here is the clean one.
Cheers,
GrégoryIndex: debian/partman-auto-lvm.templates
On Mon, Jul 28, 2008 at 06:54:12PM +0200, Grégory Oestreicher wrote:
Here is an updated version of the patch, dealing with LVM+crypto, as
suggested by Jérémy Bobbio. This patch also incorporate his modifications
to add the possibility to define a custom LV name (see
Hi,
+++ b/packages/partman/partman-auto-lvm/lib/auto-lvm.sh
[...]
-+ if [ -d $tmpdevdir ]; then
++ if [ -d $tmpdevdir ]; then
++ echo $tmpdevdir /tmp/lvtest
What is the purpose of this last line? Or is that just
Hi,
On Tuesday 19 February 2008, Grégory Oestreicher wrote:
Le jeudi 24 janvier 2008 16:49, Frans Pop a écrit :
Attaching patch and especially the example recipes to ensure they
remain available. Recipes will be useful as documentation.
Here is an updated patch that correct a bug when
On Thursday 20 March 2008, Grégory Oestreicher wrote:
My bad, it is indeed a remain from the debugging of this script. I will
generate a new diff file tonight (UTC+1 here) and attach it to the bug.
Not needed. I'll just remove that line from the patch.
Thanks for the quick reply.
Cheers,
FJP
Le jeudi 24 janvier 2008 16:49, Frans Pop a écrit :
Attaching patch and especially the example recipes to ensure they remain
available. Recipes will be useful as documentation.
Here is an updated patch that correct a bug when
partman-auto-lvm/extra_devices is preseeded but none of them exist.
Package: partman-auto-lvm
Version: 26
Severity: wishlist
Hi,
I finally managed to write a more general patch[1] to have multiple disks
support in partman-auto-lvm. It has been successfully tested on x86 with
the three base recipes of the installer (atomic, home and multi) to
prevent
On Thursday 24 January 2008, Grégory Oestreicher wrote:
I finally managed to write a more general patch[1] to have multiple disks
support in partman-auto-lvm.
Attaching patch and especially the example recipes to ensure they remain
available. Recipes will be useful as documentation.
Index:
21 matches
Mail list logo
