Re: [PATCHv3] Make syslinux beep

2008-08-22 Thread Otavio Salvador
Samuel Thibault [EMAIL PROTECTED] writes: Oh, I wasn't expecting to commit it myself, but why not. Yes, it is sthibaul-guest. Please do the commit. Remember to add a note on the changelog about your changes and please cite that this is going to be used just when doing the release and that it

Re: [PATCHv3] Make syslinux beep

2008-08-20 Thread Otavio Salvador
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Samuel Thibault [EMAIL PROTECTED] writes: Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit : Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit : Better to just use 0/1 as values and only test for '= 1' (or test for set/unset, not

Re: [PATCHv3] Make syslinux beep

2008-08-20 Thread Samuel Thibault
Otavio Salvador, le Wed 20 Aug 2008 15:40:09 -0300, a écrit : Samuel Thibault [EMAIL PROTECTED] writes: Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit : Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit : Better to just use 0/1 as values and only test for '= 1' (or test

Re: [PATCHv3] Make syslinux beep

2008-08-19 Thread Samuel Thibault
Samuel Thibault, le Wed 13 Aug 2008 01:39:31 +0100, a écrit : Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit : Better to just use 0/1 as values and only test for '= 1' (or test for set/unset, not sure what is more common). At least DEBUG uses y/n, so I have done the same in the

Re: Make syslinux beep?

2008-08-12 Thread Frans Pop
On Tuesday 12 August 2008, Samuel Thibault wrote: Here is a patch. I didn't know how I should detect the kind of build, I just made it look at the udebs source. I don't think it's smart to use USE_UDEBS_FROM here. Better use a dedicated variable. Also, please use '[ test ] [ test ]' instead

Re: Make syslinux beep?

2008-08-12 Thread Samuel Thibault
Frans Pop, le Tue 12 Aug 2008 10:29:23 +0200, a écrit : On Tuesday 12 August 2008, Samuel Thibault wrote: Here is a patch. I didn't know how I should detect the kind of build, I just made it look at the udebs source. I don't think it's smart to use USE_UDEBS_FROM here. Better use a

Re: Make syslinux beep?

2008-08-12 Thread Otavio Salvador
Samuel Thibault [EMAIL PROTECTED] writes: Otavio Salvador, le Mon 11 Aug 2008 22:06:50 -0300, a écrit : Samuel Thibault [EMAIL PROTECTED] writes: Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit : Still no feedback on this? (I mean feedback from debian-boot, I got some from

Re: Make syslinux beep?

2008-08-12 Thread Otavio Salvador
Samuel Thibault [EMAIL PROTECTED] writes: Also, please use '[ test ] [ test ]' instead of '[ test -a test ]'. I'm curious: why? Coding Style. -- O T A V I OS A L V A D O R - E-mail: [EMAIL PROTECTED] UIN: 5906116 GNU/Linux

Re: Make syslinux beep?

2008-08-12 Thread Otavio Salvador
Otavio Salvador [EMAIL PROTECTED] writes: From my POV it looks good. Let's wait few days to see if someone nack it or something, otherwise I'll commit it in the end of week. Samuel, Please address both points spoted by Frans and resubmit it. Thanks a lot. -- O T A V I OS A L V

Re: Make syslinux beep?

2008-08-12 Thread Frank Carmickle
On Tue, Aug 12, Samuel Thibault wrote: Snip. Also, please use '[ test ] [ test ]' instead of '[ test -a test ]'. I'm curious: why? To bash specific. Have a look at the dash man page. --Frank -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact

[PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Hello, Here is an corrected patch Samuel Index: build/config/x86.cfg === --- build/config/x86.cfg(révision 54981) +++ build/config/x86.cfg(copie de travail) @@ -60,6 +60,11 @@

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Frans Pop
On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to me. Only wonder if it would not make more sense to rename the variable to BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be confused with the D-I main menu. signature.asc Description:

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Frans Pop, le Wed 13 Aug 2008 00:51:29 +0200, a écrit : On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to me. Only wonder if it would not make more sense to rename the variable to BOOT_BEEP or BEEP_ON_BOOT or SYSLINUX_BEEP. MENU could easily be

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Per Andersson
On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop [EMAIL PROTECTED] wrote: On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to me. Shouldn't there be a left bracket after the ? (It's missing in several places.) if [ $$outfile == menu.cfg ] $$MENU_BEEP ];

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Frans Pop
On Wednesday 13 August 2008, Per Andersson wrote: On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop [EMAIL PROTECTED] wrote: On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to me. Shouldn't there be a left bracket after the ? (It's missing in several

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit : On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop [EMAIL PROTECTED] wrote: On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to me. Shouldn't there be a left bracket after the ? (It's missing

Re: [PATCHv2] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Samuel Thibault, le Wed 13 Aug 2008 00:54:15 +0100, a écrit : Per Andersson, le Wed 13 Aug 2008 01:31:37 +0200, a écrit : On Wed, Aug 13, 2008 at 12:51 AM, Frans Pop [EMAIL PROTECTED] wrote: On Tuesday 12 August 2008, Samuel Thibault wrote: Here is an corrected patch Looks fine to

[PATCHv3] Make syslinux beep

2008-08-12 Thread Samuel Thibault
Frans Pop, le Wed 13 Aug 2008 02:05:45 +0200, a écrit : Better to just use 0/1 as values and only test for '= 1' (or test for set/unset, not sure what is more common). At least DEBUG uses y/n, so I have done the same in the attached fixed patch. Samuel Index: build/config/x86.cfg

Re: Make syslinux beep?

2008-08-11 Thread Samuel Thibault
Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit : Still no feedback on this? (I mean feedback from debian-boot, I got some from debian-accessibility, the feature was greatly appreciated). Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble?

Re: Make syslinux beep?

2008-08-11 Thread Samuel Thibault
Hello, Still no feedback on this? Samuel Thibault, le Sun 20 Jul 2008 15:47:18 +0100, a écrit : Otavio Salvador, le Thu 17 Jul 2008 20:33:36 -0300, a écrit : Frans Pop [EMAIL PROTECTED] writes: On Thursday 17 July 2008, Samuel Thibault wrote: I do agree it is annoying, but as Sebastien

Re: Make syslinux beep?

2008-08-11 Thread Otavio Salvador
Samuel Thibault [EMAIL PROTECTED] writes: Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit : Still no feedback on this? (I mean feedback from debian-boot, I got some from debian-accessibility, the feature was greatly appreciated). It would be acceptable for release images. Could

Re: Make syslinux beep?

2008-08-11 Thread Samuel Thibault
Otavio Salvador, le Mon 11 Aug 2008 22:06:50 -0300, a écrit : Samuel Thibault [EMAIL PROTECTED] writes: Samuel Thibault, le Tue 12 Aug 2008 00:10:26 +0100, a écrit : Still no feedback on this? (I mean feedback from debian-boot, I got some from debian-accessibility, the feature was

Re: Make syslinux beep?

2008-07-20 Thread Samuel Thibault
Otavio Salvador, le Thu 17 Jul 2008 20:33:36 -0300, a écrit : Frans Pop [EMAIL PROTECTED] writes: (No need to CC me On Thursday 17 July 2008, Samuel Thibault wrote: I do agree it is annoying, but as Sebastien said, it's just about installation. I've asked a few people, they said they

Re: Make syslinux beep?

2008-07-20 Thread Samuel Thibault
Stephen Frazier, le Sat 19 Jul 2008 23:11:36 -0500, a écrit : I know that other people with a different set up may not like the beeps. So, why not make it an option. An option at debian-installer build time you mean? If there was a way to pass an option dont beep to an already existing boot

Re: Make syslinux beep?

2008-07-19 Thread Stephen Frazier
I am not blind, but I would like the installer to beep each time it needs input. The monitor that is used when I am installing Debian is located left of the monitor I normally use just outside my sight. When I am trying to do other work during an install I would like the beep to tell me to look

Re: Make syslinux beep?

2008-07-17 Thread Sébastien Hinderer
Hi, IIRC correctly it has been discussed before and was rejected as to annoying for the normal case. I must say I agree with that. And I do also. However, I'd like to ask the folloing question: assuming that this may be of some help for others, would such an annoyance really be unacceptable ?

Re: Make syslinux beep?

2008-07-17 Thread Samuel Thibault
Frans Pop, le Thu 17 Jul 2008 07:15:38 +0200, a écrit : On Thursday 17 July 2008, Samuel Thibault wrote: Samuel Thibault, le Thu 19 Jun 2008 11:08:32 +0100, a écrit : It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be helpful

Re: Make syslinux beep?

2008-07-17 Thread Frans Pop
(No need to CC me On Thursday 17 July 2008, Samuel Thibault wrote: I do agree it is annoying, but as Sebastien said, it's just about installation. I've asked a few people, they said they wouldn't complain if it could help others. It's annoying for me amongst others. I do huge numbers of

Re: Make syslinux beep?

2008-07-17 Thread Daniel Dalton
On Thu, Jul 17, 2008 at 07:15:38AM +0200, Frans Pop wrote: On Thursday 17 July 2008, Samuel Thibault wrote: Samuel Thibault, le Thu 19 Jun 2008 11:08:32 +0100, a écrit : It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be

Re: Make syslinux beep?

2008-07-17 Thread Samuel Thibault
Daniel Dalton, le Thu 17 Jul 2008 20:22:52 +1000, a écrit : But, the beep would solve this. I know it wouldn't help on a laptop, but still. Why wouldn't it help on a laptop? If there is no internal speaker maybe you could use headphone? Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED]

Re: Make syslinux beep?

2008-07-17 Thread Samuel Thibault
Frans Pop, le Thu 17 Jul 2008 12:32:39 +0200, a écrit : I could see myself agreeing if you can come up with an implementation that only includes the beep for official builds (i.e. the addition of the beep is triggered by something in debian/rules). That should be feasible, so I guess that's

Re: Make syslinux beep?

2008-07-17 Thread Daniel Dalton
On Thu, Jul 17, 2008 at 11:34:49AM +0100, Samuel Thibault wrote: Daniel Dalton, le Thu 17 Jul 2008 20:22:52 +1000, a écrit : But, the beep would solve this. I know it wouldn't help on a laptop, but still. Why wouldn't it help on a laptop? No console tone generator (pc speaker)? If there

Re: Make syslinux beep?

2008-07-17 Thread Daniel Dalton
On Thu, Jul 17, 2008 at 12:32:00PM +0200, Christian Schoepplein wrote: For example a beep is generated everytime gdm gets started during the bootup of a machine. I do not know anyone who would complain of that Very good point, so why isn't that annoying? So surely gdm logins would be ran

Re: Make syslinux beep?

2008-07-17 Thread Frans Pop
On Thursday 17 July 2008, Daniel Dalton wrote: On Thu, Jul 17, 2008 at 12:32:00PM +0200, Christian Schoepplein wrote: For example a beep is generated everytime gdm gets started during the bootup of a machine. I do not know anyone who would complain of that Very good point, so why isn't that

Re: Make syslinux beep?

2008-07-17 Thread Frans Pop
On Thursday 17 July 2008, Frans Pop wrote: I'm sorry folks, I have a lot of respect for the extra effort needed every day to deal with life if you have a disability (of whatever form), but you cannot expect the world to always change things to fit your needs. Note that everything in my last

Re: Make syslinux beep?

2008-07-17 Thread Jérémy Bobbio
Hi! As someone that can sometimes start the installer more than 30 times a day (which is a lot more often than one usually hears the deadred GDM beep), I would strongly prefer to avoid a starting beep. Starting there: - most people probably don't start this installer that often, - when I

Re: Make syslinux beep?

2008-07-17 Thread Joey Hess
Frans Pop wrote: It's also annoying for people using automated testing setups as they'd have random beeps coming out of their test systems, but I'll let Joey comment on that. I don't actually have any test systems that boot to syslinux on real hardware, so no beeps. Trust me, the noise of

Re: Make syslinux beep?

2008-07-17 Thread Joey Hess
Frans Pop wrote: I could see myself agreeing if you can come up with an implementation that only includes the beep for official builds (i.e. the addition of the beep is triggered by something in debian/rules). I don't feel that making daily builds diverge here (or in any way that is not

Re: Make syslinux beep?

2008-07-17 Thread Samuel Thibault
Jérémy Bobbio, le Thu 17 Jul 2008 18:57:10 +0200, a écrit : For a version of the installer with full speech synthesis support, a custom image would probably be the _only_ option. One of the other things that we have discussed (but not it full length) with Samuel after his talk during the

Re: Make syslinux beep?

2008-07-17 Thread Otavio Salvador
Frans Pop [EMAIL PROTECTED] writes: (No need to CC me On Thursday 17 July 2008, Samuel Thibault wrote: I do agree it is annoying, but as Sebastien said, it's just about installation. I've asked a few people, they said they wouldn't complain if it could help others. It's annoying for me

Re: Make syslinux beep?

2008-07-16 Thread Samuel Thibault
Hello, There was no answer from debian-boot on this request: Samuel Thibault, le Thu 19 Jun 2008 11:08:32 +0100, a écrit : It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be helpful that syslinux beeps when it is ready to get

Re: Make syslinux beep?

2008-07-16 Thread Frans Pop
On Thursday 17 July 2008, Samuel Thibault wrote: Samuel Thibault, le Thu 19 Jun 2008 11:08:32 +0100, a écrit : It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be helpful that syslinux beeps when it is ready to get input. What

Re: Make syslinux beep?

2008-06-20 Thread Samuel Thibault
Jason White, le Fri 20 Jun 2008 20:27:17 +1000, a écrit : On Thu, Jun 19, 2008 at 04:40:14PM +0100, Samuel Thibault wrote: Unfortunately a lot of BIOSes won't like that ; they will consider that the keyboard is broken. Even if the key is pressed after the POST beep, but before the boot

Re: Make syslinux beep?

2008-06-20 Thread Jason White
On Fri, Jun 20, 2008 at 11:38:29AM +0100, Samuel Thibault wrote: A lot of machines don't have a POST beep. My laptop for instance. I thought that might be a problem. Thanks. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Re: Make syslinux beep?

2008-06-20 Thread Jason White
On Thu, Jun 19, 2008 at 04:40:14PM +0100, Samuel Thibault wrote: Unfortunately a lot of BIOSes won't like that ; they will consider that the keyboard is broken. Even if the key is pressed after the POST beep, but before the boot loader has been read from the installation medium? -- To

Make syslinux beep?

2008-06-19 Thread Samuel Thibault
Hello, It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be helpful that syslinux beeps when it is ready to get input. What do people think about it? Samuel -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of

Re: Make syslinux beep?

2008-06-19 Thread Jan Buchal
ST == Samuel Thibault [EMAIL PROTECTED] writes: ST Hello, It is a bit hard for blind people to know exactly when ST they can type boot options for the installer. It would be ST helpful that syslinux beeps when it is ready to get input. What ST do people think about it? Sure, it

Re: Make syslinux beep?

2008-06-19 Thread Sébastien Hinderer
Hi, It is a bit hard for blind people to know exactly when they can type boot options for the installer. It would be helpful that syslinux beeps when it is ready to get input. What do people think about it? It'd be convenient, yes. In case people do not want an unconditional beep, would it

Re: Make syslinux beep?

2008-06-19 Thread Samuel Thibault
Sébastien Hinderer, le Thu 19 Jun 2008 17:34:03 +0200, a écrit : In case people do not want an unconditional beep, would it be possible to configure syslinux so that keeping a well known combination of key pressed while booting would make it beep when it's ready to accept options.

Re: Make syslinux beep?

2008-06-19 Thread Gaijin
Personally, I'd like to see a configuration option in the installation, like a tasksel option that would reconfigure Debian for the visually impared, running through the system and setting up what it can. The only problem, beyond writing such a script, is accessing it if you're blind.

Re: Make syslinux beep?

2008-06-19 Thread Mario Lang
Gaijin [EMAIL PROTECTED] writes: Personally, I'd like to see a configuration option in the installation, like a tasksel option that would reconfigure Debian for the visually impared, running through the system and setting up what it can. The only problem, beyond writing such a script,

Re: Make syslinux beep?

2008-06-19 Thread Samuel Thibault
Hello, Mario Lang, le Thu 19 Jun 2008 23:40:38 +0200, a écrit : The activation problem is exactly what this thread is about. BTW, for the long term, I was also thinking about unconditional preseeding of debconf from any USB stick which is insertd. That would permit us to have a webpage which

Re: Make syslinux beep?

2008-06-19 Thread Samuel Thibault
Gaijin, le Thu 19 Jun 2008 13:31:34 -0700, a écrit : Personally, I'd like to see a configuration option in the installation, like a tasksel option that would reconfigure Debian for the visually impared, running through the system and setting up what it can. That is already discussed in