Re: boot-floppies auto partitioning hardware detection

2001-10-24 Thread David Kimdon
Hi Christophe, Thanks for the patch. I've gone through and made a few little changes that I'd like you to ok. Once you are happy, I'm happy, and it would be great if you just commit this to cvs. Changes/Notes/Todo/Etc. 1. the libfdisk and the select_not_mounted.c change were more or less

Re: boot-floppies auto partitioning hardware detection

2001-10-24 Thread Christoph Lameter
Looks fine to me. Selective comments below. On Wed, 24 Oct 2001, David Kimdon wrote: 4. I reworked the choose_medium.c patch so now we verify that it is the right cdrom. (see choose_medium.c and util.[ch]). I don't have a cdrom to test with, and I'm not sure if that is the right way to test

Re: boot-floppies auto partitioning hardware detection

2001-10-24 Thread Ethan Benson
On Wed, Oct 24, 2001 at 03:04:36PM -0700, David Kimdon wrote: partition_config.c : If there is only one drive, assume that is the drive we want to partition. FIXME: do we like this? Ask the user if they want to auto partition the drive. If so then take the first drive and divide it into 3

Re: boot-floppies auto partitioning hardware detection

2001-10-24 Thread Christoph Lameter
Then we would probably need arch specific default partitioning strings. Do all arches support fdisk? Then we could simply have different schemes depending on arch. On Wed, 24 Oct 2001, Ethan Benson wrote: On Wed, Oct 24, 2001 at 03:04:36PM -0700, David Kimdon wrote: partition_config.c : If

Re: boot-floppies auto partitioning hardware detection

2001-10-24 Thread Ethan Benson
On Wed, Oct 24, 2001 at 04:50:33PM -0700, Christoph Lameter wrote: Then we would probably need arch specific default partitioning strings. Do all arches support fdisk? Then we could simply have different schemes depending on arch. no, macs must use mac-fdisk, m68K uses pmac-fdisk iirc