Re: More cdebconf patches

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 > Looking at it, it seems the following part of the diff is strange > (src/modules/frontend/gtk/screenshot.c): | width = > gdk_window_get_width(gdk_window); | height = > gdk_window_get_height(gdk_window); | +#if GTK_CHECK_VERSION(3,0,0)

Re: More cdebconf patches

Regis Boudin (2016-01-11): > Indeed it is inverted. And with the screenshot feature not getting > built for deb, I managed to miss it. Combined with the fact I've had > to disable -Werror because of some gcc warning flags. > I'll try to see if I can fix the warnings,

Re: More cdebconf patches

Regis Boudin (2016-01-10): > On 10/01/16 21:40, Cyril Brulebois wrote: […] > Hmm, I didn't test that far. I did follow the GTK doc about migrating > away from gdk_draw_layout(), and use pango_cairo_show_layout() instead, > so it should be fine. I meant to check this part, but

More cdebconf patches

Hi everyone, I just pushed a couple of patches for cdebconf-gtk. Besides removing conditional code to handle old versions of glib, the main change is for the display of text in the banner, done directly with cairo, thus removing the last bit of deprecated GDK code. I believe I've reproduced the

Re: More cdebconf patches

Hi, I'm sorry I didn't follow up to earlier mails about cdebconf patches, haven't been able to process enough other requests… Regis Boudin <re...@boudin.name> (2016-01-10): > I just pushed a couple of patches for cdebconf-gtk. Besides removing > conditional code to handle old vers

Re: More cdebconf patches

Regis Boudin, on Sun 10 Jan 2016 22:54:41 +, wrote: > > - we now need to check that ctrl-+/- still works > > That one probably won't work, seeing that it modifies a file that's not > used by gtk3. Ok, no problem. AIUI gtk3 can be just made to use the dpi information, I'll have a look at

Re: More cdebconf patches

On 10/01/16 21:40, Cyril Brulebois wrote: > Hi, > > I'm sorry I didn't follow up to earlier mails about cdebconf patches, > haven't been able to process enough other requests… No worries. The previous patches I pushed we rather trivial. > Regis Boudin <re...@boudin.name> (2

cdebconf patches

Hi all, Still working on cdebconf, despite being in the middle of a job change, so here are a couple of patches I would like to sumit : 0001 fixes a trivial missing include (database.h includes a reference to DEBCONF_MAX_CONFIGPATH_LEN, which is defined in constants.h 0002 fixes an obvious