Re: partman review

2004-03-05 Thread Sven Luther
On Mon, Mar 01, 2004 at 12:51:10AM +0200, Anton Zinoviev wrote: Attached to this mail you will find a small script `client' and a small C-program server.c. Compile the server and then start the client. The client should print infininte number of strings 'How do you do'. If it doesn't do

Re: partman review

2004-03-05 Thread Anton Zinoviev
On 5.III.2004 at 15:13 Sven Luther wrote: 1) when compiling, i get a warning : server.c:26: attention : comparison is always true due to limited range of data type This discovered the cause of the problem, thanks. In the following expression: while (EOF != (c = fgetc(outfifo))) {}

Re: partman review

2004-03-05 Thread Sven Luther
On Fri, Mar 05, 2004 at 05:19:56PM +0200, Anton Zinoviev wrote: On 5.III.2004 at 15:13 Sven Luther wrote: 1) when compiling, i get a warning : server.c:26: attention : comparison is always true due to limited range of data type This discovered the cause of the problem,

Re: partman review

2004-03-05 Thread Sven Luther
On Sat, Mar 06, 2004 at 12:18:42AM +0200, Anton Zinoviev wrote: On 5.III.2004 at 16:19 Sven Luther wrote: Can you then upload a fixed version as soon as possible, so that we can further test debian-installer on powerpc ? Done. But too late for today, ho well, i will test on sunday.

Re: partman review

2004-03-05 Thread Anton Zinoviev
On 5.III.2004 at 16:19 Sven Luther wrote: Can you then upload a fixed version as soon as possible, so that we can further test debian-installer on powerpc ? Done. Anton Zinoviev -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL

Re: partman review

2004-03-02 Thread Sven Luther
On Mon, Mar 01, 2004 at 12:51:10AM +0200, Anton Zinoviev wrote: On Sun, Feb 29, 2004 at 02:41:46PM +0100, Sven Luther wrote: Hope you can do something with that, and i waited a bit more than a minute. I expected much longer log file. On your machine partman has fallen from the

Re: partman review

2004-03-01 Thread Anton Zinoviev
On 29.II.2004 at 17:09 Joey Hess wrote: Looking at the automatic partitoning menu, I get the feeling this menu was designed to be used this way.. was it? Yes, it was. As to implementation, I think partman-auto could simply povide an init.d script which runs last and displays the menu iff

Re: partman review

2004-02-29 Thread Sven Luther
On Sun, Feb 29, 2004 at 12:34:03AM +0200, Anton Zinoviev wrote: On Sat, Feb 28, 2004 at 01:55:17PM +0100, Sven Luther wrote: Mmm, how long is this delay ? It depends. I don't expect it to be more than 30 sec in the worst case. If the delay you observed is longer then maybe you

Re: partman review

2004-02-29 Thread Sven Luther
On Sun, Feb 29, 2004 at 12:34:03AM +0200, Anton Zinoviev wrote: On Sat, Feb 28, 2004 at 01:55:17PM +0100, Sven Luther wrote: Mmm, how long is this delay ? It depends. I don't expect it to be more than 30 sec in the worst case. If the delay you observed is longer then maybe you

Re: partman review

2004-02-29 Thread Joey Hess
Anton Zinoviev wrote: On Sat, Feb 28, 2004 at 12:08:03PM -0500, Joey Hess wrote: With make TYPE= demo I am unable to reproduce the bugs with the missing swap, forced ext3 and the strange /var/lib. I suppose that they all have one common reason related to cdebconf. Does

Re: partman review

2004-02-29 Thread Joey Hess
Anton Zinoviev wrote: I have observed misterious artifacts similar to /var/lib when I communicated with cdebconf from a pipe. For example in a construction like this one: cat something | while read x; do some_communication with cdebconf; done It was a missing newline between disk entries

Re: partman review

2004-02-29 Thread Anton Zinoviev
On 29.II.2004 at 14:30 Joey Hess wrote: The missing swap problem, like the forced ext3, was a missing udeb, partman-basicfilesystems in this case. After adding that udeb, swap is marked as swap. partman depends on partman-target and partman-target depends on partman-basicfilesystems. All of

Re: partman review

2004-02-29 Thread Anton Zinoviev
On Sun, Feb 29, 2004 at 02:41:46PM +0100, Sven Luther wrote: Hope you can do something with that, and i waited a bit more than a minute. I expected much longer log file. On your machine partman has fallen from the beginning in some infinite loop. This happens before any use of libparted.

Re: partman review

2004-02-29 Thread Joey Hess
One nice thing we could do with partman during the default, high-priority install, would be to make it offer automatic partitioning more promenetntly. This seems like an easy change; the submenu for automatic partitioning is just right, it even includes a menu item for manual partitioning (which

Re: partman review

2004-02-29 Thread Christian Perrier
Quoting Joey Hess ([EMAIL PROTECTED]): One nice thing we could do with partman during the default, high-priority install, would be to make it offer automatic partitioning more promenetntly. This seems like an easy change; the submenu for automatic partitioning is just right, it even includes a

Re: partman review

2004-02-28 Thread Anton Zinoviev
Thanks for your review. I agree with everything I don't comment. On Fri, Feb 27, 2004 at 01:35:47PM -0500, Joey Hess wrote: * It really does need a progress bar at startup. It does seem that fair bit of the delay is disk-bound and not cpu-bound. Yes, it is mostly disk-bound and includes

Re: partman review

2004-02-28 Thread Anton Zinoviev
On Fri, Feb 27, 2004 at 05:23:48PM -0500, Joey Hess wrote: I guess I didn't install those right. I've manged to get them to work, How you did this? So far all tests of partman-ext3 and partman-auto I have done were using make TYPE= demo. With make TYPE= demo I am unable to reproduce

Re: partman review

2004-02-28 Thread Sven Luther
On Fri, Feb 27, 2004 at 01:35:47PM -0500, Joey Hess wrote: This is my little review of partman. I looked at it in depth and tried everything. Please consider this constructive criticism, I think partman is a fine tool overall. * It really does need a progress bar at startup. It does seem

Re: partman review

2004-02-28 Thread Sven Luther
On Sat, Feb 28, 2004 at 02:51:34PM +0200, Anton Zinoviev wrote: Thanks for your review. I agree with everything I don't comment. On Fri, Feb 27, 2004 at 01:35:47PM -0500, Joey Hess wrote: * It really does need a progress bar at startup. It does seem that fair bit of the delay is

Re: partman review

2004-02-28 Thread Joey Hess
Anton Zinoviev wrote: How you did this? So far all tests of partman-ext3 and partman-auto I have done were using make TYPE= demo. I build a hd-media initrd that directly included partman, partman-ext3, partman-auto, partman-partitioning, partman-target, partman-basicmethods,

Re: partman review

2004-02-28 Thread Joey Hess
Anton Zinoviev wrote: Abort does the same as the Back button -- partman exits immediately with error code. It is necessary for frontends without back-capability. There are such frontends? Shouldn't that be fixed instead of working around it in says that are nonintuitive in properly working

Re: partman review

2004-02-28 Thread Anton Zinoviev
On Sat, Feb 28, 2004 at 01:55:17PM +0100, Sven Luther wrote: Mmm, how long is this delay ? It depends. I don't expect it to be more than 30 sec in the worst case. If the delay you observed is longer then maybe you discovered some bug? If this happens again, please send me the output of the

Re: partman review

2004-02-28 Thread Anton Zinoviev
On Sat, Feb 28, 2004 at 12:08:03PM -0500, Joey Hess wrote: With make TYPE= demo I am unable to reproduce the bugs with the missing swap, forced ext3 and the strange /var/lib. I suppose that they all have one common reason related to cdebconf. Does partman ask the filesystem type at

Re: partman review

2004-02-28 Thread Anton Zinoviev
On Sat, Feb 28, 2004 at 12:32:29PM -0500, Joey Hess wrote: Granted, debconf (not cdebconf) has a couple of oddball frontends that do not support backing up, but it has the CAPB command not return backup if one of those frontends is being used. OK. I'd run undo, and then continue, I

Re: partman review

2004-02-28 Thread Joey Hess
Anton Zinoviev wrote: option - description, option - description I am not sure cdebconf can line-wrap long descriptions. (I haven't tried yet, this is just my expectation.) You're right, the descriptions would need to be kept short. Why couldn't I create a 5th partition then? Should

Re: partman review

2004-02-28 Thread Joey Hess
Anton Zinoviev wrote: This script is recently added. Please change its number from 90 to 70. The same change should be done with the script aptinstall_ext3 from partman-ext3. That does fix it, and I'm uploading fixed packages now. -- see shy jo signature.asc Description: Digital

Re: partman review

2004-02-28 Thread Joey Hess
Joey Hess wrote: Now that I've straightened out my initrd, I've managed to create this partman patch. This modifies the main screen with a simpler, cleaner look as I described earlier, including removing the menu items for commit and abort. I've also made some similar changes to the

Re: partman review

2004-02-27 Thread Joey Hess
Now that I've straightened out my initrd, I've managed to create this partman patch. This modifies the main screen with a simpler, cleaner look as I described earlier, including removing the menu items for commit and abort. I've also made some similar changes to the active_partition screen. Since

Re: partman review

2004-02-27 Thread Joey Hess
Joey Hess wrote: * I manually unpacked partman-auto and partman-ext3, and re-ran partman. This added an item to the main menu, titled 10 partman-auto/text/automatically_partition doesn't exist. This may be my error; as I did not go through anna to install this stuff. I did call