Hi,
If there are no more comments on this patch, what's the next step ? I'll be
off in vacation from tomorrow for next week and won't be able to read my
mails, so if something must be done to integrate it in Lenny someone else
will have to take care of this.
If what's missing is the
Hi,
Here are the patches concerning the functional changes. I also modified the
error strings to follow Christian Perrier's advices. Please note that this
patch adds a new string, Multiple disks, that should be translated.
Cheers,
Grégory
diff -ruN --exclude=.svn --exclude=debian
Le dimanche 03 août 2008 09:06, Jérémy Bobbio a écrit :
It puts in global scope some attributes about the last free partition
found on the disk. So what about get_last_free_partition_infos() ?
A lot more meaningful, indeed. :)
Here is an updated patch for the refactoring part, which also
Le samedi 02 août 2008 01:21, Jérémy Bobbio a écrit :
NACK for get_disk_infos(). This name does not reflect at all what the
function does, as far as I understand it.
It puts in global scope some attributes about the last free partition found on
the disk. So what about
We need to create the envelope only if one is not defined. This is the case
when :
- the default device is not part of a PV declaration in the scheme (a PV
is declared when there's a method{ lvm } or method{ crypto }
attribute).
- the recipe contains a PV declaration
Le mercredi 30 juillet 2008 01:48, Jérémy Bobbio a écrit :
Some minor refactoring was needed when writing the code, so why not doing
it while it's still hot ? However I can submit two separate patches if
it's clearer.
I'm already asking quite some work, but if you have the energy, it would
Le mardi 29 juillet 2008 02:18, Jérémy Bobbio a écrit :
+# This function was copied from another file
(partman-auto/lib/initial_auto). +# Maybe it should be useful to put it
in auto-shared.sh or in base.sh +dev_to_partman () {
[…]
It is already in partman-auto-raid, so I think it should
Hi,
Here is an updated version of the patch, dealing with LVM+crypto, as
suggested by Jérémy Bobbio. This patch also incorporate his modifications
to add the possibility to define a custom LV name (see
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=484272).
This patch have been tested in the
Damn, once again there are some remains from my tests... Please disregard
the file partman-auto-lvm-multiple-disks-20080728.diff from my previous
message. Here is the clean one.
Cheers,
GrégoryIndex: debian/partman-auto-lvm.templates
OK, I managed to get qemu running in a sid chroot and to access it via serial
console. This is for the good part.
Le jeudi 24 juillet 2008 11:05, Jérémy Bobbio a écrit :
Please also test normal guided partitioning using LVM and LVM+crypto,
if you can.
Now the bad part is that the base recipes
Le jeudi 24 juillet 2008 11:05, Jérémy Bobbio a écrit :
Try passing -std-vga, as I think vesamenu might be the issue.
Another more twisted way to workaround graphic card issues:
[cut]
Thanks for the hints, but that didn't help. I can see the boot menu, but after
choosing a simple install it
On Wed, Jul 23, 2008 at 10:19:20PM +0200, Grégory Oestreicher wrote:
I was planning to have another look at it soon, but if you have the time
to update and test it before that, that would indeed be great. :)
Well I had some time to merge both patches by hand (not a big deal) and
they still
Hi,
Le mercredi 23 juillet 2008 11:21, Jérémy Bobbio a écrit :
Is it possible to include the creation of those VG and LVs using d-i
preseed configuration file ?
Not currently, but there is two patches against partman-auto-lvm that
needs to be merged and tested. See #462396 [1] for Volume
Hi,
+++ b/packages/partman/partman-auto-lvm/lib/auto-lvm.sh
[...]
-+ if [ -d $tmpdevdir ]; then
++ if [ -d $tmpdevdir ]; then
++ echo $tmpdevdir /tmp/lvtest
What is the purpose of this last line? Or is that just
Le jeudi 24 janvier 2008 16:49, Frans Pop a écrit :
Attaching patch and especially the example recipes to ensure they remain
available. Recipes will be useful as documentation.
Here is an updated patch that correct a bug when
partman-auto-lvm/extra_devices is preseeded but none of them exist.
Package: partman-auto-lvm
Version: 26
Severity: wishlist
Hi,
I finally managed to write a more general patch[1] to have multiple disks
support in partman-auto-lvm. It has been successfully tested on x86 with
the three base recipes of the installer (atomic, home and multi) to
prevent
Le mercredi 23 janvier 2008 17:07, Frans Pop a écrit :
This patch is based on the current (as of 2008/01/20) SVN version of
partman-auto and partman-auto-lvm (the former needing only a minor
modification).
This is a very much better proposal than your last one :-)
Thanks. There's a little
Hi all,
I finally managed to write a more general patch[1] to have multiple disks
support in partman-auto-lvm. It has been successfully tested on x86 with the
three base recipes of the installer (atomic, home and multi) to prevent
regressions, and with four homebrew recipes that show what you
Le mercredi 16 janvier 2008 23:09, Frans Pop a écrit :
As you can see, an additional change was needed in partman-auto-lvm to make
using a primary partition really work (initialization of devfspv_devices
happened after use in create_primary_partitions).
Right, and I didn't noticed it as I
Le mercredi 16 janvier 2008 08:29, Frans Pop a écrit :
I see roughly what you mean, but have some trouble translating it to a
specific situation. With which recipe does this happen (or: how exactly can
I reproduce this bug)?
Actually there's no recipe that should be impacted by this bug. I
Le mardi 15 janvier 2008 11:00, Frans Pop a écrit :
On Monday 14 January 2008, John Philips wrote:
I'm having trouble automating my Debian installs using
preseed and partman. It always creates an extended
partition, even though I don't want it to.
I've just committed a fix for this
(self-answer, sorry)
This introduced a bug : now if a LVM PV is created on a primary partition
it is not added in $devfspv_devices, and auto_lvm_perform should fail.
I confirm this bug, and here is a patch that works for me. It takes all the
flagging out of create_partitions and puts it in a
And with the patch now... Sorry for the noise
Index: lib/auto-shared.sh
===
--- lib/auto-shared.sh (révision 50888)
+++ lib/auto-shared.sh (copie de travail)
@@ -7,7 +7,7 @@
# Create new disk label; don't prompt for label
.
Hi all,
I just finished writing and testing a little patch for partman-auto-lvm to let
it use all available disks in the machine for a single VG.
It can only be used by preseeding for now (partman-auto-lvm/use_all_disks) and
will erase all content in the disks other than the one used by
24 matches
Mail list logo
