Re: [patch] cdebconf and i18n

2002-11-12 Thread Martin Quinson
On Mon, Nov 11, 2002 at 06:40:02PM +0100, Denis Barbier wrote: On Tue, Nov 12, 2002 at 02:39:44AM +0900, Junichi Uekawa wrote: They are in language_country.codeset format. ja_JP is Japan, pt_BR is Brazil. What is the problem? [...] Do you really think that there

Re: [patch] cdebconf and i18n

2002-11-11 Thread Junichi Uekawa
Are you talking about language names? They are either ll or ll_LL. As everything will be UTF-8 encoded, there is no need to add encoding. There is probably a need to add a UTF-8 encoding something, but there probably isn't really a need. Why does it have to be char something[] when char *

Re: [patch] cdebconf and i18n

2002-11-11 Thread Junichi Uekawa
I was thinking more of if (locale == C) question user; else get country from locale. It doesn't work, you can't get country from locale, you must always ask user to tell where he lives. Huh? They are in language_country.codeset format. ja_JP is

Re: [patch] cdebconf and i18n

2002-11-11 Thread Denis Barbier
On Sun, Nov 10, 2002 at 10:08:12AM +0900, Junichi Uekawa wrote: Are you talking about language names? They are either ll or ll_LL. As everything will be UTF-8 encoded, there is no need to add encoding. There is probably a need to add a UTF-8 encoding something, but there probably isn't

Re: [patch] cdebconf and i18n

2002-11-11 Thread Denis Barbier
On Sun, Nov 10, 2002 at 10:06:51AM +0900, Junichi Uekawa wrote: I was thinking more of if (locale == C) question user; else get country from locale. It doesn't work, you can't get country from locale, you must always ask user to tell where he

Re: [patch] cdebconf and i18n

2002-11-11 Thread Martin Sjögren
mån 2002-11-11 klockan 17.17 skrev Denis Barbier: It doesn't work, you can't get country from locale, you must always ask user to tell where he lives. They are in language_country.codeset format. ja_JP is Japan, pt_BR is Brazil. What is the problem? Do you really think that

Re: [patch] cdebconf and i18n

2002-11-11 Thread Denis Barbier
On Mon, Nov 11, 2002 at 05:51:49PM +0100, Martin Sjögren wrote: mån 2002-11-11 klockan 17.17 skrev Denis Barbier: It doesn't work, you can't get country from locale, you must always ask user to tell where he lives. They are in language_country.codeset format. ja_JP is Japan,

Re: [patch] cdebconf and i18n

2002-11-11 Thread Junichi Uekawa
They are in language_country.codeset format. ja_JP is Japan, pt_BR is Brazil. What is the problem? [...] Do you really think that there are no Japanese people outside of Japan? Then they should use ja_CA or whatever they want. regards, junichi -- To UNSUBSCRIBE,

Re: [patch] cdebconf and i18n

2002-11-11 Thread Junichi Uekawa
Why does it have to be char something[] when char * something will perfectly work ? I did not say it has to be a char[6], I do not care if someone wants to malloc it. Please use strdup and friends, or asprintf, or other kind of things that are less prone to break. -- To

Re: [patch] cdebconf and i18n

2002-11-11 Thread Denis Barbier
On Tue, Nov 12, 2002 at 02:39:44AM +0900, Junichi Uekawa wrote: They are in language_country.codeset format. ja_JP is Japan, pt_BR is Brazil. What is the problem? [...] Do you really think that there are no Japanese people outside of Japan? Then they should use ja_CA

Return values of malloc/strdup/... not checked (was Re: [patch] cdebconf and i18n)

2002-11-11 Thread Denis Barbier
On Tue, Nov 12, 2002 at 02:41:23AM +0900, Junichi Uekawa wrote: Why does it have to be char something[] when char * something will perfectly work ? I did not say it has to be a char[6], I do not care if someone wants to malloc it. Please use strdup and friends, or asprintf,

Re: [patch] cdebconf and i18n

2002-11-11 Thread Junichi Uekawa
Do you really think that there are no Japanese people outside of Japan? Then they should use ja_CA or whatever they want. No, this locale does not exist. That doesn't really matter if it doesn't currently exist on your system. You can always make one. regards, junichi --

Re: Return values of malloc/strdup/... not checked (was Re: [patch] cdebconf and i18n)

2002-11-11 Thread Junichi Uekawa
Please use strdup and friends, or asprintf, or other kind of things that are less prone to break. Ok, I will use strdup. While we are on it, why are return values of allocation routines never checked? You could add checks, or use/define xstrdup to give some useful error message. They

Re: [patch] cdebconf and i18n

2002-11-11 Thread Denis Barbier
On Tue, Nov 12, 2002 at 05:13:15AM +0900, Junichi Uekawa wrote: Do you really think that there are no Japanese people outside of Japan? Then they should use ja_CA or whatever they want. No, this locale does not exist. That doesn't really matter if it doesn't currently exist on

Re: [patch] cdebconf and i18n

2002-11-10 Thread Alastair McKinstry
On Sat, 2002-11-09 at 22:47, Denis Barbier wrote: On Sat, Nov 09, 2002 at 05:57:12PM +0100, Alastair McKinstry wrote: [...] Similarly, in some parts of the installer, there is a need to find the Country. Shouldn't that be found from LC_ALL as well? No, user must provide this

Re: [patch] cdebconf and i18n

2002-11-09 Thread Alastair McKinstry
Hi, [ Just lurking on d-i for a while, to get up to speed on the design before contributing]. Why do you use DEBCONF_LANG rather than LANG or LC_ALL ? Similarly, in some parts of the installer, there is a need to find the Country. Shouldn't that be found from LC_ALL as well? Regards, Alastair

Re: [patch] cdebconf and i18n

2002-11-09 Thread Junichi Uekawa
There are two points I am unconfortable with this patch: Why not use locale information ? (it is needed for some frontend and other things) and why is the country information 6-chars long? regards, junichi -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe.

Re: [patch] cdebconf and i18n

2002-11-09 Thread Denis Barbier
On Sat, Nov 09, 2002 at 11:37:07AM +0100, Alastair McKinstry wrote: Hi, [ Just lurking on d-i for a while, to get up to speed on the design before contributing]. Why do you use DEBCONF_LANG rather than LANG or LC_ALL ? No good reason. This is just a temporary workaround until a better

Re: [patch] cdebconf and i18n

2002-11-09 Thread Denis Barbier
On Sat, Nov 09, 2002 at 11:58:35PM +0900, Junichi Uekawa wrote: There are two points I am unconfortable with this patch: Why not use locale information ? (it is needed for some frontend and other things) [I replied in another message] and why is the country information 6-chars long? Are

Re: [patch] cdebconf and i18n

2002-11-09 Thread Alastair McKinstry
On Sat, 2002-11-09 at 16:17, Denis Barbier wrote: On Sat, Nov 09, 2002 at 11:37:07AM +0100, Alastair McKinstry wrote: Hi, [ Just lurking on d-i for a while, to get up to speed on the design before contributing]. Why do you use DEBCONF_LANG rather than LANG or LC_ALL ? No good

Re: [patch] cdebconf and i18n

2002-11-09 Thread Denis Barbier
On Sat, Nov 09, 2002 at 05:57:12PM +0100, Alastair McKinstry wrote: [...] Similarly, in some parts of the installer, there is a need to find the Country. Shouldn't that be found from LC_ALL as well? No, user must provide this information, it cannot be guessed. I was thinking more