Bug#381979: keymap not changed in g-i after selection in kbd-chooser
Frans Pop wrote: On Friday 22 September 2006 22:03, Attilio Fiandrotti wrote: Yes, i think the patch by davide should be applied: when we switch to GTKDFB later, we'll have the chance to re-enable the check on the GDK backend used, so that the GTK frontend works again with GTKX. You did not read the patch I attached! I was suggesting to simply run the dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) ); as davide suggested, no matter the GTKDFB version is :) I don't see any real need to split cases GTK = 2.10.0 and 2.10.0, as no one runs cdebconf with the GTK frontend on X server, but of course the GTK version check is harmless, so please proceed patching the GTK frontend with the patch (Davide's or yours) you prefer. cheers Attilio -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Thu, Sep 21, 2006, Attilio Fiandrotti wrote: GDK_WINDOWING_DIRECTFB is apparently not defined inside gtk.c the following patch works for me GDK_WINDOWING_[X11|DIRECTFB|...] is a macro defined at GTK configure time and in GTK 2.10.4 i can find it defined in gdk/gdkconfig.h, while sourcecode for package libgtk-directfb-2.0-0 doesn not contain it. The problem seems so bounded to GTK 2.8.x with backported DFB backend we currently use, and should be fixed when we switch to GTK 2.10.x. Removing the GDK backend check is harmless unless someone wants to build the GTK frontend against GTKX too, so i guess as a temporary solution it can do. I never noticed this missing define because i usually perform all my test using latest GTK from CVS, thanks to Davide who spotted this :) I've noticed this problem when I compared a full DFB build with a standard X11 build, this is why I've started shipping the gdkconfig.h of the directfb build in /usr/lib/gtk-2.0/include/directfb/gdkconfig.h starting with 2.10.1-1. To use it, you should prepend -I/usr/lib/gtk-2.0/include/directfb to your build flags. I have in my TODO to patch the DirectFB pkg-config files to achieve this, but I didn't have the time to do that yet. -- Loïc Minier [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Thursday 21 September 2006 23:32, Davide Viti wrote: I have just tested keymap switching with a slightly modified patch (attached) with the current 2.8 GTK libs. Attilio: is this patch OK with you? The testresults: - keymap switching works now :-) - VT1 does get quite a few messages Reloading keymap and Reloaded keymap, but it does not get totally flooded, so that is acceptable - the change causes frontend crashes in some situations (see below) :-( - I have now seen a situation where regular + and - don't work to expand/collapse a the full country list (#343244), but instead activate searching; not sure what is happening exactly though as it works in other cases The frontend crashes occur only if the frontend is running while the active console is not VT5 (e.g. VT1 or VT2). I've only seen the crashes while netcfg or partman were running, i.e. when a C program is running; not sure if that is significant. I am willing to ignore this issue for RC1, but I would very much hope it can be resolved before the Etch release! Index: src/modules/frontend/gtk/gtk.c === --- src/modules/frontend/gtk/gtk.c (revision 40817) +++ src/modules/frontend/gtk/gtk.c (working copy) @@ -49,9 +49,13 @@ #include debian-installer/slist.h #include gdk/gdkkeysyms.h +#if GTK_CHECK_VERSION(2,10,0) #ifdef GDK_WINDOWING_DIRECTFB #include directfb.h #endif +#else +#include directfb.h +#endif #define WINDOW_WIDTH 800 #define WINDOW_HEIGHT 600 @@ -1543,10 +1547,15 @@ * for dfb to support automatic keymap change detection and reloading * (See also bug #381979) */ + +#if GTK_CHECK_VERSION(2,10,0) #ifdef GDK_WINDOWING_DIRECTFB dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) ); #endif - +#else +dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) ); +#endif + gtk_rc_reparse_all(); questionbox = gtk_vbox_new(FALSE, 0); pgpyrhYEifAZ8.pgp Description: PGP signature
Bug#381979: keymap not changed in g-i after selection in kbd-chooser
Frans Pop wrote: On Thursday 21 September 2006 23:32, Davide Viti wrote: I have just tested keymap switching with a slightly modified patch (attached) with the current 2.8 GTK libs. Attilio: is this patch OK with you? Yes, i think the patch by davide should be applied: when we switch to GTKDFB later, we'll have the chanche to re-enable the check on the GDK backend used, so that the GTK frontend works again with GTKX. For the crash happening when the acive terminal is not VT5, i'll ask for advice on directfb-dev. cheers Attilio -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: Bug#381979: keymap not changed in g-i after selection in kbd-chooser
Davide Viti wrote: On Tue, Sep 19, 2006 at 10:04:47AM +0200, Frans Pop wrote: On Monday 18 September 2006 23:45, Attilio Fiandrotti wrote: I did not test this by myself, but davide did it and the patch proved to work (Davide, any hint about how to reproduce a correct keymap change in the g-i ?). Davide? this was discussed tonight on IRC. GDK_WINDOWING_DIRECTFB is apparently not defined inside gtk.c the following patch works for me GDK_WINDOWING_[X11|DIRECTFB|...] is a macro defined at GTK configure time and in GTK 2.10.4 i can find it defined in gdk/gdkconfig.h, while sourcecode for package libgtk-directfb-2.0-0 doesn not contain it. The problem seems so bounded to GTK 2.8.x with backported DFB backend we currently use, and should be fixed when we switch to GTK 2.10.x. Removing the GDK backend check is harmless unless someone wants to build the GTK frontend against GTKX too, so i guess as a temporary solution it can do. I never noticed this missing define because i usually perform all my test using latest GTK from CVS, thanks to Davide who spotted this :) cheers Attilio -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Friday 22 September 2006 22:03, Attilio Fiandrotti wrote: Yes, i think the patch by davide should be applied: when we switch to GTKDFB later, we'll have the chance to re-enable the check on the GDK backend used, so that the GTK frontend works again with GTKX. You did not read the patch I attached! pgptdaR7m4l7T.pgp Description: PGP signature
Re: Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Tue, Sep 19, 2006 at 10:04:47AM +0200, Frans Pop wrote: On Monday 18 September 2006 23:45, Attilio Fiandrotti wrote: I did not test this by myself, but davide did it and the patch proved to work (Davide, any hint about how to reproduce a correct keymap change in the g-i ?). Davide? this was discussed tonight on IRC. GDK_WINDOWING_DIRECTFB is apparently not defined inside gtk.c the following patch works for me ciao Davide [EMAIL PROTECTED]:~/cdebconf/106$ cat keymap.patch Index: src/modules/frontend/gtk/gtk.c === --- src/modules/frontend/gtk/gtk.c (revision 40820) +++ src/modules/frontend/gtk/gtk.c (working copy) @@ -49,9 +49,7 @@ #include debian-installer/slist.h #include gdk/gdkkeysyms.h -#ifdef GDK_WINDOWING_DIRECTFB #include directfb.h -#endif #define WINDOW_WIDTH 800 #define WINDOW_HEIGHT 600 @@ -1543,9 +1541,7 @@ * for dfb to support automatic keymap change detection and reloading * (See also bug #381979) */ -#ifdef GDK_WINDOWING_DIRECTFB dfb_input_device_reload_keymap( dfb_input_device_at( DIDID_KEYBOARD ) ); -#endif gtk_rc_reparse_all(); signature.asc Description: Digital signature
Re: Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Monday 18 September 2006 23:45, Attilio Fiandrotti wrote: I did not test this by myself, but davide did it and the patch proved to work (Davide, any hint about how to reproduce a correct keymap change in the g-i ?). Davide? I don't see anything strange in a text console behaviour's not being affected by DFB. VT1 is _not_ the text console. VT2 is and that is localized correctly. VT1 is the console where DFB messages end up... BTW, how is keymap set by the d-i? AFAIK the kernel keymap is changed. pgpLLqxMcCGgU.pgp Description: PGP signature
Bug#381979: keymap not changed in g-i after selection in kbd-chooser
On Sunday 10 September 2006 10:51, Attilio Fiandrotti wrote: After posting on gtk-devel, i received some answers [1] from DFB's main developer and GTKDFB original author, but it seems nothing is going to be done to add the needed functionality at the lower GDK or DFB level, so i propose to apply this patch as a temporary workaround. I have just tested g-i with this patch (local build with cdebconf 0.106 in localudebs) and the keymap is still not changed... I also don't see any indication of the keymap being reloaded on either VT1 or syslog. Attilio: Did you actually test this? If not, could you please? pgpflCHzgNP8b.pgp Description: PGP signature
Re: Bug#381979: keymap not changed in g-i after selection in kbd-chooser
Frans Pop wrote: On Sunday 10 September 2006 10:51, Attilio Fiandrotti wrote: After posting on gtk-devel, i received some answers [1] from DFB's main developer and GTKDFB original author, but it seems nothing is going to be done to add the needed functionality at the lower GDK or DFB level, so i propose to apply this patch as a temporary workaround. I have just tested g-i with this patch (local build with cdebconf 0.106 in localudebs) and the keymap is still not changed... I also don't see any indication of the keymap being reloaded on either VT1 or syslog. Attilio: Did you actually test this? If not, could you please? I did not test this by myself, but davide did it and the patch proved to work (Davide, any hint about how to reproduce a correct keymap change in the g-i ?). I don't see anything strange in a text console behaviour's not being affected by DFB. Rather, i guess VT1 not being localized is a symptom of something not working correctly at an lower level (at the level where kbd-chooser sets the keymap) than DFB or GTKDFB (but i may b wrong) BTW, how is keymap set by the d-i? cheers Attilio -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
