Bug#890867: debootstrap: [Patch] add docker support
On Tue, 20 Feb 2018 09:18:39 +0100 Philip Hands wrote: > As I understand it the way that both fakechroot and docker are being > handled is by invoking what used to be called 'setup_proc_fakechroot'. > Since that function is no longer _just_ for fakechroot it deserves a new > name, so it's been renamed to 'setup_proc_symlink' (as one can see > earlier in the patch) and then of course it needs to also be replaced > here. Yes, exactly. -- Regards, Hideki Yamane henrich @ debian.or.jp/org http://wiki.debian.org/HidekiYamane
Bug#890867: debootstrap: [Patch] add docker support
On Tue, 20 Feb 2018, Geert Stappers wrote: > On Tue, Feb 20, 2018 at 11:27:10AM +0900, Hideki Yamane wrote: >> --- a/scripts/sid >> +++ b/scripts/sid >> @@ -94,7 +95,9 @@ Status: install ok installed" >> >> "$TARGET/var/lib/dpkg/status" >> } >> >> if doing_variant fakechroot; then >> - setup_proc_fakechroot >> + setup_proc_symlink >> + elif work_on docker; then >> + setup_proc_symlink >> else >> setup_proc >> in_target /sbin/ldconfig > > It is > | if doing_variant fakechroot; then > | - setup_proc_fakechroot > | + setup_proc_symlink > that looks strange. > > Please elaborate that change. > Mostly because other modifications were _adding_ code. As I understand it the way that both fakechroot and docker are being handled is by invoking what used to be called 'setup_proc_fakechroot'. Since that function is no longer _just_ for fakechroot it deserves a new name, so it's been renamed to 'setup_proc_symlink' (as one can see earlier in the patch) and then of course it needs to also be replaced here. Cheers, Phil. -- |)| Philip Hands [+44 (0)20 8530 9560] HANDS.COM Ltd. |-| http://www.hands.com/http://ftp.uk.debian.org/ |(| Hugo-Klemm-Strasse 34, 21075 Hamburg,GERMANY signature.asc Description: PGP signature
Bug#890867: debootstrap: [Patch] add docker support
On Tue, Feb 20, 2018 at 11:27:10AM +0900, Hideki Yamane wrote: > --- a/scripts/sid > +++ b/scripts/sid > @@ -94,7 +95,9 @@ Status: install ok installed" >> > "$TARGET/var/lib/dpkg/status" > } > > if doing_variant fakechroot; then > - setup_proc_fakechroot > + setup_proc_symlink > + elif work_on docker; then > + setup_proc_symlink > else > setup_proc > in_target /sbin/ldconfig It is | if doing_variant fakechroot; then | - setup_proc_fakechroot | + setup_proc_symlink that looks strange. Please elaborate that change. Mostly because other modifications were _adding_ code. Groeten Geert Stappers -- Leven en laten leven
Bug#890867: debootstrap: [Patch] add docker support
Package: debootstrap Severity: wishlist Tags: patch Hi, I've added docker support for debootstrap. Could you review it, please? -- Hideki Yamane 0001-support-docker-environment.patch Description: Binary data
