Re: [debian-installer packages] upload of pending changings?

[Samuel Thibault]

Hello,

> cdebconf
> Commits: https://salsa.debian.org/installer-team/cdebconf/commits/master
> by: Colin, Samuel

> rootskel-gtk
> Commits: https://salsa.debian.org/installer-team/rootskel-gtk/commits/master
> by: Samuel

These should be alright to upload.

Thanks,
Samuel

Re: [debian-installer packages] upload of pending changings?

[Cyril Brulebois]

Holger Wansing  (2018-12-23):
> I see the following:
> 
> - deletion of file aclocal.m4 (9600 lines)
> - deletion of file config.guess (1530 lines)
> - deletion of file config.h.in (92 lines)
> - deletion of file config.sub (1782 lines)
> - deletion of file configure (13820 lines)
> - deletion of file depcomp (700 lines)
> - deletion of file doc/Makefile.in (400 lines)
> - deletion of file include/debian-installer/Makefile.in (680 lines)
> - deletion of file include/debian-installer/system/Makefile.in (500 lines)
> - deletion of file include/Makefile.in (640 lines)
> - deletion of file install.sh (520 lines)
> - deletion of file ltmail.sh (9660 lines)
> - deletion of file Makefile.in (830 lines)
> - deletion of file missing (330 lines)
> - deletion of file src/Makefile.in (780 lines)
> - deletion of file src/system/Makefile.in (545 lines)
> 
> This looks rather invasive to me ...
> I would prefer to not upload this one myself.

Oh, on the source side, OK.

Building from git with “git clean -xdf && debuild -S -i -I” and
comparing with the previous upload, one can indeed see:

(sid-amd64-devel)kibi@armor:~/debian-installer/packages$ debdiff 
libdebian-installer_0.11*dsc|diffstat -p 1
dpkg-source: warning: extracting unsigned source package 
(/home/kibi/debian-installer/packages/libdebian-installer_0.117.dsc)
 Makefile.in |  829 -
 aclocal.m4  | 9599 ---
 config.guess| 1530 ---
 config.h.in |   92 
 config.sub  | 1782 ---
 configure   |13820 

 debian/changelog|6 
 debian/control  |4 
 depcomp |  708 -
 doc/Makefile.in |  404 
 include/Makefile.in |  641 -
 include/debian-installer/Makefile.in|  680 -
 include/debian-installer/system/Makefile.in |  499 -
 install-sh  |  527 -
 ltmain.sh   | 9661 ---
 missing |  331 
 src/Makefile.in |  783 -
 src/system/Makefile.in  |  545 -
 18 files changed, 8 insertions(+), 42433 deletions(-)


This is likely because the previous source package was prepared after a
binary build, which left (autotools-related) generated files all over
the place. Nothing to worry about. :)

I've uploaded this package anyway, if only to get it out of your radar.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Re: [debian-installer packages] upload of pending changings?

[Holger Wansing]

Hi,

Cyril Brulebois  wrote:
> 
> > libdebian-installer
> > Commits: 
> > https://salsa.debian.org/installer-team/libdebian-installer/commits/master
> > by: Cyril
> > This is only a trivial change, but a debdiff against the previous
> > version shows many differences, which aren't documented. So I don't
> > want to upload this one without asking...
> 
> Here you should mostly see an update in various versioned dependencies,
> due to the new changelog entry (0.116→0.117); other changes include the
> bump in the libc6-udeb dependency, which happens when there's a new
> glibc version; and slight differences in Installed-Size (to be ignored).
> 
> IOW: This seems safe to upload.

I see the following:

- deletion of file aclocal.m4 (9600 lines)
- deletion of file config.guess (1530 lines)
- deletion of file config.h.in (92 lines)
- deletion of file config.sub (1782 lines)
- deletion of file configure (13820 lines)
- deletion of file depcomp (700 lines)
- deletion of file doc/Makefile.in (400 lines)
- deletion of file include/debian-installer/Makefile.in (680 lines)
- deletion of file include/debian-installer/system/Makefile.in (500 lines)
- deletion of file include/Makefile.in (640 lines)
- deletion of file install.sh (520 lines)
- deletion of file ltmail.sh (9660 lines)
- deletion of file Makefile.in (830 lines)
- deletion of file missing (330 lines)
- deletion of file src/Makefile.in (780 lines)
- deletion of file src/system/Makefile.in (545 lines)

This looks rather invasive to me ...
I would prefer to not upload this one myself.


Holger

-- 
Holger Wansing 
PGP-Finterprint: 496A C6E8 1442 4B34 8508  3529 59F1 87CA 156E B076

Re: [debian-installer packages] upload of pending changings?

[Colin Watson]

On Sun, Dec 23, 2018 at 02:49:23PM +0100, Holger Wansing wrote:
> there are some packages with pending 'coding' changings (other than 
> translation
> changings), which we would want to be uploaded for Buster.
> 
> Since there are also pending translation changings in some of that packages, 
> I would like to have uploads for those, but ask for an extra confirmation, if 
> the coding changings are uncritical for me to upload.

As far as I know all the ones where you've listed my name are fine to
upload.

-- 
Colin Watson   [cjwat...@debian.org]

Re: [debian-installer packages] upload of pending changings?

[Steve McIntyre]

Hi Holger, and thanks for following up on these!

On Sun, Dec 23, 2018 at 02:49:23PM +0100, Holger Wansing wrote:
>there are some packages with pending 'coding' changings (other than translation
>changings), which we would want to be uploaded for Buster.
>
>Since there are also pending translation changings in some of that packages, 
>I would like to have uploads for those, but ask for an extra confirmation, if 
>the coding changings are uncritical for me to upload.
>The other possibility would be that those people (in CC) do the upload which 
>made the 'coding' changings.
>
>
>The relevant packages are:

...

>partman-lvm
>Commits: https://salsa.debian.org/installer-team/partman-lvm/commits/master
>by: Hideki, Steve

Simple fix for text handling in VG names on some edge cases. Ready to
go AFAICS.

>partman-md
>Commits: https://salsa.debian.org/installer-team/partman-md/commits/master
>by: Steve

A fix for #838503, which has been annoying some of our users for a
while. I think it's ready. Not critical to have, but shouldn't cause
issues either.

-- 
Steve McIntyre, Cambridge, UK.st...@einval.com
You raise the blade, you make the change... You re-arrange me 'til I'm sane...

Re: [debian-installer packages] upload of pending changings?

[Cyril Brulebois]

Hi,

Holger Wansing  (2018-12-23):
> there are some packages with pending 'coding' changings (other than
> translation changings), which we would want to be uploaded for Buster.
> 
> Since there are also pending translation changings in some of that
> packages, I would like to have uploads for those, but ask for an extra
> confirmation, if the coding changings are uncritical for me to upload.
> The other possibility would be that those people (in CC) do the upload
> which made the 'coding' changings.

Thanks for prodding us about those changes. I'll focus on those where
I'm listed.

> debian-installer-netboot-images
> Commits: 
> https://salsa.debian.org/installer-team/debian-installer-netboot-images/commits/master
> by: Cyril, Mattia
> These are trivial changings, but I was unsure, if an upload could somehow 
> affect build of images?

I'll check and upload this one.

FWIW: This package (also called dini or d-i-n-i) can't interfere with
the debian-installer build process as it actually consumes what the
src:debian-installer produces. This is mostly a bundle of everything the
various netboot* targets (in debian-installer) produce. But thanks for
asking anyway. :)

> libdebian-installer
> Commits: 
> https://salsa.debian.org/installer-team/libdebian-installer/commits/master
> by: Cyril
> This is only a trivial change, but a debdiff against the previous
> version shows many differences, which aren't documented. So I don't
> want to upload this one without asking...

Here you should mostly see an update in various versioned dependencies,
due to the new changelog entry (0.116→0.117); other changes include the
bump in the libc6-udeb dependency, which happens when there's a new
glibc version; and slight differences in Installed-Size (to be ignored).

IOW: This seems safe to upload.

> Thanks and Merry Christmas to you all

Season's greetings as well. :)


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature