Your message dated Wed, 20 Sep 2017 00:04:43 +0000 with message-id <e1dusvp-000asb...@fasolo.debian.org> and subject line Bug#875261: fixed in yasw 0.6-2 has caused the Debian Bug report #875261, regarding src:yasw: FTBFS on armhf, armel, sh4 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 875261: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=875261 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: src:yasw Version: 0.6-1 Severity: important Tags: patch Justification: fails to build from source Hi! As you already know, yasw fails to build on a few architectures: filter/layoutfilter.cpp: In member function 'virtual QImage LayoutFilter::filter(QImage)': filter/layoutfilter.cpp:197:60: error: no matching function for call to 'qMax(qreal, double)' leftMargin = qMax((pageWidth - imageWidth) / 2, 0.0); ^ There's a patch in the original RFS bug, I'm filing it here so it doesn't get lost. As the last upstream release was in 2014, a timely update is quite unlikely. Meow! -- System Information: Debian Release: buster/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: armhf (armv7l) Kernel: Linux 4.13.0-00222-g22e5e0f1edea (SMP w/4 CPU cores; PREEMPT) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=C.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: sysvinit (via /sbin/init)Fix build failure on armhf and armel. This is the result of QT's brain damage: they use inconsistent types on these architectures: https://doc.qt.io/qt-4.8/qtglobal.html#qreal-typedef As we don't know whether qreal is float or double, we can't use a suffix for the literal and need a type cast. --- yasw-0.6.orig/src/filter/layoutfilter.cpp +++ yasw-0.6/src/filter/layoutfilter.cpp @@ -194,10 +194,10 @@ QImage LayoutFilter::filter(QImage input leftMargin = 0; break; case Constants::CenterHAlignment: - leftMargin = qMax((pageWidth - imageWidth) / 2, 0.0); + leftMargin = qMax((pageWidth - imageWidth) / 2, (qreal)0.0); break; case Constants::RightHAlignment: - leftMargin = qMax(pageWidth - imageWidth, 0.0); + leftMargin = qMax(pageWidth - imageWidth, (qreal)0.0); break; } switch (Constants::verticalAlignment.indexOf(verticalAlignement)) { @@ -205,10 +205,10 @@ QImage LayoutFilter::filter(QImage input topMargin = 0; break; case Constants::CenterVAlignment: - topMargin = qMax((pageHeight - imageHeight) / 2, 0.0); + topMargin = qMax((pageHeight - imageHeight) / 2, (qreal)0.0); break; case Constants::BottomVAlignment: - topMargin = qMax(pageHeight - imageHeight, 0.0); + topMargin = qMax(pageHeight - imageHeight, (qreal)0.0); break; }
--- End Message ---
--- Begin Message ---Source: yasw Source-Version: 0.6-2 We believe that the bug you reported is fixed in the latest version of yasw, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 875...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andrew Ross <ubu...@rossfamily.co.uk> (supplier of updated yasw package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 19 Sep 2017 20:05:32 +0100 Source: yasw Binary: yasw Architecture: source Version: 0.6-2 Distribution: unstable Urgency: medium Maintainer: Andrew Ross <ubu...@rossfamily.co.uk> Changed-By: Andrew Ross <ubu...@rossfamily.co.uk> Description: yasw - Yet Another Scan Wizard Closes: 875261 Changes: yasw (0.6-2) unstable; urgency=medium . * Fix armhf build failures (Closes: #875261). * Switch to qt5. Checksums-Sha1: 21a95dfa6e62460024ac9d689b26af35bd577a64 1338 yasw_0.6-2.dsc a86483732acc46119b0d3eaee544376f0ea7a50b 2800 yasw_0.6-2.debian.tar.xz 8858dd1c357975fd1cdf452337ffb8d323d250c1 5073 yasw_0.6-2_source.buildinfo Checksums-Sha256: 099483e614177df29786950f66f371ded4228ea3d17c58eea0a23b97f185ac2a 1338 yasw_0.6-2.dsc dd1b90d14465ce59d640cf6d8d652ce84b2dbcfeaf36c65375d8b97d430b7cb2 2800 yasw_0.6-2.debian.tar.xz e5c054bc46653b21580dae53d628b742c1750eddd4e581818dcc70d49ae7c35c 5073 yasw_0.6-2_source.buildinfo Files: d8f8d1594db1424d207629f4a38bc45d 1338 graphics extra yasw_0.6-2.dsc dd53aef2c267b8a02be3794c2d36b996 2800 graphics extra yasw_0.6-2.debian.tar.xz 18393d021093e091ad3aa006df3ff97a 5073 graphics extra yasw_0.6-2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE/Zzi2Nd1S3irJ5u9LDtDb+rGgQEFAlnBrIAACgkQLDtDb+rG gQEEUwgAjIoiVKoA47+5n70f79E4znRLxa6pFDS/ckV/gSV8RXBdmjK81u7fPtXq 6HLCuGJKH37VfW2w50LTBMWlNo/RZLA0lkHHB5KqX8aEa4dIYAIAzUAvDj7VzNJs wlWYQpKTkG8jyZaglxymeWYCBVG6oFTQj5q7BernubBJmzDLMvED3liLevHwlYX1 oEWIAPSqEN/4QAaqNI4NJ5w/Fq6SmbreFkO18idyNjeCt30jm12S4QKnVcIbyiF6 3zA3nDGj9E0AccIiGGpLi8Gdxu8nAzR+OyW++jXZgL9Y1PfthyEWOHcjOUepwR6f GCoAbYY+TQM2q9fwELzQaMWjezKBCg== =TQNp -----END PGP SIGNATURE-----
--- End Message ---
